From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83F4BC433EF for ; Thu, 11 Nov 2021 15:04:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0CE961038 for ; Thu, 11 Nov 2021 15:04:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0CE961038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlBcl-0007gL-Ts for qemu-devel@archiver.kernel.org; Thu, 11 Nov 2021 10:04:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlBUa-0002bm-ND for qemu-devel@nongnu.org; Thu, 11 Nov 2021 09:55:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58539) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlBUX-00043u-4B for qemu-devel@nongnu.org; Thu, 11 Nov 2021 09:55:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636642552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7texmKV8Zq7mKL67E2QaK6ar8VikvSvg/agDvN+KiY=; b=GuU+QG8/UkPTFPs1WWA60a8QYB7zAIhBZwC/RbDqND/upG58oRT9q3EgDyScLNO7aSuMb5 HJQFjslIYoZF6XEyXdzzstWJTeXJBGDAmwiGsYmbw9rMq+rm+WDCdI+o4+7WpQuUn5sNEc DykGVvUi0SoT9ww+o7xLMlryPu9mFOE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-SA60f0fCNNCbXrkXmNiqwQ-1; Thu, 11 Nov 2021 09:55:51 -0500 X-MC-Unique: SA60f0fCNNCbXrkXmNiqwQ-1 Received: by mail-wm1-f70.google.com with SMTP id o18-20020a05600c511200b00332fa17a02eso2815828wms.5 for ; Thu, 11 Nov 2021 06:55:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Z7texmKV8Zq7mKL67E2QaK6ar8VikvSvg/agDvN+KiY=; b=jnJYInScvk7FRe6GvcXvZXiuLaJ9iWeeMxeA1N09V5e/kznrk7exiKhsY3KaJcqen0 1lRX0rODUtYeBXlwLt3mHsd19kyIXLvydCZbdMuYeiQ8oBtzNUJyLj46cr/2fYjuet6w cFFfe+MVAOICAo4gEzvdDTJT4yXrwun9r7YzZy6j7Ea5QSNsefCdX/l6XLWQwZ5qhQnK 78o6fDWQ/B4fjBlZKhxQ9HgP+kTgNRLHArJcO2rFDjM8zCCGLa3kUjhQV/FG5M9rGLtc YEEhvMbdHxXIdlpUqUajVCka//MJGreq649CJLlTuhQU9Hs5VpS9n2KF+Vh6pnMFxnv+ RdNA== X-Gm-Message-State: AOAM532vjTXOlkik/5uHPhgvnm1Hq0SlVxz/uQs6yy6WRaM9bvHCu8SC b0hUm3TAMiz48C1m4HJRswwdDK+PXv2fytG3G82ZvDPvyaRinJJCXt/wte6lYdnJZAmByTLqvN4 Zf8CcS9319yvVNAE= X-Received: by 2002:a05:600c:2252:: with SMTP id a18mr27525790wmm.133.1636642550145; Thu, 11 Nov 2021 06:55:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwjWN0bxMhP74bXqDch7iqOGpAYEZys31qZ+AQLY5c2PG1PVDBhgU+7CJ1qexRqTrKv3EDD0Q== X-Received: by 2002:a05:600c:2252:: with SMTP id a18mr27525767wmm.133.1636642549900; Thu, 11 Nov 2021 06:55:49 -0800 (PST) Received: from [192.168.1.36] (62.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.62]) by smtp.gmail.com with ESMTPSA id k8sm2991651wrn.91.2021.11.11.06.55.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 06:55:49 -0800 (PST) Message-ID: Date: Thu, 11 Nov 2021 15:55:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 2/2] hw/core/loader: workaround read() size limit. To: Jamie Iles , qemu-devel@nongnu.org References: <20211111141141.3295094-1-jamie@nuviainc.com> <20211111141141.3295094-3-jamie@nuviainc.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20211111141141.3295094-3-jamie@nuviainc.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -74 X-Spam_score: -7.5 X-Spam_bar: ------- X-Spam_report: (-7.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.999, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lmichel@kalray.eu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Jamie, On 11/11/21 15:11, Jamie Iles wrote: > On Linux, read() will only ever read a maximum of 0x7ffff000 bytes > regardless of what is asked. If the file is larger than 0x7ffff000 > bytes the read will need to be broken up into multiple chunks. > > Cc: Luc Michel > Signed-off-by: Jamie Iles > --- > hw/core/loader.c | 40 ++++++++++++++++++++++++++++++++++------ > 1 file changed, 34 insertions(+), 6 deletions(-) > > diff --git a/hw/core/loader.c b/hw/core/loader.c > index 348bbf535bd9..16ca9b99cf0f 100644 > --- a/hw/core/loader.c > +++ b/hw/core/loader.c > @@ -80,6 +80,34 @@ int64_t get_image_size(const char *filename) > return size; > } > > +static ssize_t read_large(int fd, void *dst, size_t len) > +{ > + /* > + * man 2 read says: > + * > + * On Linux, read() (and similar system calls) will transfer at most > + * 0x7ffff000 (2,147,479,552) bytes, returning the number of bytes Could you mention MAX_RW_COUNT from linux/fs.h? > + * actually transferred. (This is true on both 32-bit and 64-bit > + * systems.) Maybe "This is true for both ILP32 and LP64 data models used by Linux"? (because that would not be the case for the ILP64 model). Otherwise s/systems/Linux variants/? > + * > + * So read in chunks no larger than 0x7ffff000 bytes. > + */ > + size_t max_chunk_size = 0x7ffff000; We can declare it static const. > + size_t offset = 0; > + > + while (offset < len) { > + size_t chunk_len = MIN(max_chunk_size, len - offset); > + ssize_t br = read(fd, dst + offset, chunk_len); > + > + if (br < 0) { > + return br; > + } > + offset += br; > + } > + > + return (ssize_t)len; > +} I see other read()/pread() calls: hw/9pfs/9p-local.c:472: tsize = read(fd, (void *)buf, bufsz); hw/vfio/common.c:269: if (pread(vbasedev->fd, &buf, size, region->fd_offset + addr) != size) { ... Maybe the read_large() belongs to "sysemu/os-xxx.h"?