All of lore.kernel.org
 help / color / mirror / Atom feed
From: "HenryC Chen (陳建豪)" <HenryC.Chen@mediatek.com>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Stephen Boyd" <swboyd@chromium.org>,
	"Ryan Case" <ryandcase@chromium.org>,
	"Mark Brown" <broonie@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Nicolas Boichat" <drinkcat@google.com>,
	"Fan Chen (陳凡)" <fan.chen@mediatek.com>,
	"JamesJJ Liao (廖建智)" <jamesjj.liao@mediatek.com>,
	"Arvin Wang (王志銘)" <Arvin.Wang@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver
Date: Wed, 6 Jan 2021 10:44:52 +0000	[thread overview]
Message-ID: <c9b360dcb17e452595f45adb51dd4c31@mtkmbs02n1.mediatek.inc> (raw)
In-Reply-To: <a416a55c-0a7e-6505-ef53-b03f5dbc6cdc@linaro.org>

> -----Original Message-----
> From: Georgi Djakov [mailto:georgi.djakov@linaro.org]
> Sent: Wednesday, January 06, 2021 4:14 PM
> To: HenryC Chen (陳建豪)
> Cc: Rob Herring; Matthias Brugger; Stephen Boyd; Ryan Case; Mark Brown; Mark
> Rutland; Nicolas Boichat; Fan Chen (陳凡); JamesJJ Liao (廖建智); Arvin Wang
> (王志銘); devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-mediatek@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> pm@vger.kernel.org
> Subject: Re: [PATCH V6 08/13] interconnect: mediatek: Add interconnect
> provider driver
> 
> On 1/6/21 09:30, Henry Chen wrote:
> > On Mon, 2021-01-04 at 20:36 +0200, Georgi Djakov wrote:
> >> On 12/24/20 08:08, Henry Chen wrote:
> >>> Introduce Mediatek MT6873/MT8183/MT8192 specific provider driver
> >>> using the interconnect framework.
> >>>
> >>>                ICC provider         ICC Nodes
> >>>                                 ----          ----
> >>>                ---------       |CPU |   |--- |VPU |
> >>>       -----   |         |-----  ----    |     ----
> >>>      |DRAM |--|DRAM     |       ----    |     ----
> >>>      |     |--|scheduler|----- |GPU |   |--- |DISP|
> >>>      |     |--|(EMI)    |       ----    |     ----
> >>>      |     |--|         |       -----   |     ----
> >>>       -----   |         |----- |MMSYS|--|--- |VDEC|
> >>>                ---------        -----   |     ----
> >>>                  /|\                    |     ----
> >>>                   |change DRAM freq     |--- |VENC|
> >>>                ----------               |     ----
> >>>               |  DVFSR   |              |
> >>>               |          |              |     ----
> >>>                ----------               |--- |IMG |
> >>>                                         |     ----
> >>>                                         |     ----
> >>>                                         |--- |CAM |
> >>>                                               ----
> >>>
> >>> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> >>> ---
> >>>    drivers/interconnect/Kconfig            |   1 +
> >>>    drivers/interconnect/Makefile           |   1 +
> >>>    drivers/interconnect/mediatek/Kconfig   |  13 ++
> >>>    drivers/interconnect/mediatek/Makefile  |   3 +
> >>>    drivers/interconnect/mediatek/mtk-emi.c | 330
> ++++++++++++++++++++++++++++++++
> >>>    5 files changed, 348 insertions(+)
> >>>    create mode 100644 drivers/interconnect/mediatek/Kconfig
> >>>    create mode 100644 drivers/interconnect/mediatek/Makefile
> >>>    create mode 100644 drivers/interconnect/mediatek/mtk-emi.c
> >>>
> >>> diff --git a/drivers/interconnect/Kconfig
> >>> b/drivers/interconnect/Kconfig index 5b7204e..e939f5a 100644
> >>> --- a/drivers/interconnect/Kconfig
> >>> +++ b/drivers/interconnect/Kconfig
> >>> @@ -13,5 +13,6 @@ if INTERCONNECT
> >>>
> >>>    source "drivers/interconnect/imx/Kconfig"
> >>>    source "drivers/interconnect/qcom/Kconfig"
> >>> +source "drivers/interconnect/mediatek/Kconfig"
> >>
> >> Sort alphabetically please.
> > Ok
> >>
> >>>
> >>>    endif
> >>> diff --git a/drivers/interconnect/Makefile
> >>> b/drivers/interconnect/Makefile index d203520..0643a24 100644
> >>> --- a/drivers/interconnect/Makefile
> >>> +++ b/drivers/interconnect/Makefile
> >>> @@ -6,3 +6,4 @@ icc-core-objs				:= core.o bulk.o
> >>>    obj-$(CONFIG_INTERCONNECT)		+= icc-core.o
> >>>    obj-$(CONFIG_INTERCONNECT_IMX)		+= imx/
> >>>    obj-$(CONFIG_INTERCONNECT_QCOM)		+= qcom/
> >>> +obj-$(CONFIG_INTERCONNECT_MTK)		+= mediatek/
> >>
> >> Ditto.
> > Ok
> >>
> >>> diff --git a/drivers/interconnect/mediatek/Kconfig
> >>> b/drivers/interconnect/mediatek/Kconfig
> >>> new file mode 100644
> >>> index 0000000..972d3bb
> >>> --- /dev/null
> >>> +++ b/drivers/interconnect/mediatek/Kconfig
> >>> @@ -0,0 +1,13 @@
> >>> +config INTERCONNECT_MTK
> >>> +	bool "Mediatek Network-on-Chip interconnect drivers"
> >>> +	depends on ARCH_MEDIATEK
> >>> +	help
> >>> +	  Support for Mediatek's Network-on-Chip interconnect hardware.
> >>> +
> >>> +config INTERCONNECT_MTK_EMI
> >>> +	tristate "Mediatek EMI interconnect driver"
> >>> +	depends on INTERCONNECT_MTK
> >>> +	depends on (MTK_DVFSRC && OF)
> >>
> >> Would it be possible to enable COMPILE_TEST?
> > Do you means change to "depends on (MTK_DVFSRC && OF) || COMPILE_TEST" ?
> 
> Yeah, there is a stub for mtk_dvfsrc_send_request(). Maybe we could even
> change it for INTERCONNECT_MTK to something like:
> 	depends on ARCH_MEDIATEK || COMPILE_TEST Will this work?
Hi Georgi,

So..only change to as following? 

config INTERCONNECT_MTK
	bool "Mediatek Network-on-Chip interconnect drivers"
	depends on ARCH_MEDIATEK || COMPILE_TEST
	help
	  Support for Mediatek's Network-on-Chip interconnect hardware.

> 
> Thanks,
> Georgi

  reply	other threads:[~2021-01-06 10:51 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24  6:08 [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Henry Chen
2020-12-24  6:08 ` Henry Chen
2020-12-24  6:08 ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 01/13] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24 17:01   ` Rob Herring
2020-12-24 17:01     ` Rob Herring
2020-12-24 17:01     ` Rob Herring
2020-12-25  5:12     ` Henry Chen
2020-12-25  5:12       ` Henry Chen
2020-12-25  5:12       ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 02/13] soc: mediatek: add header for mediatek SIP interface Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 03/13] soc: mediatek: add driver for dvfsrc support Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24 14:33   ` Chun-Kuang Hu
2020-12-24 14:33     ` Chun-Kuang Hu
2020-12-24 14:33     ` Chun-Kuang Hu
2020-12-25  5:14     ` Henry Chen
2020-12-25  5:14       ` Henry Chen
2020-12-25  5:14       ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 04/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 05/13] arm64: dts: mt8192: " Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 06/13] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2021-01-08  2:53   ` Rob Herring
2021-01-08  2:53     ` Rob Herring
2021-01-08  2:53     ` Rob Herring
2020-12-24  6:08 ` [PATCH V6 07/13] dt-bindings: interconnect: add MT6873 " Henry Chen
2020-12-24  6:08   ` Henry Chen
2021-01-04 18:34   ` Georgi Djakov
2021-01-04 18:34     ` Georgi Djakov
2021-01-04 18:34     ` Georgi Djakov
2021-01-06  7:25     ` Henry Chen
2021-01-06  7:25       ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 08/13] interconnect: mediatek: Add interconnect provider driver Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2021-01-04 18:36   ` Georgi Djakov
2021-01-04 18:36     ` Georgi Djakov
2021-01-04 18:36     ` Georgi Djakov
2021-01-06  7:30     ` Henry Chen
2021-01-06  7:30       ` Henry Chen
2021-01-06  7:30       ` Henry Chen
2021-01-06  8:14       ` Georgi Djakov
2021-01-06  8:14         ` Georgi Djakov
2021-01-06  8:14         ` Georgi Djakov
2021-01-06 10:44         ` HenryC Chen (陳建豪) [this message]
2021-01-06 12:49           ` Georgi Djakov
2021-01-06 12:49             ` Georgi Djakov
2021-01-06 12:49             ` Georgi Djakov
2021-01-06 13:11             ` HenryC Chen (陳建豪)
2020-12-24  6:08 ` [PATCH V6 09/13] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 10/13] arm64: dts: mt8192: " Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 11/13] regulator: Regulator driver for the Mediatek DVFSRC Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 12/13] arm64: dts: mt8183: add dvfsrc regulator nodes Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08   ` Henry Chen
2020-12-24  6:08 ` [PATCH V6 13/13] arm64: dts: mt8192: " Henry Chen
2020-12-24  6:08   ` Henry Chen
2021-01-05 16:07 ` (subset) [PATCH V6 00/13] Add driver for dvfsrc, support for active state of scpsys Mark Brown
2021-01-05 16:07   ` Mark Brown
2021-01-05 16:07   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9b360dcb17e452595f45adb51dd4c31@mtkmbs02n1.mediatek.inc \
    --to=henryc.chen@mediatek.com \
    --cc=Arvin.Wang@mediatek.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@google.com \
    --cc=fan.chen@mediatek.com \
    --cc=georgi.djakov@linaro.org \
    --cc=jamesjj.liao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=ryandcase@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.