From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4488DC6FD1C for ; Wed, 22 Mar 2023 08:51:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F63B85CFC; Wed, 22 Mar 2023 09:51:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=weidmueller.onmicrosoft.com header.i=@weidmueller.onmicrosoft.com header.b="wpev4EkT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7A42A85D13; Wed, 22 Mar 2023 09:51:39 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on20617.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::617]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8F10085C54 for ; Wed, 22 Mar 2023 09:51:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=weidmueller.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=stefan.herbrechtsmeier-oss@weidmueller.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h46pwTpXArw1brvneQM37+UJGsgvdxxHy4Y6piNgox2XLw5/nZKmvpWr2he5nvL1ZKWmnQArEPff3nqQ42hqcf+dNLofX5ioANemch5WQ6ePNK11td2qdtetOhUPvfH2BkiTMsyvknPdFdBvaoba9spmJjVm2QLs7n7bCRb6YvK88CZJzd//kUwGAtnBI07WXDiwxViDerz/eNVr3TmE9bMqPQJshkF9RrOhRCYMPbYx7j9dRsRdsZMtzKi3MfL3D9TEZWQPKL2Xqnh7DPtfEg+LoJjBXsMxaOrx6hRRJigWqJJ5EqPkSh6YUHbBwMdxwiOdLOt1jSh70cKd6aQviA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h8m1kuZo0E5jkvfsLoctgeXy+s+ygKhrlzkE8DHppe8=; b=mAH4lSKdlyR3bZ7o6E12sxQ9tgYr/o8SHoCFUcGKhPX2G8VmPOwlRxQMD3qVYwc8dDd8Ey3tbEBcRrtcbtikX7VdrBcBTheMSRVVe1W9IykCPcj2XampJJTsFNoaT6kdHd9ei+4drM7qORkjBWOq/qleV89N3kjJ0fShcSmC3IIBj9P7PxvGQblE1IP6yNpo9LZ18V0mbmYHab+ebJ8bMPdJ10xg04UgkZwoNCzkVtGzxUemGaTp2VngZhgRfEqh1Q33OaKu8iEkxHEhmLzIXas9sddpp9x9/ss2OpiF4qebP2N32GvFXcJl6dfjHOdjdYGcvSYpOVJk/Ov8iky8ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=weidmueller.com; dmarc=pass action=none header.from=weidmueller.com; dkim=pass header.d=weidmueller.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weidmueller.onmicrosoft.com; s=selector1-weidmueller-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h8m1kuZo0E5jkvfsLoctgeXy+s+ygKhrlzkE8DHppe8=; b=wpev4EkTsUbVgHtsd+9TPhmREPwC0hL3diJVgN4lA4gckwuF49JAXR7ROX56EMG92VVPz6FYNiL37uo88oX4Tgtfk4yTxWey5duZumRJvV1PIoT1Y60Oevv5vyQX57hI0XWonw7jxLtJy0bics0S2te6Z4ftqu+sH3TWEUA7ZrA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=weidmueller.com; Received: from PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) by GV1PR08MB7683.eurprd08.prod.outlook.com (2603:10a6:150:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 08:51:33 +0000 Received: from PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::bb7b:6a6:db8c:e8e3]) by PAXPR08MB6969.eurprd08.prod.outlook.com ([fe80::bb7b:6a6:db8c:e8e3%5]) with mapi id 15.20.6178.037; Wed, 22 Mar 2023 08:51:33 +0000 Message-ID: Date: Wed, 22 Mar 2023 09:51:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] fs: fat: do not mangle short filenames To: Tom Rini Cc: u-boot@lists.denx.de, Stefan Herbrechtsmeier , Simon Glass References: <20230317120413.11066-1-stefan.herbrechtsmeier-oss@weidmueller.com> <20230320170105.GA8135@bill-the-cat> <20230321153535.GS8135@bill-the-cat> <0ddfb023-08a4-8469-f467-c871cfd596bb@weidmueller.com> <20230321155404.GX8135@bill-the-cat> From: Stefan Herbrechtsmeier In-Reply-To: <20230321155404.GX8135@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::18) To PAXPR08MB6969.eurprd08.prod.outlook.com (2603:10a6:102:1d8::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR08MB6969:EE_|GV1PR08MB7683:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d869f90-a20a-4332-7537-08db2ab2a322 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O1bjbGs26ctK0RJEJdphht0QwHOqVQGN05fCqiC1c83psgbQPzYJogU4VWf1ORJ8Fs9ZUfKVh3ZaDcAhebBPkWkzbf6gLj72spOidhsOTG/wpLSVXG9k9wkenj4S2yjpA9fveglOS6IfC6Bawn6uiA6iT7pickePGDn/g6u+LmxHXX+crZlGt5qxI2Fni1/c/Hoj8oPZKMvW5Kq565BCgY6W6otDtioVwIlr0TecOmrwvM+bvZ2cKYPin8Yc/ILqdWcoB/OOytoxTOwgIjV1tDyGnQMtTrObOn3WaV41P/oNXOyXacjGDF/yROm0BvpmtBdEau7NNBtVkrJ6nfog0FsmYuad+PU2GOdpK7PMpzOFkdIjTwVJULvViZjTMfdBPCoYgy3pFF+To5zjOBWOxTb/g3wMB8sU1JspFBzu1WQJ8bULDBTtG62VEMRe2WjCT1tZ0P/AlK6rouzgpUytVR+Sn/4/4RtPbeYUW3059xenbfv+6IFS5hgkoMPX0flwukuMuqiSocSmD+1nHxgeJPEJfEG3lz9Gwu51apU/07zTUsNcegwtP9R+O4sEGfbLYBA9BAmQdXNIurJ+6fDgkrRAjxjVWZ89GGjgkmj9vUCf+O/qnsQ8Pg+2/z5atHavUtF2mwvwVGqhTw0lKLLZB1rs92cJ9OS5IqNvLNN/i3te7NnZ4o+nWXDCZwdWoGqob6D4N/6lqEx8ZnOrouSQAYAFv8bS+KLiqWtjByuqZKSO1ZyODpSminrf7BM0yT9kT8sUs4dLnQsZDC1wrIZcNA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR08MB6969.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(451199018)(2616005)(83380400001)(38100700002)(6916009)(31696002)(38350700002)(2906002)(4326008)(66476007)(41300700001)(36756003)(86362001)(8676002)(66556008)(5660300002)(66946007)(26005)(6486002)(186003)(6512007)(316002)(8936002)(54906003)(52116002)(478600001)(6506007)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zloxb1B4V0lmSVJhbHhPOXlyWW0wcjJuZE5TTjJMdUF4VmY3MXBnNWVUUTd2?= =?utf-8?B?Wld0UXkrbmcxcnA3bmh6WDJHRnduNDlLbmdSL0trRk9QSzIzaG1sRW9IeTZY?= =?utf-8?B?Y2FoQ3R4TUhWVFo5cTB2MzRsNjhENStuMVloYm1oQUVCNDhWUy9DSHJ6N0Yr?= =?utf-8?B?UmF5MjhSRU0wdzh2OXhFR0J3Sy9KTDllVWRKVEFxRHdSWGpPNXJNOXVEQnds?= =?utf-8?B?dkpuUnBmMXNVWXlWb0pOZGt4M1FuSlQvZUR0Y2Z6UFZCNCtpWUtpUk1mYjBu?= =?utf-8?B?Y0xkVDVCZVNKaE5oL0JoVUdxVDVQN05SekU1eW1kdjZjVjRzQ2VBWGVKdnh3?= =?utf-8?B?NG93Nk1SVlp3a253MWduT2J2TGxaaEthT2FwWUNGQUU5aXEvVjNkOVpEb0k4?= =?utf-8?B?d2tpbjYxZElCdm16MmdFMkNQYVlSUlk0eXR2SldnNFRGblE2L1o1SHA5cmZz?= =?utf-8?B?T3pDNHZXb1pJd3QrNThiTGlLY1B1WHllUHd1WmRhSlJ4OGdFc2orS1VRWjJo?= =?utf-8?B?Z3JiK2JmVi9IRm9jKy83N3A0Qys0THM4WUhTNEl3azQ2MFV1aWlnUjRTWVVR?= =?utf-8?B?OEVwMFhRWVdDR1pkWGdkcUJqNzhXR05ueks5NldnUWNneE1nRVJXdWM0TG1R?= =?utf-8?B?eENIRVVISGVsb2Zhd3dwU0xhMW1EK3NTMHI2YzFUWGdNQWdBeWNXU0EvajBn?= =?utf-8?B?ME1lUlgwRFVSRXlQdFBIVERQdmFxQ3FlaG1FbkJlTkRvTGRBNGhzQ2J5Kzlq?= =?utf-8?B?ZWU4dTlMeXdTTkYwRVpSQTdibDBDOGRUL3p3eksyMTFSb2dwc1RuV3dhTVIv?= =?utf-8?B?ZE16TFpnd0lHWlpEeEo5NlBZK1FmcCtFZjhTOXJHd2xvR2FpZFQxVWhHSlhS?= =?utf-8?B?UUNNc1NINlM2SGhidDE5WEdFSjJFM2VRc3A4Y3d5N1V3QXAwQ291UlVxRjBO?= =?utf-8?B?cTV0QTFWNkJKMmRHMUU0WmYzbXM3NlBjZy9MS2JWRy9ScHVHSlNDemhiWEI2?= =?utf-8?B?RW9kZGZvZFY5dXM3WGhrV0xDdlZNdk1vRGpzUFp6NVNLd0RkQjBhZFhRcG1q?= =?utf-8?B?Wkt4QklIVm9scTVDdFZjazdGcVNTMlU5aXNkcUk3Y3hvN1Q3aWNKbC9jbXVa?= =?utf-8?B?NDFiQ2dKU3pZQmc2TUVLVjZHQVlmbTNXTGt3ZUxtQjlldUpnbnp6elRTNW1t?= =?utf-8?B?M203NmJ0eHpZOE5rSFIvVVJjT1F4QVJvdmx5OHRLaDVGN0l1SjN5a3liOWtL?= =?utf-8?B?cG82YlRKUW1Jai9QdEtXbURmTjVvSHp4TmRDS0M3NFhKQWQ5L3BJeHVHYjhN?= =?utf-8?B?ODZsK3lKTzhjemxtVlQrMGxQSXV2MENtVkhtYnpSY280MU84UXA2bWNwSktS?= =?utf-8?B?NEcxc0JiWlJieWQxdEthMjRpRGVzN3pzQmRlUFgrRjhRMG9QajRnRlphbzRJ?= =?utf-8?B?SE1RdHJMNTh3VHhtZk9NSmE5NStlNVJOUkpHZmhJdWlxRWtYcXMzRk1WQXhT?= =?utf-8?B?eXcyQ2FHczVBWXU1UUpLVXVnK2FXSkQxdjVuOG1XL3l1NzJTamwvbTIwQ3ZO?= =?utf-8?B?OEJ2RlNGMTRhT3ZrY3QxOXordThxZlFpV3dRZ0k3RmVTaFBQNithTXhYWkVW?= =?utf-8?B?emdmZTFBNmlmbFFOb0taaVZhajN1ME4rNHkwN3RQcmR4a3ZiRlNMaGk4ckhn?= =?utf-8?B?eTI3V011N3AxU05COFZXbUNqNWJ6T0dRUDhacldDZ1lRT0ltSGYrbnRHOWdY?= =?utf-8?B?MWt0UlBzNlQxNlQ0R1RhN1JVVm5LZDROK0hjdk1oQmFyRTRhSVFZS0wrcUFV?= =?utf-8?B?N1g1SWVJRkxtOUlxY084ZFFQanJ4VEw0S0FuMmlWZEVOd28wQmFzYkJPanNE?= =?utf-8?B?a1B6ZHBWY1RhUXAram1nZ3RvTmMvWEZyaDVleWhhc0o0bTNkd2NLaGVwV0o4?= =?utf-8?B?YTBLUmppU3pYNVpkL1dCeG9zMmdkTHdTd21HeHdQeUJHRkNNTm1LakU0cGF4?= =?utf-8?B?bDR4cHRyMSsxTjVxTjJvd0lHUHZWMTFZdTFXM0s3TEpoajRTaHUxSkpQaGQ5?= =?utf-8?B?ZGQxc1FpekRkRnl3UHdjV053My9GVW52NEtIaWh1SUh4MkljcTZVc0tXY3I4?= =?utf-8?B?OU91VDhpaWxrbzVGdlNpZ25IMVdZOW5iNjNZNnZtUjdhTVFnUklXeGFnVkgz?= =?utf-8?B?ZUE9PQ==?= X-OriginatorOrg: weidmueller.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d869f90-a20a-4332-7537-08db2ab2a322 X-MS-Exchange-CrossTenant-AuthSource: PAXPR08MB6969.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2023 08:51:33.4421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uLZtyS6iLM6wMq7bINEyKs/IJV257D8wJkc+lXKVz6ug912Bo+iSAsr4MirgvqgpwUz87m7aY+HUgmVBm+pTTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7683 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Am 21.03.2023 um 16:54 schrieb Tom Rini: > On Tue, Mar 21, 2023 at 04:53:22PM +0100, Stefan Herbrechtsmeier wrote: >> Am 21.03.2023 um 16:35 schrieb Tom Rini: >>> On Tue, Mar 21, 2023 at 08:43:07AM +0100, Stefan Herbrechtsmeier wrote: >>>> Am 20.03.2023 um 18:01 schrieb Tom Rini: >>>>> On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeier wrote: >>>>> >>>>>> From: Stefan Herbrechtsmeier >>>>>> >>>>>> Do not mangle lower or mixed case filenames which fit into the upper >>>>>> case 8.3 short filename. This ensures FAT standard compatible short >>>>>> filenames (SFN) to support systems without long filename (LFN) support >>>>>> like boot roms (ex. SFN BOOT.BIN instead of BOOT~1.BIN for LFN >>>>>> boot.bin). >>>>>> >>>>>> Signed-off-by: Stefan Herbrechtsmeier >>>>>> >>>>>> --- >>>>>> >>>>>> fs/fat/fat_write.c | 11 +++++++---- >>>>>> 1 file changed, 7 insertions(+), 4 deletions(-) >>>>> Can we update test/py/tests/test_fs/ somewhere to have a test for this >>>>> case? Thanks. >>>> What is the recommended approach to test internal behavior? The short name >>>> isn't avialable at the terminal because u-boot support VFAT. >>> Well, you triggered this problem with a filesystem that had contents >>> that were "just so" and then didn't work as expected, yes? >> >> No, I write a file to a file system and the boot rom do not find the file >> because the name was wrong (BOOT~1.BIN instead of BOOT.BIN). >> >> The mdir command shows the short and long file name. I will add a >> test_fat.py with a test. > Ah, ok, and great, thanks! I have send a separate patch `test: fs: Check fat short file name` or should I send a new series with both patches? Regards   Stefan