From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 396A7C47082 for ; Thu, 3 Jun 2021 09:38:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B49F613E4 for ; Thu, 3 Jun 2021 09:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229727AbhFCJkj (ORCPT ); Thu, 3 Jun 2021 05:40:39 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2975 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhFCJki (ORCPT ); Thu, 3 Jun 2021 05:40:38 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FwgkK4zVLz6tlp; Thu, 3 Jun 2021 17:35:53 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 17:38:52 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 17:38:51 +0800 Subject: Re: [PATCH v2 7/7] ARM: mm: Fix PXN process with LPAE feature To: "Russell King (Oracle)" CC: , Catalin Marinas , , Andrew Morton , Jungseung Lee References: <20210602070246.83990-1-wangkefeng.wang@huawei.com> <20210602070246.83990-8-wangkefeng.wang@huawei.com> <20210602105255.GK30436@shell.armlinux.org.uk> <62f08378-85e7-2a07-3fd0-b287047ce1b5@huawei.com> <20210602155843.GN30436@shell.armlinux.org.uk> From: Kefeng Wang Message-ID: Date: Thu, 3 Jun 2021 17:38:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210602155843.GN30436@shell.armlinux.org.uk> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/2 23:58, Russell King (Oracle) wrote: > On Wed, Jun 02, 2021 at 11:13:14PM +0800, Kefeng Wang wrote: >>   IFSR format when using the Short-descriptor translation table format >> >>     Domain fault      01001            First level   01011     Second level >> >>     Permission fault 01101            First level   01111     Second level >> >>   IFSR format when using the Long-descriptor translation table format >> >>    0011LL Permission fault. LL bits indicate levelb. >> >> After check the ARM spec, I think for the permission fault,  we should panic >> with or without LPAE, will change to > As I explained in one of the previous patches, the page tables that get > used for mapping kernel space are the _tasks_ own page tables. Any new > kernel mappings are lazily copied to the task page tables - such as > when a module is loaded. > > The first time we touch a page, we could end up with a page translation > fault. This will call do_page_fault(), and so with your proposal, > loading a module will potentially cause a kernel panic in this case, > probably leading to systems that panic early during userspace boot. Could we add some FSR_FS check， only panic when the permission fault， eg， +static inline bool is_permission_fault(unsigned int fsr) +{ +       int fs = fsr_fs(fsr); +#ifdef CONFIG_ARM_LPAE +       if ((fs & FS_PERM_NOLL_MASK) == FS_PERM_NOLL) +               return true; +#else +       if (fs == FS_L1_PERM || fs == ) +               return true; +#endif +       return false; +} +  static int __kprobes  do_page_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs)  { @@ -255,8 +268,7 @@ do_page_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs)         if (fsr & FSR_LNX_PF) {                 vm_flags = VM_EXEC; - -               if (!user_mode(regs)) +               if (is_permission_fault && !user_mode(regs))                         die_kernel_fault("execution of memory",                                          mm, addr, fsr, regs);         } diff --git a/arch/arm/mm/fault.h b/arch/arm/mm/fault.h index 9ecc2097a87a..187954b4acca 100644 --- a/arch/arm/mm/fault.h +++ b/arch/arm/mm/fault.h @@ -14,6 +14,8 @@  #ifdef CONFIG_ARM_LPAE  #define FSR_FS_AEA             17 +#define FS_PERM_NOLL           0xC +#define FS_PERM_NOLL_MASK      0x3C  static inline int fsr_fs(unsigned int fsr)  { @@ -21,6 +23,8 @@ static inline int fsr_fs(unsigned int fsr)  }  #else  #define FSR_FS_AEA             22 +#define FS_L1_PERM             0xD +#define FS_L2_PERM             0xF and suggestion or proper solution to solve the issue？ > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FBFBC47082 for ; Thu, 3 Jun 2021 09:41:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 599D26100B for ; Thu, 3 Jun 2021 09:41:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 599D26100B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pxsbXSbqhsk7/5C0rhNjcFopAsc8l+WJffrmVC1Ft8A=; b=AxdjineZ9PTZpcDed6MxzsMUWx O9qfGzaCr0+MosonV1ZSI1lkSEi4qvFR5tUBninL9ZcJYSqVaS7PjhwmJ/drjuzWMYS5Ix4KtfqbE svTicf0JpWhc4ETjR86JUMcZ576H+S8tfq/SzWVTSwS415q0TePsVircnLA9TvearzZEWg4qaHhFE 7WUZT3n3qkCVMP7sWRepJ0x9Y8pQl1hmKsRX3evltWa6QtgI9IX1hN8VvSdr7sIMPBRjVGMM2zXCM SZhIuAnLHuCvmu3KSpEx7m6y289AyhbKIQkbfGPFcZbJOCRHlcejUpFexWzFAta2EfnkWWUx4haus OxUPJ5Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lojoc-007t2w-Ud; Thu, 03 Jun 2021 09:39:03 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lojoY-007t2A-AY for linux-arm-kernel@lists.infradead.org; Thu, 03 Jun 2021 09:39:00 +0000 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FwgkK4zVLz6tlp; Thu, 3 Jun 2021 17:35:53 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 17:38:52 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 3 Jun 2021 17:38:51 +0800 Subject: Re: [PATCH v2 7/7] ARM: mm: Fix PXN process with LPAE feature To: "Russell King (Oracle)" CC: , Catalin Marinas , , Andrew Morton , Jungseung Lee References: <20210602070246.83990-1-wangkefeng.wang@huawei.com> <20210602070246.83990-8-wangkefeng.wang@huawei.com> <20210602105255.GK30436@shell.armlinux.org.uk> <62f08378-85e7-2a07-3fd0-b287047ce1b5@huawei.com> <20210602155843.GN30436@shell.armlinux.org.uk> From: Kefeng Wang Message-ID: Date: Thu, 3 Jun 2021 17:38:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210602155843.GN30436@shell.armlinux.org.uk> Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_023858_722878_3E4E335E X-CRM114-Status: GOOD ( 20.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjEvNi8yIDIzOjU4LCBSdXNzZWxsIEtpbmcgKE9yYWNsZSkgd3JvdGU6Cj4gT24gV2Vk LCBKdW4gMDIsIDIwMjEgYXQgMTE6MTM6MTRQTSArMDgwMCwgS2VmZW5nIFdhbmcgd3JvdGU6Cj4+ ICDCoCBJRlNSIGZvcm1hdCB3aGVuIHVzaW5nIHRoZSBTaG9ydC1kZXNjcmlwdG9yIHRyYW5zbGF0 aW9uIHRhYmxlIGZvcm1hdAo+Pgo+PiAgwqDCoMKgIERvbWFpbiBmYXVsdCDCoCDCoMKgIDAxMDAx wqDCoMKgIMKgwqDCoCDCoMKgwqAgRmlyc3QgbGV2ZWzCoMKgIDAxMDExIMKgwqDCoCBTZWNvbmQg bGV2ZWwKPj4KPj4gIMKgwqDCoCBQZXJtaXNzaW9uIGZhdWx0IDAxMTAxIMKgwqAgwqDCoMKgIMKg wqDCoCBGaXJzdCBsZXZlbMKgwqAgMDExMTEgwqDCoMKgIFNlY29uZCBsZXZlbAo+Pgo+PiAgwqAg SUZTUiBmb3JtYXQgd2hlbiB1c2luZyB0aGUgTG9uZy1kZXNjcmlwdG9yIHRyYW5zbGF0aW9uIHRh YmxlIGZvcm1hdAo+Pgo+PiAgwqDCoCAwMDExTEwgUGVybWlzc2lvbiBmYXVsdC4gTEwgYml0cyBp bmRpY2F0ZSBsZXZlbGIuCj4+Cj4+IEFmdGVyIGNoZWNrIHRoZSBBUk0gc3BlYywgSSB0aGluayBm b3IgdGhlIHBlcm1pc3Npb24gZmF1bHQswqAgd2Ugc2hvdWxkIHBhbmljCj4+IHdpdGggb3Igd2l0 aG91dCBMUEFFLCB3aWxsIGNoYW5nZSB0bwo+IEFzIEkgZXhwbGFpbmVkIGluIG9uZSBvZiB0aGUg cHJldmlvdXMgcGF0Y2hlcywgdGhlIHBhZ2UgdGFibGVzIHRoYXQgZ2V0Cj4gdXNlZCBmb3IgbWFw cGluZyBrZXJuZWwgc3BhY2UgYXJlIHRoZSBfdGFza3NfIG93biBwYWdlIHRhYmxlcy4gQW55IG5l dwo+IGtlcm5lbCBtYXBwaW5ncyBhcmUgbGF6aWx5IGNvcGllZCB0byB0aGUgdGFzayBwYWdlIHRh YmxlcyAtIHN1Y2ggYXMKPiB3aGVuIGEgbW9kdWxlIGlzIGxvYWRlZC4KPgo+IFRoZSBmaXJzdCB0 aW1lIHdlIHRvdWNoIGEgcGFnZSwgd2UgY291bGQgZW5kIHVwIHdpdGggYSBwYWdlIHRyYW5zbGF0 aW9uCj4gZmF1bHQuIFRoaXMgd2lsbCBjYWxsIGRvX3BhZ2VfZmF1bHQoKSwgYW5kIHNvIHdpdGgg eW91ciBwcm9wb3NhbCwKPiBsb2FkaW5nIGEgbW9kdWxlIHdpbGwgcG90ZW50aWFsbHkgY2F1c2Ug YSBrZXJuZWwgcGFuaWMgaW4gdGhpcyBjYXNlLAo+IHByb2JhYmx5IGxlYWRpbmcgdG8gc3lzdGVt cyB0aGF0IHBhbmljIGVhcmx5IGR1cmluZyB1c2Vyc3BhY2UgYm9vdC4KCkNvdWxkIHdlIGFkZCBz b21lIEZTUl9GUyBjaGVja++8jCBvbmx5IHBhbmljIHdoZW4gdGhlIHBlcm1pc3Npb24gZmF1bHTv vIwgZWfvvIwKCitzdGF0aWMgaW5saW5lIGJvb2wgaXNfcGVybWlzc2lvbl9mYXVsdCh1bnNpZ25l ZCBpbnQgZnNyKQoreworwqDCoMKgwqDCoMKgIGludCBmcyA9IGZzcl9mcyhmc3IpOworI2lmZGVm IENPTkZJR19BUk1fTFBBRQorwqDCoMKgwqDCoMKgIGlmICgoZnMgJiBGU19QRVJNX05PTExfTUFT SykgPT0gRlNfUEVSTV9OT0xMKQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4g dHJ1ZTsKKyNlbHNlCivCoMKgwqDCoMKgwqAgaWYgKGZzID09IEZTX0wxX1BFUk0gfHwgZnMgPT0g KQorwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCByZXR1cm4gdHJ1ZTsKKyNlbmRpZgorwqDC oMKgwqDCoMKgIHJldHVybiBmYWxzZTsKK30KKwogwqBzdGF0aWMgaW50IF9fa3Byb2JlcwogwqBk b19wYWdlX2ZhdWx0KHVuc2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQgaW50IGZzciwgc3RydWN0 IHB0X3JlZ3MgKnJlZ3MpCiDCoHsKQEAgLTI1NSw4ICsyNjgsNyBAQCBkb19wYWdlX2ZhdWx0KHVu c2lnbmVkIGxvbmcgYWRkciwgdW5zaWduZWQgaW50IGZzciwgCnN0cnVjdCBwdF9yZWdzICpyZWdz KQoKIMKgwqDCoMKgwqDCoMKgIGlmIChmc3IgJiBGU1JfTE5YX1BGKSB7CiDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgdm1fZmxhZ3MgPSBWTV9FWEVDOwotCi3CoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIGlmICghdXNlcl9tb2RlKHJlZ3MpKQorwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBpZiAoaXNfcGVybWlzc2lvbl9mYXVsdCAmJiAhdXNlcl9tb2RlKHJlZ3MpKQogwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkaWVfa2VybmVsX2Zh dWx0KCJleGVjdXRpb24gb2YgbWVtb3J5IiwKIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG1tLCBh ZGRyLCBmc3IsIHJlZ3MpOwogwqDCoMKgwqDCoMKgwqAgfQoKZGlmZiAtLWdpdCBhL2FyY2gvYXJt L21tL2ZhdWx0LmggYi9hcmNoL2FybS9tbS9mYXVsdC5oCmluZGV4IDllY2MyMDk3YTg3YS4uMTg3 OTU0YjRhY2NhIDEwMDY0NAotLS0gYS9hcmNoL2FybS9tbS9mYXVsdC5oCisrKyBiL2FyY2gvYXJt L21tL2ZhdWx0LmgKQEAgLTE0LDYgKzE0LDggQEAKCiDCoCNpZmRlZiBDT05GSUdfQVJNX0xQQUUK IMKgI2RlZmluZSBGU1JfRlNfQUVBwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDE3CisjZGVmaW5l IEZTX1BFUk1fTk9MTMKgwqDCoMKgwqDCoMKgwqDCoMKgIDB4QworI2RlZmluZSBGU19QRVJNX05P TExfTUFTS8KgwqDCoMKgwqAgMHgzQwoKIMKgc3RhdGljIGlubGluZSBpbnQgZnNyX2ZzKHVuc2ln bmVkIGludCBmc3IpCiDCoHsKQEAgLTIxLDYgKzIzLDggQEAgc3RhdGljIGlubGluZSBpbnQgZnNy X2ZzKHVuc2lnbmVkIGludCBmc3IpCiDCoH0KIMKgI2Vsc2UKIMKgI2RlZmluZSBGU1JfRlNfQUVB wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDIyCisjZGVmaW5lIEZTX0wxX1BFUk3CoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgMHhECisjZGVmaW5lIEZTX0wyX1BFUk3CoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgMHhGCgphbmQgc3VnZ2VzdGlvbiBvciBwcm9wZXIgc29sdXRpb24gdG8gc29sdmUgdGhl IGlzc3Vl77yfCgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==