From: Leonard Crestez <cdleonard@gmail.com>
To: David Ahern <dsahern@gmail.com>, David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jakub Kicinski <kuba@kernel.org>, Martin KaFai Lau <kafai@fb.com>,
Kuniyuki Iwashima <kuniyu@amazon.co.jp>,
Yonghong Song <yhs@fb.com>,
Alexander Duyck <alexanderduyck@fb.com>,
Florian Westphal <fw@strlen.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] selftests: nettest: Add --{do,no}-bind-key-ifindex
Date: Fri, 15 Oct 2021 08:58:33 +0300 [thread overview]
Message-ID: <c9c5ce5c-b81e-9dd9-c689-247691fe4249@gmail.com> (raw)
In-Reply-To: <133b490a-29a2-aa40-37bf-aef582f2028f@gmail.com>
On 10/14/21 5:25 PM, David Ahern wrote:
> On 10/13/21 12:50 AM, Leonard Crestez wrote:
>> @@ -1856,10 +1870,14 @@ static void print_usage(char *prog)
>> " -n num number of times to send message\n"
>> "\n"
>> " -M password use MD5 sum protection\n"
>> " -X password MD5 password for client mode\n"
>> " -m prefix/len prefix and length to use for MD5 key\n"
>> + " --no-bind-key-ifindex: Force TCP_MD5SIG_FLAG_IFINDEX off\n"
>> + " --do-bind-key-ifindex: Force TCP_MD5SIG_FLAG_IFINDEX on\n"
>> + " (default: only if -I is passed)\n"
>
> a nit:
> just --bind-key-ifindex and --no-bind-key-ifindex
>
> Reviewed-by: David Ahern <dsahern@kernel.org>
That would be slightly confusing because it would be easy to assume that
the default behavior is "--bind-key-ifindex".
Instead of using "--do-" as an intensifier I can use "--force-".
--
Regards,
Leonard
next prev parent reply other threads:[~2021-10-15 5:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 6:50 [PATCH v2 0/4] tcp: md5: Fix overlap between vrf and non-vrf keys Leonard Crestez
2021-10-13 6:50 ` [PATCH v2 1/4] " Leonard Crestez
2021-10-14 3:05 ` David Ahern
2021-10-13 6:50 ` [PATCH v2 2/4] tcp: md5: Allow MD5SIG_FLAG_IFINDEX with ifindex=0 Leonard Crestez
2021-10-14 3:09 ` David Ahern
2021-10-14 4:43 ` Leonard Crestez
2021-10-14 14:23 ` David Ahern
2021-10-13 6:50 ` [PATCH v2 3/4] selftests: nettest: Add --{do,no}-bind-key-ifindex Leonard Crestez
2021-10-14 14:25 ` David Ahern
2021-10-15 5:58 ` Leonard Crestez [this message]
2021-10-13 6:50 ` [PATCH v2 4/4] selftests: net/fcnal: Test --{do,no}-bind-key-ifindex Leonard Crestez
2021-10-14 14:28 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c5ce5c-b81e-9dd9-c689-247691fe4249@gmail.com \
--to=cdleonard@gmail.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.