From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D4D2C61DA4 for ; Wed, 15 Mar 2023 06:07:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD26185E3B; Wed, 15 Mar 2023 07:07:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="MgoVIjAq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 36CE685E36; Wed, 15 Mar 2023 07:07:06 +0100 (CET) Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D40D85DFC for ; Wed, 15 Mar 2023 07:07:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-jain1@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32F66wv6087124; Wed, 15 Mar 2023 01:06:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678860418; bh=yL5lyctfu3v76HPCZ/1nBorodQlvrGcWV4MEzSIHUtw=; h=Date:From:Subject:To:CC:References:In-Reply-To; b=MgoVIjAqcfyz2oBTsi1p7QaPI2rInsw2Fu4WrklDpLyRwiRJhPaw8cTXHtUhStjK7 o3puQpr+tPmL/8OmVH0Waqx2nGvLgjzsWfVRVo8wyKCPCllBvId7n/9fwqWAVVDcW0 xQCcA0m7xUUrcjByY9dIVQLgdwTTQasjmYuYHGrA= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32F66wjM096290 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Mar 2023 01:06:58 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 15 Mar 2023 01:06:58 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 15 Mar 2023 01:06:58 -0500 Received: from [172.24.145.43] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32F66tBG013771; Wed, 15 Mar 2023 01:06:56 -0500 Message-ID: Date: Wed, 15 Mar 2023 11:36:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Nikhil M Jain Subject: Re: [PATCH 0/9] Enable splash screen To: Simon Glass CC: , , , , , References: <20230313101459.58986-1-n-jain1@ti.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon, On 15/03/23 03:38, Simon Glass wrote: > Hi Nikhil, > > On Mon, 13 Mar 2023 at 04:15, Nikhil M Jain wrote: >> >> To enable splash screen at SPL stage move video driver and splash screen >> framework at SPL, which will bring up image on display very quickly and >> thus have early display support in SPL. >> >> Nikhil M Jain (9): >> drivers: video: Kconfig: Necessary configs for video at SPL >> drivers: video: tidss: Kconfig: Configs to enable TIDSS at SPL >> cmd: Kconfig: Add necessary configs for splash screen at SPL >> drivers: video: Makefile: Compile video driver files at SPL >> drivers: video: tidss: Makefile: Add condition to compile TIDSS at SPL >> cmd: Makefile: Add rules to build bmp.c and read.c at SPL >> common: splash: Enable splash_display at SPL stage >> drivers: video: video-uclass: Disable u-boot logo at SPL >> board: ti: am62x: evm: OSPI support for splash screen >> >> board/ti/am62x/evm.c | 6 ++++++ >> cmd/Kconfig | 17 +++++++++++++++++ >> cmd/Makefile | 2 ++ >> common/splash.c | 2 +- >> drivers/video/Kconfig | 32 ++++++++++++++++++++++++++++---- >> drivers/video/Makefile | 6 ++++++ >> drivers/video/tidss/Kconfig | 6 ++++++ >> drivers/video/tidss/Makefile | 1 + >> drivers/video/video-uclass.c | 2 +- >> include/splash.h | 2 +- >> 10 files changed, 69 insertions(+), 7 deletions(-) > > I'm not necessarily arguing against this, but what is the need for > this? How many milliseconds earlier does the image appear with this > patch? What is the bottleneck? We should be able to get to U-Boot > proper very quickly. > There is a significant difference in time, by adding support in SPL splash screen comes up by approx 650ms and at u-boot proper it comes at 2.6s, measured from first print in console as seen on AM62x. Also we plan to skip u-boot proper and load kernel directly. > Regards, > Simon Regards, Nikhil