From mboxrd@z Thu Jan 1 00:00:00 1970 From: robin.murphy@arm.com (Robin Murphy) Date: Fri, 27 Apr 2018 16:02:53 +0100 Subject: [PATCH 1/2 v4] drm/pl111: Support the Versatile Express In-Reply-To: References: <20180423072017.6690-1-linus.walleij@linaro.org> <4255fd6b-caf7-1347-b97b-ab7b229a08ba@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26/04/18 08:52, Linus Walleij wrote: > On Mon, Apr 23, 2018 at 2:04 PM, Robin Murphy wrote: > >> I've given this a go on the nearest VExpress (with CA15_A7 tile) and sadly >> it doesn't quite work for me :( With the HDLCD driver configure out, the >> PL111 driver seems to repeatedly defer somewhere past >> pl111_versatile_init(): >> >> root at jet-set-radio:~# dmesg | grep -i lcd >> [ 2.739358] drm-clcd-pl111 1c1f0000.clcd: sysreg has not yet probed >> [ 3.406534] drm-clcd-pl111 1c1f0000.clcd: initializing Versatile Express >> PL111 >> [ 3.428218] drm-clcd-pl111 1c1f0000.clcd: DVI muxed to motherboard CLCD >> [ 3.898768] drm-clcd-pl111 1c1f0000.clcd: initializing Versatile Express >> PL111 >> [ 3.920441] drm-clcd-pl111 1c1f0000.clcd: DVI muxed to motherboard CLCD >> [ 10.896158] drm-clcd-pl111 1c1f0000.clcd: initializing Versatile Express >> PL111 >> [ 10.917839] drm-clcd-pl111 1c1f0000.clcd: DVI muxed to motherboard CLCD >> [ 18.513233] drm-clcd-pl111 1c1f0000.clcd: initializing Versatile Express >> PL111 >> [ 18.535007] drm-clcd-pl111 1c1f0000.clcd: DVI muxed to motherboard CLCD >> root at jet-set-radio:~# ls /sys/bus/amba/drivers/drm-clcd-pl111/ >> bind uevent unbind >> >> >> There's no obvious indication of what's missing, but it does still manage to >> do enough to make the external display come on (still showing the >> motherboard PoST screen). By comparison, the old fbdev driver probes OK and >> thinks it's set up a 640x480 console but doesn't actually turn the monitor >> on (and HDLCD doesn't probe at all due to vexpress-v2p-ca15_a7.dts lacking >> any graph endpoint). >> >> Config attached, just in case I'm missing something trivially dumb. > > Hm you definately need CONFIG_CMA and CONFIG_DMA_CMA so > the driver actually uses the special memory. Argh, missing CMA was exactly the kind of idiocy I predicted... > I have all these: > > config-drm: config-base > $(CURDIR)/scripts/config --file $(config_file) \ > --disable FB_ARMCLCD \ > --enable CMA \ > --enable CMA_DEBUG \ > --enable CMA_DEBUGFS \ > --enable DMA_CMA \ > --enable DRM \ > --enable DRM_PL111 \ > --enable FRAMEBUFFER_CONSOLE \ > --enable DRM_PANEL \ > --enable DRM_PANEL_SIMPLE \ > --enable DRM_BRIDGE \ > --enable DRM_PANEL_BRIDGE \ > --enable DRM_SII902X \ > --enable LOGO > > Please try with the stuff above, when I switch the mainline platforms > I plan to update the defconfigs with all the above. ...however even ensuring all of the above options I still see the same behaviour, i.e. the driver fails to bind with no visible reason why. I dug a little bit and it seems pl111_modeset_init() is deferring because it can't find endpoint 0. And given that that's apparently pointing at some non-existent panel rather than the DVI encoder as I would (naively) expect, I can at least form a self-consistent explanation and give up on the grounds that I'm probably missing some important DT changes. Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH 1/2 v4] drm/pl111: Support the Versatile Express Date: Fri, 27 Apr 2018 16:02:53 +0100 Message-ID: References: <20180423072017.6690-1-linus.walleij@linaro.org> <4255fd6b-caf7-1347-b97b-ab7b229a08ba@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by gabe.freedesktop.org (Postfix) with ESMTP id B508F6E921 for ; Fri, 27 Apr 2018 15:02:56 +0000 (UTC) In-Reply-To: Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij Cc: Pawel Moll , Liviu Dudau , "open list:DRM PANEL DRIVERS" , Daniel Vetter , Linux ARM List-Id: dri-devel@lists.freedesktop.org T24gMjYvMDQvMTggMDg6NTIsIExpbnVzIFdhbGxlaWogd3JvdGU6Cj4gT24gTW9uLCBBcHIgMjMs IDIwMTggYXQgMjowNCBQTSwgUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4gd3Jv dGU6Cj4gCj4+IEkndmUgZ2l2ZW4gdGhpcyBhIGdvIG9uIHRoZSBuZWFyZXN0IFZFeHByZXNzICh3 aXRoIENBMTVfQTcgdGlsZSkgYW5kIHNhZGx5Cj4+IGl0IGRvZXNuJ3QgcXVpdGUgd29yayBmb3Ig bWUgOiggV2l0aCB0aGUgSERMQ0QgZHJpdmVyIGNvbmZpZ3VyZSBvdXQsIHRoZQo+PiBQTDExMSBk cml2ZXIgc2VlbXMgdG8gcmVwZWF0ZWRseSBkZWZlciBzb21ld2hlcmUgcGFzdAo+PiBwbDExMV92 ZXJzYXRpbGVfaW5pdCgpOgo+Pgo+PiByb290QGpldC1zZXQtcmFkaW86fiMgZG1lc2cgfCBncmVw IC1pIGxjZAo+PiBbICAgIDIuNzM5MzU4XSBkcm0tY2xjZC1wbDExMSAxYzFmMDAwMC5jbGNkOiBz eXNyZWcgaGFzIG5vdCB5ZXQgcHJvYmVkCj4+IFsgICAgMy40MDY1MzRdIGRybS1jbGNkLXBsMTEx IDFjMWYwMDAwLmNsY2Q6IGluaXRpYWxpemluZyBWZXJzYXRpbGUgRXhwcmVzcwo+PiBQTDExMQo+ PiBbICAgIDMuNDI4MjE4XSBkcm0tY2xjZC1wbDExMSAxYzFmMDAwMC5jbGNkOiBEVkkgbXV4ZWQg dG8gbW90aGVyYm9hcmQgQ0xDRAo+PiBbICAgIDMuODk4NzY4XSBkcm0tY2xjZC1wbDExMSAxYzFm MDAwMC5jbGNkOiBpbml0aWFsaXppbmcgVmVyc2F0aWxlIEV4cHJlc3MKPj4gUEwxMTEKPj4gWyAg ICAzLjkyMDQ0MV0gZHJtLWNsY2QtcGwxMTEgMWMxZjAwMDAuY2xjZDogRFZJIG11eGVkIHRvIG1v dGhlcmJvYXJkIENMQ0QKPj4gWyAgIDEwLjg5NjE1OF0gZHJtLWNsY2QtcGwxMTEgMWMxZjAwMDAu Y2xjZDogaW5pdGlhbGl6aW5nIFZlcnNhdGlsZSBFeHByZXNzCj4+IFBMMTExCj4+IFsgICAxMC45 MTc4MzldIGRybS1jbGNkLXBsMTExIDFjMWYwMDAwLmNsY2Q6IERWSSBtdXhlZCB0byBtb3RoZXJi b2FyZCBDTENECj4+IFsgICAxOC41MTMyMzNdIGRybS1jbGNkLXBsMTExIDFjMWYwMDAwLmNsY2Q6 IGluaXRpYWxpemluZyBWZXJzYXRpbGUgRXhwcmVzcwo+PiBQTDExMQo+PiBbICAgMTguNTM1MDA3 XSBkcm0tY2xjZC1wbDExMSAxYzFmMDAwMC5jbGNkOiBEVkkgbXV4ZWQgdG8gbW90aGVyYm9hcmQg Q0xDRAo+PiByb290QGpldC1zZXQtcmFkaW86fiMgbHMgL3N5cy9idXMvYW1iYS9kcml2ZXJzL2Ry bS1jbGNkLXBsMTExLwo+PiBiaW5kICB1ZXZlbnQgIHVuYmluZAo+Pgo+Pgo+PiBUaGVyZSdzIG5v IG9idmlvdXMgaW5kaWNhdGlvbiBvZiB3aGF0J3MgbWlzc2luZywgYnV0IGl0IGRvZXMgc3RpbGwg bWFuYWdlIHRvCj4+IGRvIGVub3VnaCB0byBtYWtlIHRoZSBleHRlcm5hbCBkaXNwbGF5IGNvbWUg b24gKHN0aWxsIHNob3dpbmcgdGhlCj4+IG1vdGhlcmJvYXJkIFBvU1Qgc2NyZWVuKS4gQnkgY29t cGFyaXNvbiwgdGhlIG9sZCBmYmRldiBkcml2ZXIgcHJvYmVzIE9LIGFuZAo+PiB0aGlua3MgaXQn cyBzZXQgdXAgYSA2NDB4NDgwIGNvbnNvbGUgYnV0IGRvZXNuJ3QgYWN0dWFsbHkgdHVybiB0aGUg bW9uaXRvcgo+PiBvbiAoYW5kIEhETENEIGRvZXNuJ3QgcHJvYmUgYXQgYWxsIGR1ZSB0byB2ZXhw cmVzcy12MnAtY2ExNV9hNy5kdHMgbGFja2luZwo+PiBhbnkgZ3JhcGggZW5kcG9pbnQpLgo+Pgo+ PiBDb25maWcgYXR0YWNoZWQsIGp1c3QgaW4gY2FzZSBJJ20gbWlzc2luZyBzb21ldGhpbmcgdHJp dmlhbGx5IGR1bWIuCj4gCj4gSG0geW91IGRlZmluYXRlbHkgbmVlZCBDT05GSUdfQ01BIGFuZCBD T05GSUdfRE1BX0NNQSBzbwo+IHRoZSBkcml2ZXIgYWN0dWFsbHkgdXNlcyB0aGUgc3BlY2lhbCBt ZW1vcnkuCgpBcmdoLCBtaXNzaW5nIENNQSB3YXMgZXhhY3RseSB0aGUga2luZCBvZiBpZGlvY3kg SSBwcmVkaWN0ZWQuLi4KCj4gSSBoYXZlIGFsbCB0aGVzZToKPiAKPiBjb25maWctZHJtOiBjb25m aWctYmFzZQo+ICAgICAgICAgICQoQ1VSRElSKS9zY3JpcHRzL2NvbmZpZyAtLWZpbGUgJChjb25m aWdfZmlsZSkgXAo+ICAgICAgICAgIC0tZGlzYWJsZSBGQl9BUk1DTENEIFwKPiAgICAgICAgICAt LWVuYWJsZSBDTUEgXAo+ICAgICAgICAgIC0tZW5hYmxlIENNQV9ERUJVRyBcCj4gICAgICAgICAg LS1lbmFibGUgQ01BX0RFQlVHRlMgXAo+ICAgICAgICAgIC0tZW5hYmxlIERNQV9DTUEgXAo+ICAg ICAgICAgIC0tZW5hYmxlIERSTSBcCj4gICAgICAgICAgLS1lbmFibGUgRFJNX1BMMTExIFwKPiAg ICAgICAgICAtLWVuYWJsZSBGUkFNRUJVRkZFUl9DT05TT0xFIFwKPiAgICAgICAgICAtLWVuYWJs ZSBEUk1fUEFORUwgXAo+ICAgICAgICAgIC0tZW5hYmxlIERSTV9QQU5FTF9TSU1QTEUgXAo+ICAg ICAgICAgIC0tZW5hYmxlIERSTV9CUklER0UgXAo+ICAgICAgICAgIC0tZW5hYmxlIERSTV9QQU5F TF9CUklER0UgXAo+ICAgICAgICAgIC0tZW5hYmxlIERSTV9TSUk5MDJYIFwKPiAgICAgICAgICAt LWVuYWJsZSBMT0dPCj4gCj4gUGxlYXNlIHRyeSB3aXRoIHRoZSBzdHVmZiBhYm92ZSwgd2hlbiBJ IHN3aXRjaCB0aGUgbWFpbmxpbmUgcGxhdGZvcm1zCj4gSSBwbGFuIHRvIHVwZGF0ZSB0aGUgZGVm Y29uZmlncyB3aXRoIGFsbCB0aGUgYWJvdmUuCgouLi5ob3dldmVyIGV2ZW4gZW5zdXJpbmcgYWxs IG9mIHRoZSBhYm92ZSBvcHRpb25zIEkgc3RpbGwgc2VlIHRoZSBzYW1lIApiZWhhdmlvdXIsIGku ZS4gdGhlIGRyaXZlciBmYWlscyB0byBiaW5kIHdpdGggbm8gdmlzaWJsZSByZWFzb24gd2h5LgoK SSBkdWcgYSBsaXR0bGUgYml0IGFuZCBpdCBzZWVtcyBwbDExMV9tb2Rlc2V0X2luaXQoKSBpcyBk ZWZlcnJpbmcgCmJlY2F1c2UgaXQgY2FuJ3QgZmluZCBlbmRwb2ludCAwLiBBbmQgZ2l2ZW4gdGhh dCB0aGF0J3MgYXBwYXJlbnRseSAKcG9pbnRpbmcgYXQgc29tZSBub24tZXhpc3RlbnQgcGFuZWwg cmF0aGVyIHRoYW4gdGhlIERWSSBlbmNvZGVyIGFzIEkgCndvdWxkIChuYWl2ZWx5KSBleHBlY3Qs IEkgY2FuIGF0IGxlYXN0IGZvcm0gYSBzZWxmLWNvbnNpc3RlbnQgCmV4cGxhbmF0aW9uIGFuZCBn aXZlIHVwIG9uIHRoZSBncm91bmRzIHRoYXQgSSdtIHByb2JhYmx5IG1pc3Npbmcgc29tZSAKaW1w b3J0YW50IERUIGNoYW5nZXMuCgpSb2Jpbi4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==