From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A87CCA483 for ; Wed, 22 Jun 2022 15:09:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359047AbiFVPJB (ORCPT ); Wed, 22 Jun 2022 11:09:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359164AbiFVPIl (ORCPT ); Wed, 22 Jun 2022 11:08:41 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E701C2DA89 for ; Wed, 22 Jun 2022 08:08:36 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id u15so7238673ejc.10 for ; Wed, 22 Jun 2022 08:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=GbOJQbCPXXFQWcBB2NA2p6q5ubRmVUJFNDbSoq8WWes=; b=QpzQ8IqF4+E6u9y6gcaykwSNvt+WZSEw6Qm8CfS5bdebU8w50WYSD+LhSNsFo7IqYI wc6naJWlvFAenLoP/BlvW5dhD6KEHEwxGVTL4aovxDOwzHZUJQPPGVXy61e4C/XKkKdU Kj0LOS5tZAHOLgOhXpIi1ia4LgBZasqViFzA7H8j/KGZTq5ySkG+Z2SQflqKiPvI1vvB DDro1YRWeEmG4AqXPWBvXtuAMDjaYfsjKbLpJ0Hbw1ha9rnwOkbmkawRS8jnTw4cuSu/ bbDs3dgNQx3IF+4QSKhdWaTGBcB2dmNpAyALq5zGTwlQ6iWqCnqw1CTkUz2ogTEKq9/o InKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=GbOJQbCPXXFQWcBB2NA2p6q5ubRmVUJFNDbSoq8WWes=; b=6o9/9VDtPjcoyOpv21RsCTIBM+MJxyoppRUi8XMqrKbqN2dkhHPt0FHhYVHGED3R0b zo0C8Km0OZbytPjcAhYv16TOj9abUm2WNHS7XXDP0H95RAKkG/k1WZFNVxPswnVJqmL1 uUpTCE59X+hmSrn+4g7uHE/m6y/clzoZpMhe5qMxbFFipBTquneGzy4HAS44JGKF24DW B2P7+lCuMJDVHw9YtHQKo6Q70vN/ObodMF7kGoI7vD3yticOwVEOTe9ax8LbdJE8sjNV IpwNYeuvzAgcvHhr4qxs/hiH42xdBzAD95blQ7P3+L27LRiQBWCahzMr2wpPUL+mcvUL MR+A== X-Gm-Message-State: AJIora/Y6jyfpRafmNzs+tse51y4Fco7gXO2ztdysMPPtbzZkZ1emtMv Yfef/+JrUscSTep/4Q0DYrs5zg== X-Google-Smtp-Source: AGRyM1uQtjqkSd7z3x0Z+zwX6gwY0VPrtqmnMZ43RgvyIsvA51gBRnK4Lr4IJG+qwTZA2wb7ORRFQQ== X-Received: by 2002:a17:906:5d0b:b0:722:ebcc:b10c with SMTP id g11-20020a1709065d0b00b00722ebccb10cmr3488593ejt.175.1655910515407; Wed, 22 Jun 2022 08:08:35 -0700 (PDT) Received: from [192.168.0.226] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id t24-20020a056402021800b004356a647d08sm11299011edv.94.2022.06.22.08.08.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 08:08:35 -0700 (PDT) Message-ID: Date: Wed, 22 Jun 2022 17:08:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH V2 3/8] clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018 Content-Language: en-US To: Sricharan R , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, p.zabel@pengutronix.de, quic_varada@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220621161126.15883-1-quic_srichara@quicinc.com> <20220621161126.15883-4-quic_srichara@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20220621161126.15883-4-quic_srichara@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21/06/2022 18:11, Sricharan R wrote: > From: Varadarajan Narayanan > > Add support for the global clock controller found on IPQ5018 > based devices. > > Co-developed-by: Sricharan R > Signed-off-by: Sricharan R > Signed-off-by: Varadarajan Narayanan Thank you for your patch. There is something to discuss/improve. > --- > drivers/clk/qcom/Kconfig | 7 + > drivers/clk/qcom/Makefile | 1 + > drivers/clk/qcom/gcc-ipq5018.c | 3995 ++++++++++++++++++++++++++++++++ > 3 files changed, 4003 insertions(+) > create mode 100644 drivers/clk/qcom/gcc-ipq5018.c > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index d01436be6d7a..294fb975db85 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -172,6 +172,13 @@ config IPQ_GCC_8074 > i2c, USB, SD/eMMC, etc. Select this for the root clock > of ipq8074. > > +config IPQ_GCC_5018 > + tristate "IPQ5018 Global Clock Controller" > + help > + Support for global clock controller on ipq5018 devices. > + Say Y if you want to use peripheral devices such as UART, SPI, > + i2c, USB, SD/eMMC, etc. > + > config MSM_GCC_8660 > tristate "MSM8660 Global Clock Controller" > help > diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile > index 671cf5821af1..33ab4ce9b863 100644 > --- a/drivers/clk/qcom/Makefile > +++ b/drivers/clk/qcom/Makefile > @@ -26,6 +26,7 @@ obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o > obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o > obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o > obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o > +obj-$(CONFIG_IPQ_GCC_5018) += gcc-ipq5018.o > obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o > obj-$(CONFIG_MDM_GCC_9607) += gcc-mdm9607.o > obj-$(CONFIG_MDM_GCC_9615) += gcc-mdm9615.o (...) > + > +static int gcc_ipq5018_probe(struct platform_device *pdev) > +{ > + int ret; > + struct regmap *regmap; > + struct qcom_cc_desc ipq5018_desc = gcc_ipq5018_desc; > + > + regmap = qcom_cc_map(pdev, &ipq5018_desc); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + clk_alpha_pll_configure(&ubi32_pll_main, regmap, &ubi32_pll_config); > + > + ret = qcom_cc_really_probe(pdev, &ipq5018_desc, regmap); return qcom_cc_really_probe(....) > + if (ret) { > + dev_err(&pdev->dev, "Failed to register ipq5018 GCC clocks\n"); > + return ret; > + } > + > + dev_info(&pdev->dev, "Registered ipq5018 GCC clocks provider"); No probe success messages. This pollutes the log and there is other infrastructure to check for successful probe. > + > + return ret; > +} > + > +static struct platform_driver gcc_ipq5018_driver = { > + .probe = gcc_ipq5018_probe, > + .driver = { > + .name = "qcom,gcc-ipq5018", > + .owner = THIS_MODULE, No need for owner. > + .of_match_table = gcc_ipq5018_match_table, > + }, > +}; > + > +static int __init gcc_ipq5018_init(void) > +{ > + return platform_driver_register(&gcc_ipq5018_driver); > +} > +core_initcall(gcc_ipq5018_init); > + > +static void __exit gcc_ipq5018_exit(void) > +{ > + platform_driver_unregister(&gcc_ipq5018_driver); > +} > +module_exit(gcc_ipq5018_exit); > + > +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ5018 Driver"); > +MODULE_LICENSE("GPL v2"); Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A89DC43334 for ; Wed, 22 Jun 2022 15:09:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a5csnug8i4e6hpXVJuPFC2sHgpCnQe7no7CGwfmgNo4=; b=FWahKewdbJ3q0V CZqO6u7ZiNhObj9h6CEdi5rCsI7/MU9oRZqR1jFvwobvAVCSMSk9XGKTyeiPOvy1tsAIsJIWdvdRT Y5Jx8H1xiqhc0eIepbTrT8xA+hW8jQM1DIctgmz+7aMhv6bGhZ+W5gKBF7elggIPVW599KHicFoN8 b+OE3Y8Te5ePrEqGYf8YSMReByWxWbIpj/4l05yeAsykHuFEXMQZIPq1BUPrMs+v+eYJqz7FUbjv0 QVREQg70peQLmSJPSXxJws/XjQSvtg17ESPPGgG2ezOJbHqjb7K5+a+yZSSXyVZ7kLaIup3ohlgra s2ugFbM4MeJjkHRPmGWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o41yD-00B7ey-90; Wed, 22 Jun 2022 15:08:41 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o41y9-00B7dH-4W for linux-arm-kernel@lists.infradead.org; Wed, 22 Jun 2022 15:08:39 +0000 Received: by mail-ej1-x633.google.com with SMTP id cw10so11168114ejb.3 for ; Wed, 22 Jun 2022 08:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=GbOJQbCPXXFQWcBB2NA2p6q5ubRmVUJFNDbSoq8WWes=; b=QpzQ8IqF4+E6u9y6gcaykwSNvt+WZSEw6Qm8CfS5bdebU8w50WYSD+LhSNsFo7IqYI wc6naJWlvFAenLoP/BlvW5dhD6KEHEwxGVTL4aovxDOwzHZUJQPPGVXy61e4C/XKkKdU Kj0LOS5tZAHOLgOhXpIi1ia4LgBZasqViFzA7H8j/KGZTq5ySkG+Z2SQflqKiPvI1vvB DDro1YRWeEmG4AqXPWBvXtuAMDjaYfsjKbLpJ0Hbw1ha9rnwOkbmkawRS8jnTw4cuSu/ bbDs3dgNQx3IF+4QSKhdWaTGBcB2dmNpAyALq5zGTwlQ6iWqCnqw1CTkUz2ogTEKq9/o InKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=GbOJQbCPXXFQWcBB2NA2p6q5ubRmVUJFNDbSoq8WWes=; b=moE15Q6Apyy1XNbpHPzgC+6zfjg7u4Q8NTd8x1flpJOCMrIpV84+ifIxICkRUCCjXj 0bMrALqyV14yoLlh6QDNtqaVpWZnYzS/a8dsFSzs7HTBntYfOJgKIcvXDoT7UXxpxS55 yLT8d9/lGKLRnabvhNLeoi1T6GtyuN21WX5IfMAbvI9CaRGwEK1VVJjppL7hkl5TYzzt 1Kkw66NMa//DTCJJIcMB1+ww5TfkQCnOiNR6Pzy5KSTGJCF3sB+MiEcSfXf6EkjT34MR tkaNjMqbCFMvHEqQHrdkFQrnpZPISFOc9qKiy8HR+RCMMfTVAmcM00pT9yeD2i+6Er1J S5ig== X-Gm-Message-State: AJIora/5I0H9VkW/O8g9XLpTWTJVijb0RcFp0FbgswlXBYbO4KrDfINd RyHqXdA+lN0TjjwApnpDmpUfpg== X-Google-Smtp-Source: AGRyM1uQtjqkSd7z3x0Z+zwX6gwY0VPrtqmnMZ43RgvyIsvA51gBRnK4Lr4IJG+qwTZA2wb7ORRFQQ== X-Received: by 2002:a17:906:5d0b:b0:722:ebcc:b10c with SMTP id g11-20020a1709065d0b00b00722ebccb10cmr3488593ejt.175.1655910515407; Wed, 22 Jun 2022 08:08:35 -0700 (PDT) Received: from [192.168.0.226] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id t24-20020a056402021800b004356a647d08sm11299011edv.94.2022.06.22.08.08.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 08:08:35 -0700 (PDT) Message-ID: Date: Wed, 22 Jun 2022 17:08:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH V2 3/8] clk: qcom: Add Global Clock controller (GCC) driver for IPQ5018 Content-Language: en-US To: Sricharan R , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, linus.walleij@linaro.org, catalin.marinas@arm.com, p.zabel@pengutronix.de, quic_varada@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220621161126.15883-1-quic_srichara@quicinc.com> <20220621161126.15883-4-quic_srichara@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20220621161126.15883-4-quic_srichara@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220622_080837_224560_72EC09C2 X-CRM114-Status: GOOD ( 24.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/06/2022 18:11, Sricharan R wrote: > From: Varadarajan Narayanan > > Add support for the global clock controller found on IPQ5018 > based devices. > > Co-developed-by: Sricharan R > Signed-off-by: Sricharan R > Signed-off-by: Varadarajan Narayanan Thank you for your patch. There is something to discuss/improve. > --- > drivers/clk/qcom/Kconfig | 7 + > drivers/clk/qcom/Makefile | 1 + > drivers/clk/qcom/gcc-ipq5018.c | 3995 ++++++++++++++++++++++++++++++++ > 3 files changed, 4003 insertions(+) > create mode 100644 drivers/clk/qcom/gcc-ipq5018.c > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index d01436be6d7a..294fb975db85 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -172,6 +172,13 @@ config IPQ_GCC_8074 > i2c, USB, SD/eMMC, etc. Select this for the root clock > of ipq8074. > > +config IPQ_GCC_5018 > + tristate "IPQ5018 Global Clock Controller" > + help > + Support for global clock controller on ipq5018 devices. > + Say Y if you want to use peripheral devices such as UART, SPI, > + i2c, USB, SD/eMMC, etc. > + > config MSM_GCC_8660 > tristate "MSM8660 Global Clock Controller" > help > diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile > index 671cf5821af1..33ab4ce9b863 100644 > --- a/drivers/clk/qcom/Makefile > +++ b/drivers/clk/qcom/Makefile > @@ -26,6 +26,7 @@ obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o > obj-$(CONFIG_IPQ_GCC_6018) += gcc-ipq6018.o > obj-$(CONFIG_IPQ_GCC_806X) += gcc-ipq806x.o > obj-$(CONFIG_IPQ_GCC_8074) += gcc-ipq8074.o > +obj-$(CONFIG_IPQ_GCC_5018) += gcc-ipq5018.o > obj-$(CONFIG_IPQ_LCC_806X) += lcc-ipq806x.o > obj-$(CONFIG_MDM_GCC_9607) += gcc-mdm9607.o > obj-$(CONFIG_MDM_GCC_9615) += gcc-mdm9615.o (...) > + > +static int gcc_ipq5018_probe(struct platform_device *pdev) > +{ > + int ret; > + struct regmap *regmap; > + struct qcom_cc_desc ipq5018_desc = gcc_ipq5018_desc; > + > + regmap = qcom_cc_map(pdev, &ipq5018_desc); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + clk_alpha_pll_configure(&ubi32_pll_main, regmap, &ubi32_pll_config); > + > + ret = qcom_cc_really_probe(pdev, &ipq5018_desc, regmap); return qcom_cc_really_probe(....) > + if (ret) { > + dev_err(&pdev->dev, "Failed to register ipq5018 GCC clocks\n"); > + return ret; > + } > + > + dev_info(&pdev->dev, "Registered ipq5018 GCC clocks provider"); No probe success messages. This pollutes the log and there is other infrastructure to check for successful probe. > + > + return ret; > +} > + > +static struct platform_driver gcc_ipq5018_driver = { > + .probe = gcc_ipq5018_probe, > + .driver = { > + .name = "qcom,gcc-ipq5018", > + .owner = THIS_MODULE, No need for owner. > + .of_match_table = gcc_ipq5018_match_table, > + }, > +}; > + > +static int __init gcc_ipq5018_init(void) > +{ > + return platform_driver_register(&gcc_ipq5018_driver); > +} > +core_initcall(gcc_ipq5018_init); > + > +static void __exit gcc_ipq5018_exit(void) > +{ > + platform_driver_unregister(&gcc_ipq5018_driver); > +} > +module_exit(gcc_ipq5018_exit); > + > +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ5018 Driver"); > +MODULE_LICENSE("GPL v2"); Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel