From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH v2 01/28] drm: omapdrm: Remove duplicate error messages when mapping memory Date: Tue, 9 May 2017 11:37:30 +0300 Message-ID: References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-2-laurent.pinchart@ideasonboard.com> <3308745.hn17PlIDME@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2057932480==" Return-path: Received: from fllnx209.ext.ti.com (fllnx209.ext.ti.com [198.47.19.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id 337EA88E88 for ; Tue, 9 May 2017 08:38:00 +0000 (UTC) In-Reply-To: <3308745.hn17PlIDME@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============2057932480== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UmNWkHxC32KgBk0TdnTeoSjIg5urb3CjQ" --UmNWkHxC32KgBk0TdnTeoSjIg5urb3CjQ Content-Type: multipart/mixed; boundary="Ic4siUAQ2I7GWlDcLo0nbCBknCtEWMh2l"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH v2 01/28] drm: omapdrm: Remove duplicate error messages when mapping memory References: <20170508113303.27521-1-laurent.pinchart@ideasonboard.com> <20170508113303.27521-2-laurent.pinchart@ideasonboard.com> <3308745.hn17PlIDME@avalon> In-Reply-To: <3308745.hn17PlIDME@avalon> --Ic4siUAQ2I7GWlDcLo0nbCBknCtEWMh2l Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/05/17 16:55, Laurent Pinchart wrote: > Hi Tomi, >=20 > On Monday 08 May 2017 15:52:07 Tomi Valkeinen wrote: >> On 08/05/17 14:32, Laurent Pinchart wrote: >>> The devm_ioremap_resource() call can handle being given a NULL resour= ce, >>> and prints an error message when mapping fails. Switch the remaining >>> devm_ioremap() calls to devm_ioremap_resource() and remove all >>> extraneous resource NULL checks and error messages printed manually b= y >>> the driver. >> >> Looks like in some places we check for "!ret" and in some "IS_ERR(ret)= "... >=20 > Oops :-/ >=20 > From 94d2a8f445cd298d99ffc4717d2184dcf21e8889 Mon Sep 17 00:00:00 2001 > From: Laurent Pinchart > Date: Sun, 7 May 2017 00:29:09 +0300 > Subject: [PATCH v2.1 01/28] drm: omapdrm: Remove duplicate error messag= es when mapping memory >=20 > The devm_ioremap_resource() call can handle being given a NULL resource= , > and prints an error message when mapping fails. Switch the remaining > devm_ioremap() calls to devm_ioremap_resource() and remove all > extraneous resource NULL checks and error messages printed manually by > the driver. >=20 > Signed-off-by: Laurent Pinchart > --- > Changes since v2: >=20 > - Fix devm_ioremap_resource() return value checks Reviewed-by: Tomi Valkeinen Tomi --Ic4siUAQ2I7GWlDcLo0nbCBknCtEWMh2l-- --UmNWkHxC32KgBk0TdnTeoSjIg5urb3CjQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZEX/KAAoJEPo9qoy8lh71uOsQAKZqrSUIVlwy7i+B3RP/Ul7o 6cWIu94OXOmT+0g5MBtH7A9MzFxypuYWJXGa2X2r/uYPwZFlgsiq59cfRBHzvOYl FE5h58sw7HwFKBuXpLa2392y4iuam10fUZ2qPeqyyvm4sFpU/YNoDQXlAxEP6Vwv Q/QdMxWpkNcTjs1iZVorPD0e9MR5tD1l4Lmnk7Q0Z6Y6VMFMVMfOp90n1Y4ILObD 4ddM8d/8CPLUeiyXdZnMv2WCjqHU8WSXGuuaU5LA8BwpdABXsMMctYNwbeoOBYRn jwHAlujosNPAVF2z4NWYre0QnDIUNUCYOSpQJJ/HLOXxHTSIWo3Ns5xE+FdDecow IJ+wv320pyxTNXMFCdd8r05N99ThfQJmwKiGWk9csTLdrPYtlWu2ZhgKHTexz9U9 sKWseojpLAuRsb/jMKtS7KHailRXKGBdKJBXlF23SQmiK23hEQ9Elc90zqeTr87F cjejmdC/vrZHqUX7loUxJAVPl+SQXhLPhFvlL9gyrJIDrUItSDOfAjCia/kRuaFh kBuq19J/jjhWpkMoz2cf5dHLfyH4VwwNT7ilNggRM8OP39kGudsncnfw/OR9Qtbe o5tRI9FOFKFB7lnhI0AvGiIqGHRy/+wcip+FwguN2SKgsipi1rT43+gOmYGDCTqE jn6c0Fd8lbsHvGuumvoF =u+5Z -----END PGP SIGNATURE----- --UmNWkHxC32KgBk0TdnTeoSjIg5urb3CjQ-- --===============2057932480== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2057932480==--