All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kahola, Mika" <mika.kahola@intel.com>
To: "Khajapasha, Mohammed" <mohammed.khajapasha@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Heikkila, Juha-pekka" <juha-pekka.heikkila@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tests/kms_cursor_crc: Add vblank wait for restore image
Date: Mon, 15 Mar 2021 13:27:20 +0000	[thread overview]
Message-ID: <c9fff9b4d3ff43738fdecd5efb7f3081@intel.com> (raw)
In-Reply-To: <20210315103547.17115-2-mohammed.khajapasha@intel.com>

> -----Original Message-----
> From: Khajapasha, Mohammed <mohammed.khajapasha@intel.com>
> Sent: Monday, March 15, 2021 12:36 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Kahola, Mika <mika.kahola@intel.com>; Heikkila, Juha-pekka <juha-
> pekka.heikkila@intel.com>
> Subject: [PATCH i-g-t 1/1] tests/kms_cursor_crc: Add vblank wait for restore
> image
> 
> Add igt_wait_for_vblank() once restore image is done and frontbuffer mark
> as dirty.
> 
> Cc: Juha-Pekka Heikkila <juha-pekka.heikkila@intel.com>
> Cc: Kahola, Mika <mika.kahola@intel.com>
> Signed-off-by: Mohammed Khajapasha
> <mohammed.khajapasha@intel.com>

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> ---
>  tests/kms_cursor_crc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c index
> 0be8f7f8..3541ea06 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -147,6 +147,7 @@ static bool cursor_visible(data_t *data, int x, int y)
> static void restore_image(data_t *data)  {
>  	cairo_t *cr;
> +	igt_display_t *display = &data->display;
> 
>  	/* rendercopy stripped in igt using cairo */
>  	cr = igt_get_cairo_ctx(data->drm_fd,
> @@ -157,6 +158,8 @@ static void restore_image(data_t *data)
>  	cairo_fill(cr);
>  	igt_put_cairo_ctx(cr);
>  	igt_dirty_fb(data->drm_fd, &data->primary_fb[FRONTBUFFER]);
> +	igt_wait_for_vblank(data->drm_fd,
> +			    display->pipes[data->pipe].crtc_offset);
>  }
> 
>  static void do_single_test(data_t *data, int x, int y)
> --
> 2.29.2.154.g7f7ebe054a

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-03-15 13:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 10:35 [igt-dev] [PATCH i-g-t 0/1] tests/kms_cursor_crc: Add vblank wait for restore Mohammed Khajapasha
2021-03-15 10:35 ` [igt-dev] [PATCH i-g-t 1/1] tests/kms_cursor_crc: Add vblank wait for restore image Mohammed Khajapasha
2021-03-15 13:27   ` Kahola, Mika [this message]
2021-03-15 11:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_crc: Add vblank wait for restore Patchwork
2021-03-15 12:50 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-16 11:04 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_crc: Add vblank wait for restore (rev2) Patchwork
2021-03-16 12:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9fff9b4d3ff43738fdecd5efb7f3081@intel.com \
    --to=mika.kahola@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    --cc=mohammed.khajapasha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.