Re: [PATCH] drm/amdgpu: check for allocation failure in amdgpu_vkms_sw_init()

From: "Christian König" <christian.koenig@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	Ryan Taylor <Ryan.Taylor@amd.com>
Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: check for allocation failure in amdgpu_vkms_sw_init()
Date: Fri, 6 Aug 2021 17:09:05 +0200	[thread overview]
Message-ID: <ca0cfa01-e1ef-1ee8-8adc-ebd4fa253e70@amd.com> (raw)
In-Reply-To: <20210806150518.GC15586@kili>

Am 06.08.21 um 17:05 schrieb Dan Carpenter:
> Check whether the kcalloc() fails and return -ENOMEM if it does.
>
> Fixes: eeba0b9046fc ("drm/amdgpu: create amdgpu_vkms (v4)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
> index 50bdc39733aa..ce982afeff91 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
> @@ -482,6 +482,8 @@ static int amdgpu_vkms_sw_init(void *handle)
>   		return r;
>   
>   	adev->amdgpu_vkms_output = kcalloc(adev->mode_info.num_crtc, sizeof(struct amdgpu_vkms_output), GFP_KERNEL);

Is the line above not a bit long?

> +	if (!adev->amdgpu_vkms_output)
> +		return -ENOMEM;
>   
>   	/* allocate crtcs, encoders, connectors */
>   	for (i = 0; i < adev->mode_info.num_crtc; i++) {