From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Ldqrp-0005vK-C6 for mharc-grub-devel@gnu.org; Sun, 01 Mar 2009 13:58:25 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ldqrm-0005sP-Jc for grub-devel@gnu.org; Sun, 01 Mar 2009 13:58:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ldqrk-0005qT-R7 for grub-devel@gnu.org; Sun, 01 Mar 2009 13:58:22 -0500 Received: from [199.232.76.173] (port=32805 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ldqrk-0005qJ-Lj for grub-devel@gnu.org; Sun, 01 Mar 2009 13:58:20 -0500 Received: from ti-out-0910.google.com ([209.85.142.190]:57207) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ldqrj-0005Cx-Sp for grub-devel@gnu.org; Sun, 01 Mar 2009 13:58:20 -0500 Received: by ti-out-0910.google.com with SMTP id j3so2496079tid.10 for ; Sun, 01 Mar 2009 10:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=JSpqiw8i7fQuKJhRG+iEgPrvuTcJWN3QKVlcNHT0XWw=; b=X6V6HLSBCp1NYtUfG5jyyJVq4N9lXHh8/IVgGs29AQq5TO4b3pH6PhZjwo27tYb+/1 OoG3fTe59eFNdPYMpkkuzom3PMaMR5btHHmtpXDkvYQeIdvk5biBGXu3VBQPvgOnLws5 gZwKO/eVAdCqth+osfZSjaHM9t5WJaF8iI94c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=goZ8MfofacJ08pYolSPhR83OVrjXLB7Rzw9GbcH6YBCMjNx7ySDgOVBe5ndG5IEEDS 7MclGpIIWCUbEe4Uyb2BOBlQQZaM6eC7KwSsG61fyePrXQEHX5DAXEsnbqVQ182LhkCm Ot3ixsnkLA51LVtavWqPfpEvsksfNbLgjafXs= MIME-Version: 1.0 Received: by 10.110.11.4 with SMTP id 4mr6230162tik.47.1235933897537; Sun, 01 Mar 2009 10:58:17 -0800 (PST) In-Reply-To: <499318E3.5040801@gmail.com> References: <4992D603.9030105@gmail.com> <1234369601.25774.5.camel@mj> <499318E3.5040801@gmail.com> Date: Mon, 2 Mar 2009 02:58:17 +0800 Message-ID: From: Bean To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] make partition active X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2009 18:58:23 -0000 On Thu, Feb 12, 2009 at 2:28 AM, phcoder wrote: > Pavel Roskin wrote: >> >> On Wed, 2009-02-11 at 14:43 +0100, phcoder wrote: >>> >>> Here's the patch to add a replacement for old "makeactive" command >>> New syntax is >>> activate PARTITION >>> E.g. >>> activate hd0,1 >> >> Is it necessary to change the name? =A0I think "makeactive" is a better >> name for what it does. > > Actually I don't really care but on http://grub.enbug.org/CommandList it = was > suggested to change the name. But what I dislike is having this command > without argument which always activates current root partition >> >> Maybe we could use a more generic solution, e.g. a command for setting >> different flags (or "attributes" in GPT terminology), such as bootable, >> read-only, hidden (that would apply only to some partition types in the >> PC partition table) and so on. > > It's a good possibility but I don't want to encumber the partition module > with non-essential functions since they're often integrated into core.img= . > But it's possible to have something like > > pctool hd0,1 boot+ hidden- > gpttool hd0,1 ro+ > > (Actually I find the name "pc" unfortunate, IMO "fdisk" would be much > better) > It's also possible to write a wrapper > parttool hd0,1 boot+ > > Which chooses the correct tool and launches it (a tool can be easily > registered as a pair of partition style name and a function). In this cas= e > we wouldn't even need separate command for different partition style. We > have however to find a way to list all available flags in > > help parttool Hi, The patch looks fine to me, except for perhaps the name. activate doesn't seems to suggest its function. Frankly, makeactive doesn't make much sense as well, but at least it's already widely used in grub legacy, old user could easily guess its function by name. --=20 Bean