From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LdzCW-0007A0-2Z for mharc-grub-devel@gnu.org; Sun, 01 Mar 2009 22:52:20 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LdzCT-00076a-SM for grub-devel@gnu.org; Sun, 01 Mar 2009 22:52:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LdzCS-00073u-9h for grub-devel@gnu.org; Sun, 01 Mar 2009 22:52:16 -0500 Received: from [199.232.76.173] (port=50988 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LdzCS-00073Z-4v for grub-devel@gnu.org; Sun, 01 Mar 2009 22:52:16 -0500 Received: from ti-out-0910.google.com ([209.85.142.191]:26166) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LdzCR-0006Ut-K5 for grub-devel@gnu.org; Sun, 01 Mar 2009 22:52:15 -0500 Received: by ti-out-0910.google.com with SMTP id j3so2561806tid.10 for ; Sun, 01 Mar 2009 19:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=uSMPDSWVGjnOOiyW0EeTciFxCkNDGZtRWt9diq0w1oo=; b=GeiNPQhG2F7KiOdOCqrmJyvy3EuEhjQoyO0ckO58EvNiYkX6JNFKE64/VAUQVFE9R2 On7I2bJvlW2z2GbWM6FtUiVghG5CO4Q86Fbd2Qn3PKFXYhgriNKbJQFqMGyWhB0OSsNw Vb+HwoAYWxvMPSFTbsZW2u1W7SiVXeiB4jvzw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=qkMBCX0VzP/oCaIFOTBqTYKODQ43GEs3EW5rJn7k6PiJcG2E/xzipC/bw6ZD1ArCnv YXYJgyhKetAo+N7Fsllvpn5BXZ4gOidh0hkiqQ3I0ykm9bgeXN64TLDxHaSPgdFgE+JM xmelwJMXM+i7RNxlKSNmEXocvh3EFq9ReTeIo= MIME-Version: 1.0 Received: by 10.110.63.17 with SMTP id l17mr8015958tia.32.1235965933794; Sun, 01 Mar 2009 19:52:13 -0800 (PST) In-Reply-To: <49AAFC17.7040608@gmail.com> References: <4992D603.9030105@gmail.com> <1234369601.25774.5.camel@mj> <499318E3.5040801@gmail.com> <49AAFC17.7040608@gmail.com> Date: Mon, 2 Mar 2009 11:52:13 +0800 Message-ID: From: Bean To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] make partition active X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Mar 2009 03:52:18 -0000 On Mon, Mar 2, 2009 at 5:20 AM, phcoder wrote: > Hello >>> >>> It's also possible to write a wrapper >>> parttool hd0,1 boot+ >>> >>> Which chooses the correct tool and launches it (a tool can be easily >>> registered as a pair of partition style name and a function). In this >>> case >>> we wouldn't even need separate command for different partition style. We >>> have however to find a way to list all available flags in >>> >>> help parttool >> >> Hi, >> >> The patch looks fine to me, except for perhaps the name. activate >> doesn't seems to suggest its function. Frankly, makeactive doesn't >> make much sense as well, but at least it's already widely used in grub >> legacy, old user could easily guess its function by name. >> > Then we could use parttool syntax. Then parttype can be implemented like > grub> parttool hd0,1 type=7 > makeactive like: > grub> parttool hd0,1 boot+ > And it can even be done by one command > grub> parttool hd0,1 boot+ type=7 > > Thank you for your attention to my patches Hi, In that case, you might want to use options, which save you the trouble of parsing parameters yourself, for example: parttool [--boot] [--type N] partition -- Bean