From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LijGj-0007Le-0l for mharc-grub-devel@gnu.org; Sun, 15 Mar 2009 01:52:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LijGf-0007LG-E5 for grub-devel@gnu.org; Sun, 15 Mar 2009 01:52:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LijGa-0007Iz-VI for grub-devel@gnu.org; Sun, 15 Mar 2009 01:52:12 -0400 Received: from [199.232.76.173] (port=51721 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LijGa-0007Iw-N2 for grub-devel@gnu.org; Sun, 15 Mar 2009 01:52:08 -0400 Received: from ti-out-0910.google.com ([209.85.142.188]:10829) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LijGa-00016r-6u for grub-devel@gnu.org; Sun, 15 Mar 2009 01:52:08 -0400 Received: by ti-out-0910.google.com with SMTP id j3so595716tid.10 for ; Sat, 14 Mar 2009 22:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=7ssFKUcFcANpgD9C7VZlgTCE6NBxhMuGkFfA/k3qF1g=; b=YMDB6whU1XBI2dc/ZvmLiJtrS3TG3V5gUdKKIeuk0/ZodkitzscTSOqjdAlL3Uvfqe 8Z+K2NQfQ8qHc+3J5Yc1rnEcQH292mFe/jra8T+z8sMNjZwqccRZhmfBCOHdTMTdbfpD xS9PQbABqUyuUL+MLLJ68TcsaVMVAMwnlpahI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=SxXE/JrYu2C0hTt+V+hpwNCzv/A38q6I7sYywquId8jCEvlSA/rkp8w0kkBfxF0vKw j97gAi6Js/M+ZoIExdycMUUOcJaFGXIPBrQae1+XGN8TNQvuCZYhRkCkKuMNVR0YJTF5 2mFUTgKVZbsvVqv169heS7uI8/Hszs8vb/yN4= MIME-Version: 1.0 Received: by 10.110.7.18 with SMTP id 18mr3558638tig.17.1237096325421; Sat, 14 Mar 2009 22:52:05 -0700 (PDT) In-Reply-To: <200903150610.40823.okuji@enbug.org> References: <49A50DA2.20604@netsyncro.com> <200903132050.12393.okuji@enbug.org> <49BA5037.60007@gmail.com> <200903150610.40823.okuji@enbug.org> Date: Sun, 15 Mar 2009 13:52:05 +0800 Message-ID: From: Bean To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Migrating to GRUB 2 in Debian (Re: Interesting GSoC project ideas for 09) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Mar 2009 05:52:14 -0000 On Sun, Mar 15, 2009 at 5:10 AM, Yoshinori K. Okuji wrote: > On Friday 13 March 2009 21:23:19 phcoder wrote: >> Look at load_env/save_env commands and grub-editenv util > > Thanks. Now I really regret that I didn't find those additions earlier. > > I do not like this implementation for the following reasons: > > - The saved file is not plain text, unlike GRUB Legacy. This is a bad choice. > Please let me know the reason why it must be binary, if any. Hi, As the command need to write to disk using blocklist information, which is not always correct (such as tail packing, sparse block), I use a magic header for verification. The length field is used to indicate the length of the block. because the command can't expand file, otherwise it would need to update fs information, which is too much for grub. > - The command names are ugly. Why didn't anybody follow Pavel's advise > using "env"? > > - The utility name is also ugly. I like Pavel's suggestion "grub-env". > > If nobody stops me, I will rewrite it in one week, without caring about > backward compatibility. I have no objection for the rename, although there should be two env commands, one to load and one to save. -- Bean