From: Bean <bean123ch@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Imminent bugfix release (1.97.1)
Date: Tue, 10 Nov 2009 16:28:39 +0800 [thread overview]
Message-ID: <ca0f59980911100028g696e1067n4a16f24d03e10d05@mail.gmail.com> (raw)
In-Reply-To: <ca0f59980911092139j243ea3a0r84981345010051cf@mail.gmail.com>
On Tue, Nov 10, 2009 at 1:39 PM, Bean <bean123ch@gmail.com> wrote:
> On Tue, Nov 10, 2009 at 5:34 AM, Vladimir 'phcoder' Serbinenko
> <phcoder@gmail.com> wrote:
>> But now it has a technical problem: it may read post array definitions.
>> If any of post-array memory is MMIO or absent reading from it may have
>> peculiar consequences
>>> Also, because s1 and s2 have two differents roles, I think it would be
>>> best to give them names that better suits them. ;)
>
> Hi,
>
> Right, I think it'd be better to use fixed size array, perhaps we can
> define a type grub_password_t for it.
>
> BTW, with fixed size array, the following algorithm should run exactly
> the same amount of instruction each time:
>
> typedef char grub_password_t[1024];
>
> int
> grub_auth_strcmp (const grub_password_t s1, const grub_password_t s2)
> {
> int r1 = 0;
> int r2 = 0;
> int i, *p;
>
> p = &r1;
> for (i = 0; i < sizeof (grub_password_t); i++, s1++, s2++)
> {
> *p |= (*s1 ^ *s2);
> if (*s1 == '\0')
> p = &r2;
> }
>
> return (r1 != 0);
> }
Hi,
Oh sorry, this one still have some issue, this should work:
typedef char grub_password_t[1024];
int
grub_auth_strcmp (const grub_password_t s1, const grub_password_t s2)
{
int r1 = 0;
int r2 = 0;
int i, *p1, *p2;
p1 = p2 = &r1;
for (i = 0; i < sizeof (grub_password_t); i++, s1++, s2++)
{
*p1 |= (*s1 ^ *s2);
if (*s1 == '\0')
p1 = &r2;
else
p2 = &r2;
}
return (r1 != 0);
}
--
Bean
My repository: https://launchpad.net/burg
Document: https://help.ubuntu.com/community/Burg
next prev parent reply other threads:[~2009-11-10 8:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 1:04 Imminent bugfix release (1.97.1) Robert Millan
2009-11-09 1:27 ` Robert Millan
2009-11-09 2:08 ` Jordan Uggla
2009-11-09 14:15 ` Robert Millan
2009-11-09 13:33 ` Bean
2009-11-09 13:50 ` Vladimir 'phcoder' Serbinenko
2009-11-09 14:18 ` Robert Millan
2009-11-09 14:21 ` Bean
2009-11-09 14:34 ` Vladimir 'phcoder' Serbinenko
2009-11-09 17:46 ` Duboucher Thomas
2009-11-09 18:10 ` Robert Millan
2009-11-09 18:15 ` Vladimir 'phcoder' Serbinenko
2009-11-09 18:25 ` Robert Millan
2009-11-09 18:36 ` Bean
2009-11-09 18:46 ` Vladimir 'phcoder' Serbinenko
2009-11-09 18:49 ` Bean
2009-11-09 21:13 ` Duboucher Thomas
2009-11-09 21:34 ` Vladimir 'phcoder' Serbinenko
2009-11-09 21:43 ` Duboucher Thomas
2009-11-09 22:06 ` Robert Millan
2009-11-09 22:46 ` Duboucher Thomas
2009-11-09 23:09 ` Darron Black
2009-11-09 23:50 ` richardvoigt
2009-11-09 23:56 ` Darron Black
2009-11-09 23:46 ` richardvoigt
2009-11-10 5:39 ` Bean
2009-11-10 8:28 ` Bean [this message]
2009-11-10 8:46 ` Bean
2009-11-10 8:52 ` Bean
2009-11-10 9:05 ` Bean
2009-11-10 12:37 ` Bean
2009-11-10 14:25 ` Duboucher Thomas
2009-11-10 14:47 ` Bean
2009-11-10 17:43 ` Duboucher Thomas
2009-11-10 19:01 ` Vladimir 'phcoder' Serbinenko
2009-11-10 19:04 ` Vladimir 'phcoder' Serbinenko
2009-11-10 21:29 ` Duboucher Thomas
2009-11-10 15:27 ` richardvoigt
2009-11-10 17:38 ` Duboucher Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca0f59980911100028g696e1067n4a16f24d03e10d05@mail.gmail.com \
--to=bean123ch@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.