From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F0DC4167B for ; Wed, 14 Dec 2022 18:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238257AbiLNSxC (ORCPT ); Wed, 14 Dec 2022 13:53:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237128AbiLNSxA (ORCPT ); Wed, 14 Dec 2022 13:53:00 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B9C629341 for ; Wed, 14 Dec 2022 10:52:57 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id s25so7616023lji.2 for ; Wed, 14 Dec 2022 10:52:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZseIU9pUHVwznNtxNlFxx+0mTPXyTHR3NZJ8jxTNHvY=; b=r/gW/N2Pnn4oZW8y86l9QHLF343OH2bshWe8KXeJ0yZ3tWuEcwyRugUz0q4xtyDE1o cGWrdvNidcO9AiiaboC+4oTdrw+29Bm8FDdoRZXbnfjdJe/Cto/H5RvQTS58jWylWX1K SZyM5/ZHedIIs3MDjXFzCk0B7wntCny+eUl+Ui6cx07xFFqOwCK5W5X3zQtJx14x6c5i YeU0DexZQtJfMT/w2tCslRmgsZAtV681kCGIU/1Jo03bVYZna9POL3J0x1noKdjgocZR n4ncmQzYUp/aBrcoiU+A5tP3hxbdzICfzSi+O/oP9XMIs4Q5OU5ERsgBzeRc3xmu/JCn wVoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZseIU9pUHVwznNtxNlFxx+0mTPXyTHR3NZJ8jxTNHvY=; b=k8G7xzytM2kSza4L4qk7zS7cN4vING8G4Bbiw+5EYKwQmC2eDgY3zWAilRcNI4zkCs tR8Du6Hlip8cfz52jjDsFpyamt3P6o8KNsXA7wSQKwS6y+5Sima5MGRQTlRWSw/x9+c/ WVSLA/oqntMobdcqi7ajwp+265PjuDIwg4G51RWTZV5UnJ7HO6dPc7hLCxWe/UKUPBuf FX9BKk7kgMb+r4K9lJDInWMryRzWGS7HeIgtsKAH9JTfZUDRfybiYw7CC+IigN+/Bkw0 XeZ9NRboo9RDXpnlTwZoz1ytqlu+ggN07lVPJL1mv62mXm+hIropy9CPTDViLSFuofeF 8QUg== X-Gm-Message-State: ANoB5plhczxpHMRUYo1KEjCNkOekpate7NUoCkxVxvfMb6wCmleJB6N6 NtoYPqNdXTzPudWx1PeRabi8BQ== X-Google-Smtp-Source: AA0mqf7ZgNkE56lYnu/RzMo2/dyqB/FcOcbFfYQFPy+YE495hfWhIWasUAYLlY1RxV/76aJczrI/Tw== X-Received: by 2002:a05:651c:178d:b0:26f:e87b:d3bd with SMTP id bn13-20020a05651c178d00b0026fe87bd3bdmr8121650ljb.39.1671043975587; Wed, 14 Dec 2022 10:52:55 -0800 (PST) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id q20-20020a2e9694000000b002770eafaafbsm695766lji.99.2022.12.14.10.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 10:52:55 -0800 (PST) Message-ID: Date: Wed, 14 Dec 2022 20:52:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH 4/6] drm/msm/dsi: Use DSC slice(s) packet size to compute word count Content-Language: en-GB To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Vinod Koul Cc: ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Sean Paul , David Airlie , Daniel Vetter , Stephen Boyd , Bjorn Andersson , Jessica Zhang , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Kuogee Hsieh , Jani Nikula , sunliming , Sam Ravnborg , Haowen Bai , Konrad Dybcio , Loic Poulain , Vinod Polimera , Douglas Anderson , Vladimir Lypak , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221213232207.113607-1-marijn.suijten@somainline.org> <20221213232207.113607-5-marijn.suijten@somainline.org> From: Dmitry Baryshkov In-Reply-To: <20221213232207.113607-5-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 14/12/2022 01:22, Marijn Suijten wrote: > According to downstream the value to use for WORD_COUNT is > bytes_per_pkt, which denotes the number of bytes in a packet based on > how many slices have been configured by the panel driver times the > width of a slice times the number of bytes per pixel. > > The DSC panels seen thus far use one byte per pixel, only one slice > per packet, and a slice width of half the panel width leading to the > desired bytes_per_pkt+1 value to be equal to hdisplay/2+1. This however > isn't the case anymore for panels that configure two slices per packet, > where the value should now be hdisplay+1. > > Note that the aforementioned panel (on a Sony Xperia XZ3, sdm845) with > slice_count=1 has also been tested to successfully accept slice_count=2, > which would have shown corrupted output previously. > > Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration") > Signed-off-by: Marijn Suijten > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4435C001B2 for ; Wed, 14 Dec 2022 18:53:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 76DC710E446; Wed, 14 Dec 2022 18:53:02 +0000 (UTC) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id 953D310E457 for ; Wed, 14 Dec 2022 18:52:57 +0000 (UTC) Received: by mail-lj1-x232.google.com with SMTP id h10so7560527ljk.11 for ; Wed, 14 Dec 2022 10:52:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZseIU9pUHVwznNtxNlFxx+0mTPXyTHR3NZJ8jxTNHvY=; b=r/gW/N2Pnn4oZW8y86l9QHLF343OH2bshWe8KXeJ0yZ3tWuEcwyRugUz0q4xtyDE1o cGWrdvNidcO9AiiaboC+4oTdrw+29Bm8FDdoRZXbnfjdJe/Cto/H5RvQTS58jWylWX1K SZyM5/ZHedIIs3MDjXFzCk0B7wntCny+eUl+Ui6cx07xFFqOwCK5W5X3zQtJx14x6c5i YeU0DexZQtJfMT/w2tCslRmgsZAtV681kCGIU/1Jo03bVYZna9POL3J0x1noKdjgocZR n4ncmQzYUp/aBrcoiU+A5tP3hxbdzICfzSi+O/oP9XMIs4Q5OU5ERsgBzeRc3xmu/JCn wVoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZseIU9pUHVwznNtxNlFxx+0mTPXyTHR3NZJ8jxTNHvY=; b=q2jgn6KxdCVAF2bGF+L/nLhJrFI8Zq6bowkJEgfm1dJh5vA0S+L41PPVDfgdtr8AUE 9JO3VxSBeZk0TyWBDcbgFnxh+6m+qKbCZg+jKUmgcUsIuc3EH4eBRawVEciX0S0+jJXA Q4LF1TtmITSQHgOi4cf4FdJ7IVwmCWffUSmXMXPTTn69Jm15BiiCAAS4dK3NUmKU+i+8 HIZYbiJm+1C5AfVuXGdFVNJn0OHGnAMOy+I4ogRyNrkuPtAd2oFUdOjVDyDvBR2MnS1A bmZtbOvUCkTdaCE/DDupT3dbdbwUXYNkkxXYJMWyPqMinUphOz09fMIh5alQBuPeXluY CAdA== X-Gm-Message-State: ANoB5pmi3RibxRigu4+mAfGKweoZ8l5ZjGybsNDHN114JwkDPzpPuoK/ ViN3GX9IIbh865GssWqm7LW1PA== X-Google-Smtp-Source: AA0mqf7ZgNkE56lYnu/RzMo2/dyqB/FcOcbFfYQFPy+YE495hfWhIWasUAYLlY1RxV/76aJczrI/Tw== X-Received: by 2002:a05:651c:178d:b0:26f:e87b:d3bd with SMTP id bn13-20020a05651c178d00b0026fe87bd3bdmr8121650ljb.39.1671043975587; Wed, 14 Dec 2022 10:52:55 -0800 (PST) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id q20-20020a2e9694000000b002770eafaafbsm695766lji.99.2022.12.14.10.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 10:52:55 -0800 (PST) Message-ID: Date: Wed, 14 Dec 2022 20:52:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH 4/6] drm/msm/dsi: Use DSC slice(s) packet size to compute word count Content-Language: en-GB To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Vinod Koul References: <20221213232207.113607-1-marijn.suijten@somainline.org> <20221213232207.113607-5-marijn.suijten@somainline.org> From: Dmitry Baryshkov In-Reply-To: <20221213232207.113607-5-marijn.suijten@somainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Konrad Dybcio , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Vinod Polimera , Sam Ravnborg , Haowen Bai , Kuogee Hsieh , Jessica Zhang , Jani Nikula , linux-arm-msm@vger.kernel.org, Stephen Boyd , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, Sean Paul , Loic Poulain , Jami Kettunen , Bjorn Andersson , Vladimir Lypak , Douglas Anderson , Konrad Dybcio , sunliming , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 14/12/2022 01:22, Marijn Suijten wrote: > According to downstream the value to use for WORD_COUNT is > bytes_per_pkt, which denotes the number of bytes in a packet based on > how many slices have been configured by the panel driver times the > width of a slice times the number of bytes per pixel. > > The DSC panels seen thus far use one byte per pixel, only one slice > per packet, and a slice width of half the panel width leading to the > desired bytes_per_pkt+1 value to be equal to hdisplay/2+1. This however > isn't the case anymore for panels that configure two slices per packet, > where the value should now be hdisplay+1. > > Note that the aforementioned panel (on a Sony Xperia XZ3, sdm845) with > slice_count=1 has also been tested to successfully accept slice_count=2, > which would have shown corrupted output previously. > > Fixes: 08802f515c3c ("drm/msm/dsi: Add support for DSC configuration") > Signed-off-by: Marijn Suijten > --- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry