From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B2E0C2D0BF for ; Thu, 5 Dec 2019 08:33:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7302F21823 for ; Thu, 5 Dec 2019 08:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728978AbfLEId4 (ORCPT ); Thu, 5 Dec 2019 03:33:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:38160 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725974AbfLEId4 (ORCPT ); Thu, 5 Dec 2019 03:33:56 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C314AACA5; Thu, 5 Dec 2019 08:33:54 +0000 (UTC) Subject: Re: [PATCH 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB To: James Tai Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-realtek-soc@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org References: <20191205082555.22633-1-james.tai@realtek.com> <20191205082555.22633-2-james.tai@realtek.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Thu, 5 Dec 2019 09:33:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191205082555.22633-2-james.tai@realtek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, Am 05.12.19 um 09:25 schrieb James Tai: > Define compatible strings for Realtek RTD1319 SoC and Realtek PymParticle > EVB. > > Signed-off-by: James Tai > --- > Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml > index 2444eff2c3d5..f018d683a544 100644 > --- a/Documentation/devicetree/bindings/arm/realtek.yaml > +++ b/Documentation/devicetree/bindings/arm/realtek.yaml > @@ -39,4 +39,10 @@ properties: > - enum: > - realtek,mjolnir # Realtek Mjolnir EVB > - const: realtek,rtd1619 > + > + # RTD1319 SoC based boards > + - items: > + - enum: > + - realtek,pymparticle # Realtek PymParticle EVB > + - const: realtek,rtd1319 > ... I think it would be better to order this alphabetically before RTD1395. Otherwise looking good. Thanks, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 398AEC43603 for ; Thu, 5 Dec 2019 08:34:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A5D521823 for ; Thu, 5 Dec 2019 08:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LcPczuWT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A5D521823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qz6m2ev5BOtM9RNPUEyRUj8QlW/64VKmOjaf+8VDe2Y=; b=LcPczuWTQSRjaU KXteQlQj/2BYfPlyD/3BZMzVzwMFnyXf3WJKiS/pqcTQth8jWoVjARTwP79hWR5gpWuQFR4CNxbsa eTz87o9KkWxC8KXMy7xY7+cuJ271GycJFaeAh9NJrlVXHaQW3t0/x1xk7iD0M5ljbwgzRe1oX3emo vh4F3p/A8BQ6ivb3Emr+I9Ynmfo34MXEKNStTV3iimCvok1jkM7P7ufkxe4iofG2fuedE61AHIVuQ OmskYb9CPoRgPAJ0au8x+V3s7I6dGS+LXXYe7rJZDt2PlRWi2rks1kkl02qjw1xL99oxkMm1kyLC4 O66F50+hihB5AAw6hE0Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icmaG-0000sz-RX; Thu, 05 Dec 2019 08:34:00 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1icmaC-0000ry-9u; Thu, 05 Dec 2019 08:33:58 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C314AACA5; Thu, 5 Dec 2019 08:33:54 +0000 (UTC) Subject: Re: [PATCH 1/2] dt-bindings: arm: realtek: Document RTD1319 and Realtek PymParticle EVB To: James Tai References: <20191205082555.22633-1-james.tai@realtek.com> <20191205082555.22633-2-james.tai@realtek.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: Date: Thu, 5 Dec 2019 09:33:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191205082555.22633-2-james.tai@realtek.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191205_003357_571304_1AD18917 X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-realtek-soc@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFtZXMsCgpBbSAwNS4xMi4xOSB1bSAwOToyNSBzY2hyaWViIEphbWVzIFRhaToKPiBEZWZp bmUgY29tcGF0aWJsZSBzdHJpbmdzIGZvciBSZWFsdGVrIFJURDEzMTkgU29DIGFuZCBSZWFsdGVr IFB5bVBhcnRpY2xlCj4gRVZCLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEphbWVzIFRhaSA8amFtZXMu dGFpQHJlYWx0ZWsuY29tPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvYXJtL3JlYWx0ZWsueWFtbCB8IDYgKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2Vy dGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2FybS9yZWFsdGVrLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv YXJtL3JlYWx0ZWsueWFtbAo+IGluZGV4IDI0NDRlZmYyYzNkNS4uZjAxOGQ2ODNhNTQ0IDEwMDY0 NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vcmVhbHRlay55 YW1sCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9yZWFsdGVr LnlhbWwKPiBAQCAtMzksNCArMzksMTAgQEAgcHJvcGVydGllczoKPiAgICAgICAgICAgIC0gZW51 bToKPiAgICAgICAgICAgICAgICAtIHJlYWx0ZWssbWpvbG5pciAjIFJlYWx0ZWsgTWpvbG5pciBF VkIKPiAgICAgICAgICAgIC0gY29uc3Q6IHJlYWx0ZWsscnRkMTYxOQo+ICsKPiArICAgICAjIFJU RDEzMTkgU29DIGJhc2VkIGJvYXJkcwo+ICsgICAgIC0gaXRlbXM6Cj4gKyAgICAgICAgICAtIGVu dW06Cj4gKyAgICAgICAgICAgICAgLSByZWFsdGVrLHB5bXBhcnRpY2xlICMgUmVhbHRlayBQeW1Q YXJ0aWNsZSBFVkIKPiArICAgICAgICAgIC0gY29uc3Q6IHJlYWx0ZWsscnRkMTMxOQo+ICAuLi4K CkkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIG9yZGVyIHRoaXMgYWxwaGFiZXRpY2FsbHkg YmVmb3JlIFJURDEzOTUuCgpPdGhlcndpc2UgbG9va2luZyBnb29kLgoKVGhhbmtzLApBbmRyZWFz CgotLSAKU1VTRSBTb2Z0d2FyZSBTb2x1dGlvbnMgR2VybWFueSBHbWJICk1heGZlbGRzdHIuIDUs IDkwNDA5IE7DvHJuYmVyZywgR2VybWFueQpHRjogRmVsaXggSW1lbmTDtnJmZmVyCkhSQiAzNjgw OSAoQUcgTsO8cm5iZXJnKQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=