From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1418C4338F for ; Fri, 13 Aug 2021 09:16:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 865D860FC0 for ; Fri, 13 Aug 2021 09:16:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239496AbhHMJQg (ORCPT ); Fri, 13 Aug 2021 05:16:36 -0400 Received: from foss.arm.com ([217.140.110.172]:51826 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239035AbhHMJQe (ORCPT ); Fri, 13 Aug 2021 05:16:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B66141042; Fri, 13 Aug 2021 02:16:07 -0700 (PDT) Received: from [10.57.36.146] (unknown [10.57.36.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0071B3F70D; Fri, 13 Aug 2021 02:16:05 -0700 (PDT) Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW0V4dGVybmFsXVJlOiBBbiBjbWEgb3B0aW1pemF0?= =?UTF-8?Q?ion_patch_is_used_for_cma=5f=5balloc=7cfree=5d=2e?= To: Jichao Zou , David Hildenbrand , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "minchan@kernel.org" , "song.bao.hua@hisilicon.com" , "hch@lst.de" , "m.szyprowski@samsung.com" , "iommu@lists.linux-foundation.org" , JianQi Yang , Yanjune Tian References: From: Robin Murphy Message-ID: Date: Fri, 13 Aug 2021 10:15:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-08-13 09:27, Jichao Zou wrote: > Hi David, > I'll git-send-email patch again. > Your understanding is exactly right. > Let me explain the background of Patch, we are developing Android phone, kernel is 5.10.43 LTS, we encounter cma_alloc failed during kernel startup, buddy system is ready, > 01-11 14:22:08.650 216 216 E cma : cma_alloc([216][init]:cma(ffffffff00b50000:total 8192) linux,cma(ffffffe89d084cf0), count 2, align 1 gfp_mask 0xcc0) > 01-11 14:22:08.650 216 216 E cma : cma_alloc(): memory range at ffffffff00b62880 is busy, retrying > > cma bitmap show memory is free, but alloc_contig_range failed, we checked it out that some drivers cma_alloc are > "struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, bool no_warn)" > In 5.10.43, cma_alloc is > "struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, gfp_t gfp_mask)" > After change cma_alloc parameter with GFP_KERNEL, issue is fixed, at the same time, we found that preallocate a portion of cma memory for audio&video resulted in better performance and guarantee AV function even under memory pressure, so we try to submit this patch. The whole point of CMA is that the memory can be shared by moveable pages while it's not being used for DMA. If you want a dedicated DMA carveout, there are already mechanisms for that. Robin. > > Thanks. > > Best Regards, > > Zou Jichao 邹纪超 > Advisory Engineer, SW BSP > MBG ROW SW BJ PF BSP (CN) > Motorola Mobility, A Lenovo Company > motorola.com > M +86 18910860212 > E zoujc@lenovo.com > twitter | facebook | instagram | blog | forums > > > > > -----邮件原件----- > 发件人: David Hildenbrand > 发送时间: 2021年8月13日 15:45 > 收件人: Jichao Zou ; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; linux-mm@kvack.org; minchan@kernel.org; song.bao.hua@hisilicon.com; hch@lst.de; m.szyprowski@samsung.com; robin.murphy@arm.com; iommu@lists.linux-foundation.org; JianQi Yang ; Yanjune Tian > 主题: [External]Re: An cma optimization patch is used for cma_[alloc|free]. > > On 13.08.21 09:00, Jichao Zou wrote: >> Pre-allocate CMA memory that configured in device tree, this greatly >> improves the CMA memory allocation efficiency, cma_[alloc|free] is >> less than 1ms, old way is took a few ms to tens or hundreds ms. >> > > Please send patches as proper emails (man git-format-patch; man git-send-email). > > What you propose is turning cma reservations into something comparable to permanent boottime allocations. From the POV of the buddy, the pages are always allocated and cannot be repurposed for e.g., movable allocations until *actually* allocated via CMA. > > I don't think we want this behavior upstream. > > -- > Thanks, > > David / dhildenb > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95AD7C4338F for ; Fri, 13 Aug 2021 09:16:19 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C37C6104F for ; Fri, 13 Aug 2021 09:16:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C37C6104F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 082C360BC4; Fri, 13 Aug 2021 09:16:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 189eC5POnyyq; Fri, 13 Aug 2021 09:16:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id B4EBA60BA7; Fri, 13 Aug 2021 09:16:14 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8F840C0010; Fri, 13 Aug 2021 09:16:14 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id B7329C000E for ; Fri, 13 Aug 2021 09:16:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AC6B14047B for ; Fri, 13 Aug 2021 09:16:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ViPDfCXRHBDZ for ; Fri, 13 Aug 2021 09:16:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp4.osuosl.org (Postfix) with ESMTP id AF8984041A for ; Fri, 13 Aug 2021 09:16:08 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B66141042; Fri, 13 Aug 2021 02:16:07 -0700 (PDT) Received: from [10.57.36.146] (unknown [10.57.36.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0071B3F70D; Fri, 13 Aug 2021 02:16:05 -0700 (PDT) Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW0V4dGVybmFsXVJlOiBBbiBjbWEgb3B0aW1pemF0?= =?UTF-8?Q?ion_patch_is_used_for_cma=5f=5balloc=7cfree=5d=2e?= To: Jichao Zou , David Hildenbrand , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "minchan@kernel.org" , "song.bao.hua@hisilicon.com" , "hch@lst.de" , "m.szyprowski@samsung.com" , "iommu@lists.linux-foundation.org" , JianQi Yang , Yanjune Tian References: From: Robin Murphy Message-ID: Date: Fri, 13 Aug 2021 10:15:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMjAyMS0wOC0xMyAwOToyNywgSmljaGFvIFpvdSB3cm90ZToKPiBIaSBEYXZpZCwKPiAJSSds bCBnaXQtc2VuZC1lbWFpbCBwYXRjaCBhZ2Fpbi4KPiAJWW91ciB1bmRlcnN0YW5kaW5nIGlzIGV4 YWN0bHkgcmlnaHQuCj4gCUxldCBtZSBleHBsYWluIHRoZSBiYWNrZ3JvdW5kIG9mIFBhdGNoLCB3 ZSBhcmUgZGV2ZWxvcGluZyBBbmRyb2lkIHBob25lLCBrZXJuZWwgaXMgNS4xMC40MyBMVFMsIHdl IGVuY291bnRlciBjbWFfYWxsb2MgZmFpbGVkIGR1cmluZyBrZXJuZWwgc3RhcnR1cCwgYnVkZHkg c3lzdGVtIGlzIHJlYWR5LAo+IDAxLTExIDE0OjIyOjA4LjY1MCAgIDIxNiAgIDIxNiBFIGNtYSAg ICAgOiBjbWFfYWxsb2MoWzIxNl1baW5pdF06Y21hKGZmZmZmZmZmMDBiNTAwMDA6dG90YWwgODE5 MikgbGludXgsY21hKGZmZmZmZmU4OWQwODRjZjApLCBjb3VudCAyLCBhbGlnbiAxIGdmcF9tYXNr IDB4Y2MwKQo+IDAxLTExIDE0OjIyOjA4LjY1MCAgIDIxNiAgIDIxNiBFIGNtYSAgICAgOiBjbWFf YWxsb2MoKTogbWVtb3J5IHJhbmdlIGF0IGZmZmZmZmZmMDBiNjI4ODAgaXMgYnVzeSwgcmV0cnlp bmcKPiAgIAo+IAljbWEgYml0bWFwIHNob3cgbWVtb3J5IGlzIGZyZWUsIGJ1dCBhbGxvY19jb250 aWdfcmFuZ2UgZmFpbGVkLCB3ZSBjaGVja2VkIGl0IG91dCB0aGF0IHNvbWUgZHJpdmVycyBjbWFf YWxsb2MgYXJlCj4gCSJzdHJ1Y3QgcGFnZSAqY21hX2FsbG9jKHN0cnVjdCBjbWEgKmNtYSwgc2l6 ZV90IGNvdW50LCB1bnNpZ25lZCBpbnQgYWxpZ24sIGJvb2wgbm9fd2FybikiCj4gCUluIDUuMTAu NDMsIGNtYV9hbGxvYyBpcwo+IAkic3RydWN0IHBhZ2UgKmNtYV9hbGxvYyhzdHJ1Y3QgY21hICpj bWEsIHNpemVfdCBjb3VudCwgdW5zaWduZWQgaW50IGFsaWduLCBnZnBfdCBnZnBfbWFzaykiCj4g ICAJQWZ0ZXIgY2hhbmdlIGNtYV9hbGxvYyBwYXJhbWV0ZXIgd2l0aCBHRlBfS0VSTkVMLCBpc3N1 ZSBpcyBmaXhlZCwgYXQgdGhlIHNhbWUgdGltZSwgd2UgZm91bmQgdGhhdCBwcmVhbGxvY2F0ZSBh IHBvcnRpb24gb2YgY21hIG1lbW9yeSBmb3IgYXVkaW8mdmlkZW8gcmVzdWx0ZWQgaW4gYmV0dGVy IHBlcmZvcm1hbmNlIGFuZCBndWFyYW50ZWUgQVYgZnVuY3Rpb24gZXZlbiB1bmRlciBtZW1vcnkg cHJlc3N1cmUsIHNvIHdlIHRyeSB0byBzdWJtaXQgdGhpcyBwYXRjaC4KClRoZSB3aG9sZSBwb2lu dCBvZiBDTUEgaXMgdGhhdCB0aGUgbWVtb3J5IGNhbiBiZSBzaGFyZWQgYnkgbW92ZWFibGUgCnBh Z2VzIHdoaWxlIGl0J3Mgbm90IGJlaW5nIHVzZWQgZm9yIERNQS4gSWYgeW91IHdhbnQgYSBkZWRp Y2F0ZWQgRE1BIApjYXJ2ZW91dCwgdGhlcmUgYXJlIGFscmVhZHkgbWVjaGFuaXNtcyBmb3IgdGhh dC4KClJvYmluLgoKPiAKPiBUaGFua3MuCj4gCj4gQmVzdCBSZWdhcmRzLAo+IAo+IFpvdSBKaWNo YW8g6YK557qq6LaFCj4gQWR2aXNvcnkgRW5naW5lZXIsIFNXIEJTUAo+IE1CRyBST1cgU1cgQkog UEYgQlNQIChDTikKPiBNb3Rvcm9sYSBNb2JpbGl0eSwgQSBMZW5vdm8gQ29tcGFueQo+IG1vdG9y b2xhLmNvbQo+IE0gKzg2IDE4OTEwODYwMjEyCj4gRSB6b3VqY0BsZW5vdm8uY29tCj4gdHdpdHRl ciB8IGZhY2Vib29rIHwgaW5zdGFncmFtIHwgYmxvZyB8IGZvcnVtcwo+IAo+IAo+IAo+IAo+IC0t LS0t6YKu5Lu25Y6f5Lu2LS0tLS0KPiDlj5Hku7bkuro6IERhdmlkIEhpbGRlbmJyYW5kIDxkYXZp ZEByZWRoYXQuY29tPgo+IOWPkemAgeaXtumXtDogMjAyMeW5tDjmnIgxM+aXpSAxNTo0NQo+IOaU tuS7tuS6ujogSmljaGFvIFpvdSA8em91amNAbW90b3JvbGEuY29tPjsgYWtwbUBsaW51eC1mb3Vu ZGF0aW9uLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgbGludXgtbW1Aa3ZhY2su b3JnOyBtaW5jaGFuQGtlcm5lbC5vcmc7IHNvbmcuYmFvLmh1YUBoaXNpbGljb24uY29tOyBoY2hA bHN0LmRlOyBtLnN6eXByb3dza2lAc2Ftc3VuZy5jb207IHJvYmluLm11cnBoeUBhcm0uY29tOyBp b21tdUBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZzsgSmlhblFpIFlhbmcgPHlhbmdqQG1vdG9y b2xhLmNvbT47IFlhbmp1bmUgVGlhbiA8dGlhbnlqZUBtb3Rvcm9sYS5jb20+Cj4g5Li76aKYOiBb RXh0ZXJuYWxdUmU6IEFuIGNtYSBvcHRpbWl6YXRpb24gcGF0Y2ggaXMgdXNlZCBmb3IgY21hX1th bGxvY3xmcmVlXS4KPiAKPiBPbiAxMy4wOC4yMSAwOTowMCwgSmljaGFvIFpvdSB3cm90ZToKPj4g UHJlLWFsbG9jYXRlwqBDTUHCoG1lbW9yecKgdGhhdMKgY29uZmlndXJlZMKgaW7CoGRldmljZSB0 cmVlLMKgdGhpc8KgZ3JlYXRseQo+PiBpbXByb3Zlc8KgdGhlwqBDTUHCoG1lbW9yeSBhbGxvY2F0 aW9uwqBlZmZpY2llbmN5LMKgY21hX1thbGxvY3xmcmVlXcKgaXMKPj4gbGVzcyB0aGFuwqAxbXMs wqBvbGTCoHdhecKgaXPCoHRvb2vCoGHCoGZld8KgbXPCoHRvwqB0ZW5zwqBvciBodW5kcmVkc8Kg bXMuCj4+Cj4gCj4gUGxlYXNlIHNlbmQgcGF0Y2hlcyBhcyBwcm9wZXIgZW1haWxzIChtYW4gZ2l0 LWZvcm1hdC1wYXRjaDsgbWFuIGdpdC1zZW5kLWVtYWlsKS4KPiAKPiBXaGF0IHlvdSBwcm9wb3Nl IGlzIHR1cm5pbmcgY21hIHJlc2VydmF0aW9ucyBpbnRvIHNvbWV0aGluZyBjb21wYXJhYmxlIHRv IHBlcm1hbmVudCBib290dGltZSBhbGxvY2F0aW9ucy4gRnJvbSB0aGUgUE9WIG9mIHRoZSBidWRk eSwgdGhlIHBhZ2VzIGFyZSBhbHdheXMgYWxsb2NhdGVkIGFuZCBjYW5ub3QgYmUgcmVwdXJwb3Nl ZCBmb3IgZS5nLiwgbW92YWJsZSBhbGxvY2F0aW9ucyB1bnRpbCAqYWN0dWFsbHkqIGFsbG9jYXRl ZCB2aWEgQ01BLgo+IAo+IEkgZG9uJ3QgdGhpbmsgd2Ugd2FudCB0aGlzIGJlaGF2aW9yIHVwc3Ry ZWFtLgo+IAo+IC0tCj4gVGhhbmtzLAo+IAo+IERhdmlkIC8gZGhpbGRlbmIKPiAKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0 CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3Vu ZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11