From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-ve1eur01on0086.outbound.protection.outlook.com ([104.47.1.86]:27872
        "EHLO EUR01-VE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751396AbeCTISM (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 20 Mar 2018 04:18:12 -0400
Subject: Re: [bpf-next V3 PATCH 13/15] mlx5: use page_pool for
 xdp_return_frame call
To: Tariq Toukan <tariqt@mellanox.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org,
        =?UTF-8?B?QmrDtnJuVMO2cGVs?= <bjorn.topel@intel.com>,
        magnus.karlsson@intel.com, eugenia@mellanox.com,
        Jason Wang <jasowang@redhat.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>, galp@mellanox.com,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>
References: <152062887576.27458.8590966896888512270.stgit@firesoul>
 <152062896782.27458.5542026179434739900.stgit@firesoul>
 <247192bd-761e-426c-c462-59efe3b7ca97@mellanox.com>
 <22866952-6bdf-2529-91a1-fb31bd2f2c2d@mellanox.com>
 <6e62fa6a-53c7-57a9-0493-3a48d832b479@mellanox.com>
 <20180319141217.416d269a@redhat.com>
 <66f0da5a-388d-5ddc-4bb7-441f6df4af96@mellanox.com>
From: Tariq Toukan <tariqt@mellanox.com>
Message-ID: <ca4a6cf9-6a8d-6fff-825d-b8311b3bce69@mellanox.com>
Date: Tue, 20 Mar 2018 10:18:02 +0200
MIME-Version: 1.0
In-Reply-To: <66f0da5a-388d-5ddc-4bb7-441f6df4af96@mellanox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


>> I see the issue.  I have to go over the details in the driver, but I
>> think it should be sufficient to remove the WARN().  When the page_pool
>> was integrated with the MM-layer, being invoked from the put_page()
>> call itself, this would indicate a likely API misuse.  But now, with
>> the page refcnt based recycle tricks, it is the norm (for non-XDP) that
>> put_page is called without the knowledge of page_pool.
>>
> I see, I'll remove the WARN and test.
> 

Verified, it works. Please fix in next patchset.

Thanks.