All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH 2/2] i915/perf: Sanity check reports in mapped OA buffer
Date: Mon, 27 Jul 2020 10:31:45 +0300	[thread overview]
Message-ID: <ca4faede-36f3-30b3-86c0-194459cc0708@intel.com> (raw)
In-Reply-To: <20200724233319.GA45897@orsosgc001.amr.corp.intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 961 bytes --]

On 25/07/2020 02:33, Umesh Nerlige Ramappa wrote:
>>
>> 16Mb * 256 = 4Gb
>>
>> That way you verify that we're not leaking GGTT space when closing 
>> the perf fd.
>>
>> You might want to tweak the noa_wait sysfs value before/after the loop.
>>
>> This might also only work on !32bits machines with enough memory...
>>
>
> Looks like calling close() in the above sequence will not result in a 
> call to i915_perf_release (because mmap holds a reference to the file).
> Based on the latest patch series in the mailing list, if you see 
> something we can add, please let me know. Note that we block mremap of 
> an mmap-ped address by setting VM_DONTEXPAND in i915 perf mmap 
> implementation.
>
> Thanks,
> Umesh 

Oh thanks for reminding me :)

Since mmap holds a ref that means nobody will be able to open the stream 
once more until munmap is called.

So there won't be any GGTT space leakage and it's all good.


Forget my request then.

Thanks!


-Lionel


[-- Attachment #1.2: Type: text/html, Size: 1658 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-07-27  7:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21  1:57 [igt-dev] [PATCH 1/2] i915/perf: add tests for triggered OA reports Umesh Nerlige Ramappa
2020-07-21  1:57 ` [igt-dev] [PATCH 2/2] i915/perf: Sanity check reports in mapped OA buffer Umesh Nerlige Ramappa
2020-07-21  6:21   ` Lionel Landwerlin
2020-07-24 23:33     ` Umesh Nerlige Ramappa
2020-07-27  7:31       ` Lionel Landwerlin [this message]
2020-07-21  2:23 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/2] i915/perf: add tests for triggered OA reports Patchwork
2020-07-21  3:37 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2020-07-17 23:58 [igt-dev] [PATCH 1/2] " Umesh Nerlige Ramappa
2020-07-17 23:58 ` [igt-dev] [PATCH 2/2] i915/perf: Sanity check reports in mapped OA buffer Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca4faede-36f3-30b3-86c0-194459cc0708@intel.com \
    --to=lionel.g.landwerlin@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.