From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-clk <linux-clk@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Georgi Djakov <georgi.djakov@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>
Subject: Re: [PATCH v1] clk: qcom: msm8916: Don't build support by default
Date: Thu, 13 Jun 2019 17:05:08 +0200 [thread overview]
Message-ID: <ca7c9fbd-d611-6ab6-6d23-54dfc4c2f165@free.fr> (raw)
In-Reply-To: <20190612191347.GE22737@tuxbook-pro>
On 12/06/2019 21:13, Bjorn Andersson wrote:
> On Wed 12 Jun 08:52 PDT 2019, Marc Gonzalez wrote:
>
>> Build QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 by default only when
>> we're building MSM_GCC_8916.
>>
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
>
> Not sure why these are default at all.
>
> But both drivers are used on platforms other than 8916 as well, so if
> anything a fix would be to rename the APCS_MSM8916 to something more
> generic (such as QCOM_CLK_APCS_GLOBAL) - but then the content should be
> updated and the APCS mailbox driver as well...
Used on platforms other than 8916? do you see that?
$ git grep compatible drivers/clk/qcom/a53-pll.c
{ .compatible = "qcom,msm8916-a53pll" },
$ git grep qcom,msm8916-a53pll arch/arm64/boot/dts
arch/arm64/boot/dts/qcom/msm8916.dtsi: compatible = "qcom,msm8916-a53pll";
drivers/clk/qcom/apcs-msm8916.c doesn't seem to support DT...
$ git grep qcom-apcs-msm8916-clk
drivers/clk/qcom/apcs-msm8916.c: .name = "qcom-apcs-msm8916-clk",
drivers/mailbox/qcom-apcs-ipc-mailbox.c: "qcom-apcs-msm8916-clk",
if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
apcs->clk = platform_device_register_data(&pdev->dev, "qcom-apcs-msm8916-clk", -1, NULL, 0);
$ git grep qcom,msm8916-apcs-kpss-global
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt: "qcom,msm8916-apcs-kpss-global",
Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt: compatible = "qcom,msm8916-apcs-kpss-global";
arch/arm64/boot/dts/qcom/msm8916.dtsi: compatible = "qcom,msm8916-apcs-kpss-global", "syscon";
drivers/mailbox/qcom-apcs-ipc-mailbox.c: if (of_device_is_compatible(np, "qcom,msm8916-apcs-kpss-global")) {
drivers/mailbox/qcom-apcs-ipc-mailbox.c: { .compatible = "qcom,msm8916-apcs-kpss-global", .data = (void *)8 },
Are you sure about other platforms?
Regards.
prev parent reply other threads:[~2019-06-13 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 15:52 [PATCH v1] clk: qcom: msm8916: Don't build support by default Marc Gonzalez
2019-06-12 19:13 ` Bjorn Andersson
2019-06-12 19:49 ` Stephen Boyd
2019-06-12 20:03 ` Marc Gonzalez
2019-06-12 22:42 ` Stephen Boyd
2019-06-13 15:05 ` Marc Gonzalez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca7c9fbd-d611-6ab6-6d23-54dfc4c2f165@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.