All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails.
Date: Wed, 25 Oct 2017 09:56:00 +0200	[thread overview]
Message-ID: <ca9b3a6e-fa1b-a18a-1fc6-e6b8fb4e446d@linux.intel.com> (raw)
In-Reply-To: <1508896730.10637.15.camel@dk-H97M-D3H>

Op 25-10-17 om 03:36 schreef Pandiyan, Dhinakaran:
> On Wed, 2017-10-11 at 12:28 +0200, Maarten Lankhorst wrote:
>> Op 10-10-17 om 22:12 schreef Chris Wilson:
>>> Quoting Maarten Lankhorst (2017-10-10 17:04:27)
>>>> Make sure read_all_entries has all outputs possible enabled, but also
>>>> add a test that runs with all outputs disabled.
>>>>
>>>> This will maximize coverage of debugfs reading, and allows the test not
>>>> to be dependent on fbcon for setup.
>>>>
>>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> My only argument, but this is just one special case out of many, isn't
>>> really an argument but an endorsement.
>>>
>>> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> -Chris
>> This test seems to cause a failure in igt..
>>
>> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_315/fi-glk-1/igt@debugfs_test@read_all_entries.html
>>
>> Dhinakaran, any idea about the DP crc failure?
>>
>> ~Maarten
>>
> I accidentally reproduced this by reading the CRC debugfs when eDP was
> off (pipe was active as per i915_display_info). Wonder if this is an
> indication that the panel did not really light up in your case. It'd be
> good to see what's happening on the screen if you have physical access
> to the machine.

Never mind, I've tracked it down to the enable sequence, when I enable
the connector butnot the primary plane I get this warning. Once I also
enabled the primary plane in the next version I was able to read a CRC. :)

thanks for the help,
Maarten

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-10-25  7:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 16:04 [PATCH i-g-t 0/2] tests/BAT: Reduce reliance on fbcon Maarten Lankhorst
2017-10-10 16:04 ` [PATCH i-g-t 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails Maarten Lankhorst
2017-10-10 20:12   ` Chris Wilson
2017-10-11 10:28     ` Maarten Lankhorst
2017-10-25  1:36       ` Pandiyan, Dhinakaran
2017-10-25  7:56         ` Maarten Lankhorst [this message]
2017-10-12 10:01     ` [PATCH i-g-t v2 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails, v2 Maarten Lankhorst
2017-10-12 10:47       ` [PATCH i-g-t v3 1/2] tests/debugfs_test: Try to light all outputs to increase chances of finding fails, v3 Maarten Lankhorst
2017-10-12 14:05         ` Chris Wilson
2017-10-10 16:04 ` [PATCH i-g-t 2/2] tests/pm_backlight: Enable all possible outputs to allow tests to succeed Maarten Lankhorst
2017-10-10 16:14   ` Ville Syrjälä
2017-10-10 16:23     ` Maarten Lankhorst
2017-10-11  9:24       ` Ville Syrjälä
2017-10-11  9:25         ` [PATCH i-g-t] tests/pm_backlight: Enable connected output to allow tests to succeed, v2 Maarten Lankhorst
2017-10-12 10:00           ` [PATCH i-g-t v2 2/2] tests/pm_backlight: Enable connected output to allow tests to succeed, v3 Maarten Lankhorst
2017-10-12 10:55             ` [PATCH i-g-t v3 2/2] tests/pm_backlight: Enable connected output to allow tests to succeed, v4 Maarten Lankhorst
2017-10-12 12:29               ` Ville Syrjälä
2017-10-10 19:26 ` ✗ Fi.CI.BAT: warning for tests/BAT: Reduce reliance on fbcon Patchwork
2017-10-11 13:09 ` ✗ Fi.CI.BAT: warning for tests/BAT: Reduce reliance on fbcon. (rev2) Patchwork
2017-10-12 10:28 ` ✗ Fi.CI.BAT: failure for tests/BAT: Reduce reliance on fbcon. (rev4) Patchwork
2017-10-12 11:29 ` ✓ Fi.CI.BAT: success for tests/BAT: Reduce reliance on fbcon. (rev6) Patchwork
2017-10-12 12:56 ` ✗ Fi.CI.IGT: warning " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca9b3a6e-fa1b-a18a-1fc6-e6b8fb4e446d@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.