From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f51.google.com ([209.85.160.51]:33213 "EHLO
        mail-pl0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1423375AbeCBPdZ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 2 Mar 2018 10:33:25 -0500
Received: by mail-pl0-f51.google.com with SMTP id c11-v6so5887841plo.0
        for <netdev@vger.kernel.org>; Fri, 02 Mar 2018 07:33:24 -0800 (PST)
Subject: Re: [PATCH v2 net-next 09/10] net: Remove unused get_hash_from_flow
 functions
To: Ido Schimmel <idosch@idosch.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
        roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
        tom@herbertland.com
References: <20180302032950.21154-1-dsahern@gmail.com>
 <20180302032950.21154-10-dsahern@gmail.com> <20180302140900.GA27478@splinter>
From: David Ahern <dsahern@gmail.com>
Message-ID: <ca9e63c9-73d8-d8be-35e3-48c25eba60d4@gmail.com>
Date: Fri, 2 Mar 2018 08:33:22 -0700
MIME-Version: 1.0
In-Reply-To: <20180302140900.GA27478@splinter>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 3/2/18 7:09 AM, Ido Schimmel wrote:
>> diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
>> index 559db9ea8d86..d29f09bc5ff9 100644
>> --- a/net/core/flow_dissector.c
>> +++ b/net/core/flow_dissector.c
>> @@ -1341,22 +1341,6 @@ __u32 __get_hash_from_flowi6(const struct flowi6 *fl6, struct flow_keys *keys)
>>  }
>>  EXPORT_SYMBOL(__get_hash_from_flowi6);
>>  
>> -__u32 __get_hash_from_flowi4(const struct flowi4 *fl4, struct flow_keys *keys)
> 
> Need to remove the declaration from include/net/flow.h

good catch. I'll add to v3.