All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ray Jui <ray.jui@broadcom.com>
To: Scott Branden <scott.branden@broadcom.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: soc: cygnus: add depends on HAS_DMA
Date: Sat, 8 Oct 2016 13:26:13 -0700	[thread overview]
Message-ID: <caa6a348-9a5f-7f08-ea24-35c3e9d78b31@broadcom.com> (raw)
In-Reply-To: <1475868258-10689-1-git-send-email-scott.branden@broadcom.com>

Hi Scott,

On 10/7/2016 12:24 PM, Scott Branden wrote:
> add depends on HAS_DMA to Kconfig.  This fixes error reported
> by kbuild test robot when building for ARCH=m32r:
> ERROR: "bad_dma_ops" [sound/soc/bcm/snd-soc-cygnus.ko] undefined!
>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> ---
>   sound/soc/bcm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/bcm/Kconfig b/sound/soc/bcm/Kconfig
> index d528aac..edf3671 100644
> --- a/sound/soc/bcm/Kconfig
> +++ b/sound/soc/bcm/Kconfig
> @@ -11,6 +11,7 @@ config SND_BCM2835_SOC_I2S
>   config SND_SOC_CYGNUS
>   	tristate "SoC platform audio for Broadcom Cygnus chips"
>   	depends on ARCH_BCM_CYGNUS || COMPILE_TEST
> +	depends on HAS_DMA
>   	help
>   	  Say Y if you want to add support for ASoC audio on Broadcom
>   	  Cygnus chips (bcm958300, bcm958305, bcm911360)
Looks good to me.

Reviewed-by: Ray Jui <ray.jui@broadcom.com>

  reply	other threads:[~2016-10-08 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 19:24 [PATCH] sound: soc: cygnus: add depends on HAS_DMA Scott Branden
2016-10-08 20:26 ` Ray Jui [this message]
2016-11-01 17:53   ` Scott Branden
2016-11-02 20:22     ` Mark Brown
2016-11-03 15:42 ` Applied "ASoC: bcm: add depends on HAS_DMA" to the asoc tree Mark Brown
2016-11-03 15:42   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=caa6a348-9a5f-7f08-ea24-35c3e9d78b31@broadcom.com \
    --to=ray.jui@broadcom.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=scott.branden@broadcom.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.