* [PATCH] efi/x86: libstub: remove unused variables
@ 2022-09-07 2:32 chen zhang
2022-09-08 8:42 ` Evgeniy Baskov
0 siblings, 1 reply; 6+ messages in thread
From: chen zhang @ 2022-09-07 2:32 UTC (permalink / raw)
To: ardb, baskov, ilias.apalodimas; +Cc: chenzhang_0901, linux-efi, chen zhang
The variable "has_system_memory" is unused in
function ‘adjust_memory_range_protection’, remove it.
Signed-off-by: chen zhang <chenzhang@kylinos.cn>
---
drivers/firmware/efi/libstub/x86-stub.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/firmware/efi/libstub/x86-stub.c b/drivers/firmware/efi/libstub/x86-stub.c
index 05ae8bcc9d67..43ca665af610 100644
--- a/drivers/firmware/efi/libstub/x86-stub.c
+++ b/drivers/firmware/efi/libstub/x86-stub.c
@@ -220,7 +220,6 @@ adjust_memory_range_protection(unsigned long start, unsigned long size)
unsigned long end, next;
unsigned long rounded_start, rounded_end;
unsigned long unprotect_start, unprotect_size;
- int has_system_memory = 0;
if (efi_dxe_table == NULL)
return;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] efi/x86: libstub: remove unused variables
2022-09-07 2:32 [PATCH] efi/x86: libstub: remove unused variables chen zhang
@ 2022-09-08 8:42 ` Evgeniy Baskov
2022-09-08 8:43 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Evgeniy Baskov @ 2022-09-08 8:42 UTC (permalink / raw)
To: chen zhang; +Cc: ardb, ilias.apalodimas, chenzhang_0901, linux-efi
On 2022-09-07 05:32, chen zhang wrote:
> The variable "has_system_memory" is unused in
> function ‘adjust_memory_range_protection’, remove it.
>
Thanks for pointing out.
Will change that in v2.
Thanks,
Evgeniy Baskov
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi/x86: libstub: remove unused variables
2022-09-08 8:42 ` Evgeniy Baskov
@ 2022-09-08 8:43 ` Ard Biesheuvel
2022-09-08 8:48 ` Evgeniy Baskov
0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2022-09-08 8:43 UTC (permalink / raw)
To: Evgeniy Baskov; +Cc: chen zhang, ilias.apalodimas, chenzhang_0901, linux-efi
On Thu, 8 Sept 2022 at 10:42, Evgeniy Baskov <baskov@ispras.ru> wrote:
>
> On 2022-09-07 05:32, chen zhang wrote:
> > The variable "has_system_memory" is unused in
> > function ‘adjust_memory_range_protection’, remove it.
> >
>
> Thanks for pointing out.
> Will change that in v2.
>
v2 of what? Isn't this code already in mainline?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi/x86: libstub: remove unused variables
2022-09-08 8:43 ` Ard Biesheuvel
@ 2022-09-08 8:48 ` Evgeniy Baskov
2022-09-08 8:56 ` Ard Biesheuvel
0 siblings, 1 reply; 6+ messages in thread
From: Evgeniy Baskov @ 2022-09-08 8:48 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: chen zhang, ilias.apalodimas, chenzhang_0901, linux-efi
On 2022-09-08 11:43, Ard Biesheuvel wrote:
> On Thu, 8 Sept 2022 at 10:42, Evgeniy Baskov <baskov@ispras.ru> wrote:
>>
>> On 2022-09-07 05:32, chen zhang wrote:
>> > The variable "has_system_memory" is unused in
>> > function ‘adjust_memory_range_protection’, remove it.
>> >
>>
>> Thanks for pointing out.
>> Will change that in v2.
>>
>
> v2 of what? Isn't this code already in mainline?
Oh, right.
There are just more patches pending that change
that function. I can do that via separate patch later
today, I guess.
Thanks,
Evgeniy Baskov
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi/x86: libstub: remove unused variables
2022-09-08 8:48 ` Evgeniy Baskov
@ 2022-09-08 8:56 ` Ard Biesheuvel
2022-09-08 9:03 ` Evgeniy Baskov
0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2022-09-08 8:56 UTC (permalink / raw)
To: Evgeniy Baskov; +Cc: chen zhang, ilias.apalodimas, chenzhang_0901, linux-efi
On Thu, 8 Sept 2022 at 10:48, Evgeniy Baskov <baskov@ispras.ru> wrote:
>
> On 2022-09-08 11:43, Ard Biesheuvel wrote:
> > On Thu, 8 Sept 2022 at 10:42, Evgeniy Baskov <baskov@ispras.ru> wrote:
> >>
> >> On 2022-09-07 05:32, chen zhang wrote:
> >> > The variable "has_system_memory" is unused in
> >> > function ‘adjust_memory_range_protection’, remove it.
> >> >
> >>
> >> Thanks for pointing out.
> >> Will change that in v2.
> >>
> >
> > v2 of what? Isn't this code already in mainline?
>
> Oh, right.
>
> There are just more patches pending that change
> that function. I can do that via separate patch later
> today, I guess.
>
But Chen Zhang already sent a patch that fixes this, so why bother?
I will queue this as a fix. Please rebase your patches on top if this
causes a conflict.
Thanks,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] efi/x86: libstub: remove unused variables
2022-09-08 8:56 ` Ard Biesheuvel
@ 2022-09-08 9:03 ` Evgeniy Baskov
0 siblings, 0 replies; 6+ messages in thread
From: Evgeniy Baskov @ 2022-09-08 9:03 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: chen zhang, ilias.apalodimas, chenzhang_0901, linux-efi
On 2022-09-08 11:56, Ard Biesheuvel wrote:
>
> But Chen Zhang already sent a patch that fixes this, so why bother?
>
> I will queue this as a fix. Please rebase your patches on top if this
> causes a conflict.
Yes, I meant that I will rebase another series on top of this
change in v2. Sorry for the poor wording. (And not today, I guess)
Thanks,
Evgeniy Baskov
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-08 9:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-07 2:32 [PATCH] efi/x86: libstub: remove unused variables chen zhang
2022-09-08 8:42 ` Evgeniy Baskov
2022-09-08 8:43 ` Ard Biesheuvel
2022-09-08 8:48 ` Evgeniy Baskov
2022-09-08 8:56 ` Ard Biesheuvel
2022-09-08 9:03 ` Evgeniy Baskov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.