All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 1/1] br2-external: Alow to include toolchain from external tree
Date: Sun, 21 Apr 2019 09:30:46 +0200	[thread overview]
Message-ID: <cacfd25b-8a0e-dfe0-185b-2cff5b0d473c@mind.be> (raw)
In-Reply-To: <20190420205404.GC21166@scaer>

 Hi Yann,

On 20/04/2019 22:54, Yann E. MORIN wrote:
> Vadim, Arnout, All,
> 
> Here's my take on the topic (still WIP, but mostly there, needs commit
> log):
> 
>     https://git.buildroot.org/~ymorin/git/buildroot/log/?h=yem/br2-ext-toolchain
> 
> I'll be off until Monday, when I'll write proper commit log before
> submitting it.

 A few comments:

- The rule for internal variables being prefixed by BR_ instead of BR2_ is
written down, in some BR developer days report.

- Bikeshed: call the "dir" variable "outputdir" or something that makes it clear
it's the output.

- For the removal of prepare-kconfig, maybe mention that it reverts
9429e7b698638399ecfd73aa37545594f253a074

- I think it's worth adding a flag that checks if there is any external
toolchain at all, and to put a comment in br2-external.toolchains.in why it is
empty.

 Regards,
 Arnout

  reply	other threads:[~2019-04-21  7:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-17 20:46 [Buildroot] [RFC 1/1] br2-external: Alow to include toolchain from external tree Vadim Kochan
2019-04-17 21:26 ` Arnout Vandecappelle
2019-04-18 14:53   ` Yann E. MORIN
2019-04-19  3:01     ` Vadim Kochan
2019-04-19 21:22       ` Arnout Vandecappelle
2019-04-20 20:54         ` Yann E. MORIN
2019-04-21  7:30           ` Arnout Vandecappelle [this message]
2019-04-21 17:53             ` Yann E. MORIN
2019-04-22  7:09               ` Arnout Vandecappelle
2019-04-22 23:28           ` Vadim Kochan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cacfd25b-8a0e-dfe0-185b-2cff5b0d473c@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.