From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66646C433ED for ; Fri, 2 Apr 2021 20:12:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3691B610C9 for ; Fri, 2 Apr 2021 20:12:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236452AbhDBUMR convert rfc822-to-8bit (ORCPT ); Fri, 2 Apr 2021 16:12:17 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:3067 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbhDBUMR (ORCPT ); Fri, 2 Apr 2021 16:12:17 -0400 Received: from dggeme712-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FBrjG5GD8zWCPG; Sat, 3 Apr 2021 04:08:50 +0800 (CST) Received: from dggemi761-chm.china.huawei.com (10.1.198.147) by dggeme712-chm.china.huawei.com (10.1.199.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Sat, 3 Apr 2021 04:12:13 +0800 Received: from dggemi761-chm.china.huawei.com ([10.9.49.202]) by dggemi761-chm.china.huawei.com ([10.9.49.202]) with mapi id 15.01.2106.013; Sat, 3 Apr 2021 04:12:13 +0800 From: "Song Bao Hua (Barry Song)" To: Jonathan Cameron , "linux-iio@vger.kernel.org" CC: Jonathan Cameron , Alexandre Belloni , "tiantao (H)" Subject: RE: [PATCH 3/7] iio:adc:nau7802: Use IRQF_NO_AUTOEN instead of request then disable Thread-Topic: [PATCH 3/7] iio:adc:nau7802: Use IRQF_NO_AUTOEN instead of request then disable Thread-Index: AQHXJ/CwzVCiYa90gUWgg8+W18Pc2aqhpxDA Date: Fri, 2 Apr 2021 20:12:13 +0000 Message-ID: References: <20210402184544.488862-1-jic23@kernel.org> <20210402184544.488862-4-jic23@kernel.org> In-Reply-To: <20210402184544.488862-4-jic23@kernel.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.202.55] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org > -----Original Message----- > From: Jonathan Cameron [mailto:jic23@kernel.org] > Sent: Saturday, April 3, 2021 7:46 AM > To: linux-iio@vger.kernel.org > Cc: Song Bao Hua (Barry Song) ; Jonathan Cameron > ; Alexandre Belloni > > Subject: [PATCH 3/7] iio:adc:nau7802: Use IRQF_NO_AUTOEN instead of request > then disable > > From: Jonathan Cameron > > Whilst a race during interrupt enabling is probably not a problem, > it is better to not enable the interrupt at all. The new > IRQF_NO_AUTOEN flag allows us to do that. > > Signed-off-by: Jonathan Cameron > Cc: Alexandre Belloni > --- Reviewed-by: Barry Song > drivers/iio/adc/nau7802.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/nau7802.c b/drivers/iio/adc/nau7802.c > index 07c85434b568..bb70b51d25b1 100644 > --- a/drivers/iio/adc/nau7802.c > +++ b/drivers/iio/adc/nau7802.c > @@ -498,7 +498,8 @@ static int nau7802_probe(struct i2c_client *client, > ret = request_threaded_irq(client->irq, > NULL, > nau7802_eoc_trigger, > - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, > + IRQF_TRIGGER_HIGH | IRQF_ONESHOT | > + IRQF_NO_AUTOEN, > client->dev.driver->name, > indio_dev); > if (ret) { > @@ -513,8 +514,7 @@ static int nau7802_probe(struct i2c_client *client, > dev_info(&client->dev, > "Failed to allocate IRQ, using polling mode\n"); > client->irq = 0; > - } else > - disable_irq(client->irq); > + } > } > > if (!client->irq) { > -- > 2.31.1