From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F00FC433E1 for ; Tue, 26 May 2020 15:21:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE41F20787 for ; Tue, 26 May 2020 15:21:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JK3TY57B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE41F20787 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdbOY-0007pb-0s for qemu-devel@archiver.kernel.org; Tue, 26 May 2020 11:21:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdbNZ-0006df-6G for qemu-devel@nongnu.org; Tue, 26 May 2020 11:20:33 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:40833 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jdbNX-0004Ka-Kt for qemu-devel@nongnu.org; Tue, 26 May 2020 11:20:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590506429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=G4nH8AvLe5iivBUjiBQWJ2MtK4CzF0zP0YYeLCuLT6c=; b=JK3TY57Bj4cwxH1O5Pjs/EghGzfG77Ih1aLSLYlFotEjHx6RpmfYaOrbYDZ8wCoxPBeIVo NWQxAAHvl584ZbTnPyC12agVm0vaOW54idwWMd77mhDx2LnJEzP86BiCa7uYwp9aY2+H4D lpIfucJhT8ILjByWtZHevjr+FAAz4Rk= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-sa3op-ygPZmEgMgG8BIxkg-1; Tue, 26 May 2020 11:20:28 -0400 X-MC-Unique: sa3op-ygPZmEgMgG8BIxkg-1 Received: by mail-ed1-f72.google.com with SMTP id o12so9040484edj.12 for ; Tue, 26 May 2020 08:20:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=G4nH8AvLe5iivBUjiBQWJ2MtK4CzF0zP0YYeLCuLT6c=; b=cAvcJNcgqjb3aZm+9Y5YMB/GpAc9hLs/81OPftKVwbXkk2MhL83ZYdCZGl+7oopFB9 vZ/mDfyXlQRUu5NaG0vJgDHjSh4qzI7ACeWEXNg6sR0YN1ECkKYMeXQSwn2mGG8h1MZM T2EdKGy6ahwoQ2t7n64MbXbi5JJ9q3DSaQHpK3RrKbzffm6/rDqaiuKYS86PkK+meOYC jJVCrZ0IdiuGlSibYIg446sO8+lyMmoXQsYnCR1XKU693BIvoKh96NkPzytq27Lhlte/ Rh1UU/1YhEU/iRrV0JQjBmDNSkgAEB9HXd0dACvH2a+aHn+rb7gyaL2hAaJXtnvRIO1l bypg== X-Gm-Message-State: AOAM532UMS1cE8OxWwdQVbr5RFYhe2lZkvwEUOpNf8kjrcCHF3Eqv93T fNDy6PGfSIbGy4Jeo69rFXHVR4xUW5z31ZiwPkUEjGN8fWvd7o46ELbMYYuXOIdAtX/Tq3q82DX 63R6MyKRFVWSopiY= X-Received: by 2002:a50:c906:: with SMTP id o6mr16944754edh.95.1590506426880; Tue, 26 May 2020 08:20:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQlCYehqml8MajuAlgzZLtsrzr7qNPOaEXYNdL9PdlNeB+iLFzHNCbq47YsYO+VkR6rNhsuA== X-Received: by 2002:a50:c906:: with SMTP id o6mr16944727edh.95.1590506426691; Tue, 26 May 2020 08:20:26 -0700 (PDT) Received: from [192.168.1.36] (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id w12sm197244edj.22.2020.05.26.08.20.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 08:20:26 -0700 (PDT) Subject: Re: [PATCH 6/7] block/nvme: keep BDRVNVMeState pointer in NVMeQueuePair From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: Stefan Hajnoczi , qemu-devel@nongnu.org References: <20200519171138.201667-1-stefanha@redhat.com> <20200519171138.201667-7-stefanha@redhat.com> Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Tue, 26 May 2020 17:20:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=philmd@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/26 01:19:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/26/20 4:55 PM, Philippe Mathieu-Daudé wrote: > On 5/19/20 7:11 PM, Stefan Hajnoczi wrote: >> Passing around both BDRVNVMeState and NVMeQueuePair is unwiedly. Reduce Oh, and typo "unwieldy". >> the number of function arguments by keeping the BDRVNVMeState pointer in >> NVMeQueuePair. This will come in handly when a BH is introduced in a >> later patch and only one argument can be passed to it. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> block/nvme.c | 70 ++++++++++++++++++++++++++++------------------------ >> 1 file changed, 38 insertions(+), 32 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé >