From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F394C433EF for ; Sun, 2 Jan 2022 09:41:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EFDE28111F; Sun, 2 Jan 2022 10:41:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="Q0cGlXdr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B80D0811AC; Sun, 2 Jan 2022 10:41:46 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D99BA801EB for ; Sun, 2 Jan 2022 10:41:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1641116502; bh=eDIrASL1cPTRvCjPpmSfBaSBdMMN+jaDgcOp9TZDe2w=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Q0cGlXdrws0SWTH6JA2ilHeOSdoeXvKZLDDodgAYLspv6pGAKw5e9gPdu91fL2QCE zc65K7mbEvgp+Xd1lMcSm3/CZ4fteVrmYCoT3msG7+ysoN61LNgTsM7FMJoFQ/bq39 xNYb2ArOD00bf95c/OHRcJke42ZRT9EiWq/RSzEU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.94] ([88.152.144.157]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4hzZ-1mNN0j123j-011lbC; Sun, 02 Jan 2022 10:41:42 +0100 Message-ID: Date: Sun, 2 Jan 2022 10:41:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC v2 11/20] dm: add event notification Content-Language: en-US To: AKASHI Takahiro Cc: masami.hiramatsu@linaro.org, u-boot@lists.denx.de, agraf@csgraf.de, sjg@chromium.org, ilias.apalodimas@linaro.org References: <20211210064947.73361-1-takahiro.akashi@linaro.org> <20211210064947.73361-12-takahiro.akashi@linaro.org> From: Heinrich Schuchardt In-Reply-To: <20211210064947.73361-12-takahiro.akashi@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:fl2h24+AG5t9bdBjd73Tk7YDb2JbE+XXFVw9csZLBTnFwM7k9ET 36erKKt1siC4sp1HuUPEVATXo9yWd7X1FBvrOsiVP+nJLQJYCFwQm9eprj1CIeyB/nH1y/5 11LlCDyJ3Tlpr8z9wJiTtnDsMhklNK+yEsNeCP3YJc2DVLfBUK6lUOhQlrMesPVnWsslMfV NfDP7NC23U/WiS0UkRxlA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Dhyl1SX0aHg=:tOUJGCjFUxjgFrtW8f/KW6 GDs5CUZolxNwQTyjYwtO6UnrDDtwKHGW4HY0BnujkOO9eqhCIv4N4TElbcs98fyDoBFUQHaJF DANAEKp85eoIAejcE32ZWYnSB8a7DqcEe7SBv3o+uyA4FFZ7bTkpBsW+avjnBp9wRVsttk7Y+ g0mKV3jswwAJwUcwJukeDom0P62hZhcs8+UM8R7xMs92pkH1EETyJCs19aJxhgMxn5ktIbR3Y ywExHsb1j2c2IxsRaeer418cQKrK4Bms0eTmPXPKH4xj68sQi+Si8plKMJ5brz5JuWr5q5T1b eeFkD0PwN4xOfQKkE12YwUon03iiCx82JT5cRgkoPDleq5CmT67WMnn28QWvCpOkE0mYha/u/ ee1QjziF0I5j1LRSK583RrVQGl1HWLs8SfJvXQT6f2rAmVYz1u/kf1E8N46HVFvrPHYYOApkB N120tFndtGo4fFzdvXiXgAR5Jt33qWp83KCx75hPMxizYy8GIvCE/T4riJTFZRI+rcY6J+7F2 UNQkmk/NL8CehyOL0jwXcAYF60pM3NYR1bfXSbXRBB9xJnV7AD8VM2T72j5TTclLvQj88dfEY wsWJSpyoUWGI2j3qsh9feQMLAFKDKLrglYFZTSbqaVQelldfpmYHT3mMa0T3sSjhW+sQV4kkd 2z1EP9UI723HztvWoVa4qHp4OpYUAwsTGOygqRdxnHwLpn55/KIoAub/M/qd+yhM7WqzOVpys a1dc5N9UgUhCcbnSh8lNRTi0gB93xAXmwK0zYGlizz5y/nBXWp5m5jWrhTR6p3NCgy2cXQKwJ bBIHiCN9pYzBnahaybC418uomGrTUU7S1mm1IeK2yPGogOh85s82PxPGwL5pbOuHET9SWD4uV g+37yuVEwq24SOemevA0TgdjuvxnBVCYjyAQ7MTlBtuuKGhkBHZ9yTzyB+S87oLHEyUvBewEK I6D8lE9S0RG4seS00ODL30OF/0i+ZcpuigMwYZC49+sDDwE7n3nPt9Un8wcMwsRiUSinRAvhY sKMGEdb6DyOVgmP9Zbq4HMmyFdK/prSoijwJRseE9gUqPVItvFQnE8qBzDUo1geCQqKLJglSd i9Wpcs4nJO6cFc= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 12/10/21 07:49, AKASHI Takahiro wrote: > From: Simon Glass > > This is a draft implementation of event notification mechanism from Simo= n. > Under this scheme, any U-Boot subsystem can register some kind of callba= ck > function to a particular event (more event types will be added later) an= d > that function will be invoked once the event is fired. > > As a first user, UEFI subsystem makes use of PROBE and REMOVE events so > that we will be able to automatically create/remove efi_disk objects > relying on associated block devices (UCLASS_BLK). > > To run the test: > ./u-boot -T -c "ut common test_event_probe" > > Signed-off-by: Simon Glass > [add REMOVE event; fix checkpatch warnings] > Signed-off-by: AKASHI Takahiro This patch breaks building sandbox_spl_defconfig. common/event.c: In function =E2=80=98event_register=E2=80=99: common/event.c:29:39: error: =E2=80=98gd_t=E2=80=99 {aka =E2=80=98struct g= lobal_data=E2=80=99} has no member named =E2=80=98event_state=E2=80=99 29 | struct event_state *state =3D gd->event_state; | ^~ common/event.c: In function =E2=80=98event_notify=E2=80=99: common/event.c:47:39: error: =E2=80=98gd_t=E2=80=99 {aka =E2=80=98struct g= lobal_data=E2=80=99} has no member named =E2=80=98event_state=E2=80=99 47 | struct event_state *state =3D gd->event_state; | ^~ common/event.c: At top level: common/event.c:77:5: error: redefinition of =E2=80=98event_uninit=E2=80=99 77 | int event_uninit(void) | ^~~~~~~~~~~~ In file included from common/event.c:13: include/event.h:94:19: note: previous definition of =E2=80=98event_uninit= =E2=80=99 with type =E2=80=98int(void)=E2=80=99 94 | static inline int event_uninit(void) | ^~~~~~~~~~~~ common/event.c: In function =E2=80=98event_uninit=E2=80=99: common/event.c:79:39: error: =E2=80=98gd_t=E2=80=99 {aka =E2=80=98struct g= lobal_data=E2=80=99} has no member named =E2=80=98event_state=E2=80=99 79 | struct event_state *state =3D gd->event_state; | ^~ common/event.c: At top level: common/event.c:90:5: error: redefinition of =E2=80=98event_init=E2=80=99 90 | int event_init(void) | ^~~~~~~~~~ In file included from common/event.c:13: include/event.h:99:19: note: previous definition of =E2=80=98event_init=E2= =80=99 with type =E2=80=98int(void)=E2=80=99 99 | static inline int event_init(void) | ^~~~~~~~~~ common/event.c: In function =E2=80=98event_init=E2=80=99: common/event.c:100:11: error: =E2=80=98gd_t=E2=80=99 {aka =E2=80=98struct = global_data=E2=80=99} has no member named =E2=80=98event_state=E2=80=99 100 | gd->event_state =3D state; | ^~ make[2]: *** [scripts/Makefile.build:254: spl/common/event.o] Error 1 make[1]: *** [scripts/Makefile.spl:515: spl/common] Error 2 make[1]: *** Waiting for unfinished jobs.... AR spl/env/built-in.o AR spl/common/spl/built-in.o test/test-main.c: In function =E2=80=98test_pre_run=E2=80=99: test/test-main.c:222:11: error: =E2=80=98gd_t=E2=80=99 {aka =E2=80=98struc= t global_data=E2=80=99} has no member named =E2=80=98event_state=E2=80=99 222 | gd->event_state =3D NULL; | ^~ make[2]: *** [scripts/Makefile.build:253: spl/test/test-main.o] Error 1 make[2]: *** Waiting for unfinished jobs.... AR spl/test/image/built-in.o make[1]: *** [scripts/Makefile.spl:515: spl/test] Error 2 make: *** [Makefile:2086: spl/u-boot-spl] Error 2 Best regards Heinrich