From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqm3i-0002Km-Bp for qemu-devel@nongnu.org; Tue, 27 Feb 2018 15:41:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqm3h-0003Yf-EA for qemu-devel@nongnu.org; Tue, 27 Feb 2018 15:41:10 -0500 References: <20180223235142.21501-1-jsnow@redhat.com> <20180223235142.21501-21-jsnow@redhat.com> From: John Snow Message-ID: Date: Tue, 27 Feb 2018 15:41:06 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC v4 20/21] iotests: test manual job dismissal List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: kwolf@redhat.com, pkrempa@redhat.com, jtc@redhat.com, qemu-devel@nongnu.org On 02/27/2018 03:21 PM, Eric Blake wrote: > On 02/23/2018 05:51 PM, John Snow wrote: >> Signed-off-by: John Snow >> --- >> =C2=A0 tests/qemu-iotests/056=C2=A0=C2=A0=C2=A0=C2=A0 | 195 >> +++++++++++++++++++++++++++++++++++++++++++++ >> =C2=A0 tests/qemu-iotests/056.out |=C2=A0=C2=A0 4 +- >> =C2=A0 2 files changed, 197 insertions(+), 2 deletions(-) >> >=20 > I'm not sure if this covers everything in the series, but it looks like It definitely doesn't! > a reasonable expansion and hits a lot of the highlights.=C2=A0 At any r= ate, > it's always better to add tests, and the test passing is a good bet tha= t > the new code will be harder to regress. >=20 More to follow, but I was afraid of wasting time if this series didn't look on the whole serviceable. I'll probably focus efforts on expanding blockjob-txn and blockjob unit tests. > Reviewed-by: Eric Blake >=20