From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH 02/32] drivers/common: introducing dpaa2 mc driver Date: Mon, 19 Dec 2016 20:53:28 +0530 Message-ID: References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1480875447-23680-3-git-send-email-hemant.agrawal@nxp.com> <20161217095535.GA25710@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , , , , Cristian Sovaiala To: Jerin Jacob Return-path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0052.outbound.protection.outlook.com [104.47.33.52]) by dpdk.org (Postfix) with ESMTP id B4D44FA3A for ; Mon, 19 Dec 2016 16:23:40 +0100 (CET) In-Reply-To: <20161217095535.GA25710@localhost.localdomain> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/17/2016 3:25 PM, Jerin Jacob wrote: > On Sun, Dec 04, 2016 at 11:46:57PM +0530, Hemant Agrawal wrote: >> This patch intoduces the DPAA2 MC(Management complex Driver) >> >> This driver is common to be used by various DPAA2 net, crypto >> and other drivers >> >> Signed-off-by: Cristian Sovaiala >> [Hemant:rebase and conversion to library for DPDK] >> Signed-off-by: Hemant Agrawal >> >> include $(RTE_SDK)/mk/rte.vars.mk >> >> +DIRS-y += common >> DIRS-y += net >> DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto >> >> diff --git a/drivers/common/Makefile b/drivers/common/Makefile >> new file mode 100644 >> index 0000000..0c3f35f >> --- /dev/null >> +++ b/drivers/common/Makefile >> @@ -0,0 +1,36 @@ >> +# BSD LICENSE >> +# >> +# Copyright(c) 2016 NXP. All rights reserved. >> +# All rights reserved. >> +# >> +# Redistribution and use in source and binary forms, with or without >> +# modification, are permitted provided that the following conditions >> +# are met: >> +# >> +# * Redistributions of source code must retain the above copyright >> +# notice, this list of conditions and the following disclaimer. >> +# * Redistributions in binary form must reproduce the above copyright >> +# notice, this list of conditions and the following disclaimer in >> +# the documentation and/or other materials provided with the >> +# distribution. >> +# * Neither the name of NXP nor the names of its >> +# contributors may be used to endorse or promote products derived >> +# from this software without specific prior written permission. >> +# >> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS >> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR >> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT >> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, >> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT >> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, >> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY >> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT >> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE >> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> + >> +include $(RTE_SDK)/mk/rte.vars.mk >> + >> +DIRS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += dpaa2 > > If you are planning to build "external pool" driver or "eventdev" driver or net > pmd driver as stand alone build then you could try generating the config for > common code by selection of "external pool" or "eventdev" or net-pmd driver. > something like below > > CONFIG_RTE_LIBRTE_OCTEONTX_COMMON = $(CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF) > ifneq ($(CONFIG_RTE_LIBRTE_OCTEONTX_COMMON),y) > CONFIG_RTE_LIBRTE_OCTEONTX_COMMON = > $(CONFIG_RTE_LIBRTE_MEMPOOL_OCTEONTX_FPAVF) > endif > ifneq ($(CONFIG_RTE_LIBRTE_OCTEONTX_COMMON),y) > CONFIG_RTE_LIBRTE_OCTEONTX_COMMON = $(CONFIG_RTE_LIBRTE_PMD_OCTEONTX) > endif > > DIRS-$(CONFIG_RTE_LIBRTE_OCTEONTX_COMMON) += octeontx > > > Thanks for the suggestion. I have tried it in the V2. I am still having issue when using shared compilation, currently I am not able to specify another driver in the DEPDIR