From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752334AbcGAHd0 (ORCPT ); Fri, 1 Jul 2016 03:33:26 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36592 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbcGAHdY (ORCPT ); Fri, 1 Jul 2016 03:33:24 -0400 Subject: Re: [PATCH v1 03/11] KVM: x86: dynamic kvm_apic_map To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20160630205429.16480-1-rkrcmar@redhat.com> <20160630205429.16480-4-rkrcmar@redhat.com> Cc: "Lan, Tianyu" , Igor Mammedov , Jan Kiszka , Peter Xu From: Paolo Bonzini Message-ID: Date: Fri, 1 Jul 2016 09:33:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160630205429.16480-4-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/06/2016 22:54, Radim Krčmář wrote: > x2APIC supports up to 2^32-1 LAPICs, but most guest in coming years will > have slighly less VCPUs. Dynamic size saves memory at the cost of > turning one constant into a variable. > > apic_map mutex had to be moved before allocation to avoid races with cpu > hotplug. > > Signed-off-by: Radim Krčmář It's important to note another change here, which is that you start using the phys_map for x2apic clustered mode. It's so important that you could make it a separate patch while keeping the phys_map static! :) Paolo