All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tools: xilinx: Fix zynq/zynqmp image recognition
Date: Fri, 16 Mar 2018 11:39:49 +0100	[thread overview]
Message-ID: <cb1ecdc1-872a-2d61-06f2-85bcfac3abd1@xilinx.com> (raw)
In-Reply-To: <A1DEBC32-B492-4B9C-9B59-2B5197A16E40@suse.de>

On 16.3.2018 11:33, Alexander Graf wrote:
> 
> 
>> Am 16.03.2018 um 11:22 schrieb Michal Simek <michal.simek@xilinx.com>:
>>
>>> On 15.3.2018 22:54, Alexander Graf wrote:
>>>
>>>
>>>> On 14.03.18 11:14, Michal Simek wrote:
>>>> There is an issue to recognize zynq or zynqmp image because header
>>>> checking is just the same. That's why zynqmp images are recognized as
>>>> zynq one.
>>>> Check unused fields which are initialized to zero in zynq format
>>>> (__reserved1 0x38 and __reserved2 0x44) which are initialized for
>>>> zynqmp. This should ensure that images are properly recognized by:
>>>> ./tools/mkimage -l spl/boot.bin
>>>>
>>>> Also show image type as ZynqMP instead of Zynq which is confusing
>>>> and parse a53 64bit cpu select option in image_attributes field to make
>>>> sure that this is ZynqMP image.
>>>
>>> What if the target is on R5?
>>
>> I expect you know the answer. I have ported u-boot on R5 which could use
>> this feature but mkimage is not prepared for that.
>>
>> I am happy to remove this zynqmp detection code because it should be
>> enough what it is done for zynq. Just let me know if you want to remove it.
> 
> Yes, please :).

v2 sent with this.

> 
>>
>>>
>>>> Reported-by: Alexander Graf <agraf@suse.de>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>
>>> Tested-by: Alexander Graf <agraf@suse.de>
>>
>> It is question how exactly you want to use mkimage tools. If for u-boot
>> generated images or for generic boot.bin generated by bootgen.
> 
> I think it makes sense to converge the two mechanisms. I want to be able to swap individual components between the two; use fsbl with mkimage and spl with bootgen. I don‘t think we‘re very far from that.

You can do it now without any issue. Bootgen expects files with elf
suffix which is not needed for mkimage.

> 
> Alternatively Xilinx could open source bootgen and we could just use that always ;).

Not my decision.

Thanks,
Michal

      reply	other threads:[~2018-03-16 10:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 10:14 [U-Boot] [PATCH] tools: xilinx: Fix zynq/zynqmp image recognition Michal Simek
2018-03-15 21:54 ` Alexander Graf
2018-03-16 10:22   ` Michal Simek
2018-03-16 10:33     ` Alexander Graf
2018-03-16 10:39       ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb1ecdc1-872a-2d61-06f2-85bcfac3abd1@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.