From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BFDFC11F64 for ; Thu, 1 Jul 2021 08:42:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49FA761468 for ; Thu, 1 Jul 2021 08:42:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235535AbhGAIpU (ORCPT ); Thu, 1 Jul 2021 04:45:20 -0400 Received: from mail-eopbgr80110.outbound.protection.outlook.com ([40.107.8.110]:49811 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235336AbhGAIpS (ORCPT ); Thu, 1 Jul 2021 04:45:18 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k1dJM18FVXPrV/AdOtdXxRzmF6pjJv5fjkulzPog0cnWpIwjSp9CGBQta88Hd3UssfKId8IKRBY9xRu1/lWg88wEaVmdKZUOsiuV7vQXJqgHyez+etPw3MFEP4DpAvBnAhQKXfonZGml7vG3MjKWx+HBmt5mwMRbqAI2Vio1ZG8QcGo9KUc2MpkmeFFjXba+DQabDhCvuESICGTnPVdHrBkFEYJLG2xVa3IOUcumiE8U67F2ZOiQIlML7ZONZ5JQs8H9PNiUKm4IRVA6d6mVpdV9DDeZZjfl3Gi7M9KmuMDPuBspVTCCF7H81Ag1SmNzGNBOIlSTEtlgFIEv9m667A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFkEaVDJP3tOyKg6pZTHwWeqOiJpx+1RQQKpLRg2IUY=; b=NDPpyEzjBnNlkBL5JZml05Rk8uEFoyBudNMzKQoajFX1TjMfKIIqtb2xQH0gta8X0RT4o0i6kMAQS2n8SyvBTEO1tcpAsnJqf1ySnvp1WyCU6llkiq/EoWHdJGBi+XeG/ra8My7OOggRMLzWnk0FRrQkXbY1AK2oHkZ+DPT2eB9h8Q3S7XAGq555FbB4cMD9UJRK0Dg3BwZFI5EiaQmEv8PvK6bnJICvR88D7ZX7iHWX7vSIOp1Ai3G26HpB3g7jE/dSoH576YNNOX2qIPNajIyGi5JwDrtU58ZIDZiHu0LYG/Cr4vrYYGN+6EANEiIszxZCJte5tfwMFvnMy8j1BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=opensynergy.com; dmarc=pass action=none header.from=opensynergy.com; dkim=pass header.d=opensynergy.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=opensynergy.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFkEaVDJP3tOyKg6pZTHwWeqOiJpx+1RQQKpLRg2IUY=; b=F5+JJ2PgNZVhOM4lEQNf38rKUzi4QLxE9xjUulyVAnhwgHlbLTYrjMU5LTTEjkAXOC4QFxpByJ4LkCQBZ17yukHeA1ANCtkH6oxFpDgE2uiRx08NHW4588XGvzH2rSmvI57ty/KEwk5xknZebVkyhYBIVJGhlJs53XXmBhpYUfI= Authentication-Results: opensynergy.com; dkim=none (message not signed) header.d=none;opensynergy.com; dmarc=none action=none header.from=opensynergy.com; From: Peter Hilber To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com References: <20210611165937.701-1-cristian.marussi@arm.com> <20210611165937.701-2-cristian.marussi@arm.com> Subject: Re: [PATCH v4 01/16] firmware: arm_scmi: Fix max pending messages boundary check Message-ID: Date: Thu, 1 Jul 2021 10:42:40 +0200 In-Reply-To: <20210611165937.701-2-cristian.marussi@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR01CA0061.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::38) To AM9PR04MB8084.eurprd04.prod.outlook.com (2603:10a6:20b:3ec::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d6f2880-dabb-4a4a-83b4-08d93c6c3076 X-MS-TrafficTypeDiagnostic: AM0PR04MB5028: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f9/PEQemoLVLrVIOuDC7GN7XA7yuaovanxIkITkCuTNiKMWpA4qpL5aVBqeXZ5jdkB0QJsJA5pOxXkQoMljFHl11UhXwm7y589auqfw9W4E52lIeuFaj289fcCTy04WN2HNNYm/ZKI5TcqxsV+IQhdmfwL8q1h0D9iGNmCH1ksggl0upre9c4L+pNRxxUioWmEV9INSjF5M7Innpe56wBFNDBNgs7EhEnziTV5jOS1NJdm8am1lf7hGThYNaNwmUrjRw/DXElEQQRd41TDi9id8zToFPxYFGq4qOpOZybmZHKSUd+uDrxlWSwfuX8diL+vLqb9uJza16ocLdFDZGWPpdBg05G+DCvYbPbO2bJ/d4bBH3tIaI/fhUsOjhTU6BTfD43Wtfb5hrN309U+1+KjNISqKztXjB82Ku/H9ZWteWdCcG1uMoaomwIG5LbYm9FiPUOwQ0XZ9and2dXSxDr0eD0fN1+Omg1rm9JFb/Qs78UWL4GLe+6GzmBWmnDQwlmpkaFgDIqL6ctKdwGkpAr6dve0RSnUuYVfqBySy2BOtJcveTi7iGmvC1XblPfS2/nzaaJLFfP/zaIgoM/WcQJ1+NzSYOw32ZrBbmhXRSX7PC2Dmst0Wsf+Br517zV0lE7ogVFeFaTibHR5LRg28Ufg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8084.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(39830400003)(396003)(366004)(346002)(376002)(136003)(36756003)(186003)(83380400001)(53546011)(66946007)(86362001)(31686004)(15650500001)(31696002)(42186006)(478600001)(2906002)(316002)(8936002)(8676002)(7416002)(66556008)(2616005)(66476007)(4326008)(107886003)(38100700002)(5660300002)(44832011);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3JvSjMrYXAwZmJ5alpVWHdBVUg0Q3I1ZUNOV21xbm9wZm9zUGg3TGRJdHUv?= =?utf-8?B?TFAwdjhEMzR3QjBnWnY0aXdKTVR5dnlPcE5NKzdtcHBSYjBETW1SbHVycS80?= =?utf-8?B?RkFrMlRXanBhaWdRUHRaenBpY0xRYkxlNWY1SVNiZ25xYTMxV0xRSk9EcnlQ?= =?utf-8?B?NjNqSnhwOEtGbnRWWTlZOEpqN3lEZENmS1o4dEkwRFhUcWlyNnZzWVBISy8w?= =?utf-8?B?WUNuZmd1cURrbFRDc0wzQjhTd2o0Z1hTTFJCUnBLOVJFQnVJOE5XdDJzTHI1?= =?utf-8?B?bzN0ZVVUUVVYVnRuTGFOaEdqaEV5Z2crQzYyVDRjWEFOS2JqWkQrS1VwbFFx?= =?utf-8?B?VFRaTWN4d1habTdLSDcwcVhZaFQvYURNVHdsMVEyODNmOTZ2S3lneXJDeUox?= =?utf-8?B?ZWR0QTJTSFJYSkIwMFdyY2wvb1ZGMlNqdlViWW0vcy92aitjaW1YMlpjcEsy?= =?utf-8?B?RGlQS0ZONVJTQTVRdG9ueHJQVloxdi9KZXBFc0pCaUtUZ0NtTVZSM1ozdGZ0?= =?utf-8?B?YytiVmFBd0V4WEI1ejlHSFF0S3lEdFl3dk10ZmZxWDdHT0FEVFJLSEorQlNJ?= =?utf-8?B?WmdxVkJISzAyaVlBb0JHQWxVaVBkcG9sdUczOExmVCthYWJZM21tVlBldFdW?= =?utf-8?B?V0VXd1hyYk9QLzh6RjlON1VCd05MTTd3aS9uZGs3NGxVMXpsdWt5QXpXMHRV?= =?utf-8?B?TTJRSFVqOW5MUEc3bkE3aE8rNnJEd3hBSFkyc2dsK290OW9VQldIQndTbktY?= =?utf-8?B?allXemJiaHhSenI1TjVBbSt5dGUwbmVLaGZab2YrNUpUV3M2MklvRzZxRVZM?= =?utf-8?B?ckZWb0pRNVQzL0tZc2kydHZDakhDMHBtQ3pJUHNBU2FlbDF4WS8xc3lYWHFk?= =?utf-8?B?R1dDc09hWk1HdmluWUwyY3pRZ3NWUWlaa3NzaXA0OThFbVZ4VElocHgyY3Zu?= =?utf-8?B?cE9RaURiTElWaDRPRlcxZkluQjVIVFFjc1BmQjJLbGtrSzFQcGlBZCtFQTdJ?= =?utf-8?B?K1hqZUd6UWowbFROc3BiZU5TRmVTV3JPaERpN3dwcFdnN3AybzJIZVN2d09N?= =?utf-8?B?Sk9oaC9lczE2cXFmVUl0anJCUHI5T3c0Mkw2OXVrZGNIRkNVUm5tRzRKRlVz?= =?utf-8?B?T3JNWVJxcGl6RkhBR1RGTnlyWEIvM1pmaWhYdGtsYUFNS1AyelN0Ujd3T0lW?= =?utf-8?B?enh6U3dxV1VIV0dhakxyS0Q4UzN2MUphUjRLTUwvMTUwOFV0Qm9RWkJrbEZn?= =?utf-8?B?RWFqYzJHUng2WDV5c2RCeVJ3V2VIRDB5WGhmSVNMdVoxL3VsNC9hNXQ0NUoy?= =?utf-8?B?QnhsNk9jNUlNUWhBZWkyVjNuck54UFV6eVBCUnlSRDNvMTJpSkV0TndZQUJ2?= =?utf-8?B?VXphQWZVQmJVZytBWEFOUDUzY3JpTW45endIMG9PRWhWY2xOTkkwbHFuR3Jz?= =?utf-8?B?cjRsNk9aeVZWVGk0YXVCTEhVSUs5ajRPNDFoTXJJUVNSd3ZDSDJscUc5NTJw?= =?utf-8?B?WXRqY2ZVcmRUL1Y3LzY3RHllSHdxYkFHZzBuRUVUa0JDdUdNWHFQdzVCcTlU?= =?utf-8?B?T0FGSkZPYU9SU0NDVnk3eUNXNUxRQ21raVBwVnNERFlnY1ZLV1RVUTFndldJ?= =?utf-8?B?M0RaMldnK3BIRXlMT2JaSXFrNTR5TVBnRU9tMm42cXNBVCtiNEdDRFRxZStw?= =?utf-8?B?QzFZdGJGcHRiUHo4VnRJSTAySWpUNWZadEpIL3gwdTRFODRxTzZvY3FyaldF?= =?utf-8?B?TGVxWmQwQVFiTlZqeHBPekdrMk90cWsyR0JTUmRwK0RkS1RxMGR5SnFzR1RP?= =?utf-8?B?MjJ4Mk05elowbXNWdlA0d0trbnRJc3ZrMWdKRVJDOXllc2xCQnE5akE3SnN6?= =?utf-8?Q?ahUnetoVNXJ/h?= X-OriginatorOrg: opensynergy.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6f2880-dabb-4a4a-83b4-08d93c6c3076 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8084.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 08:42:42.1543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hgrtIDj8Q01VgOQrd4BGWN816NeFsx+9gt+3zfVf+MO86QbiXwl8dMqf/idLNqm+WWefYreMHnYughoy6/u9Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5028 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cristian, please find some remarks to the patch series in this email and the following. On 11.06.21 18:59, Cristian Marussi wrote: > SCMI message headers carry a sequence number and such field is sized to > allow for MSG_TOKEN_MAX distinct numbers; moreover zero is not really an > acceptable maximum number of pending in-flight messages. > > Fix accordignly the checks performed on the value exported by transports > in scmi_desc.max_msg. > > Reported-by: Vincent Guittot > Fixes: aa4f886f3893 ("firmware: arm_scmi: add basic driver infrastructure for SCMI") > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/driver.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 66e5e694be7d..6713b259f1e6 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -1025,8 +1025,9 @@ static int __scmi_xfer_info_init(struct scmi_info *sinfo, > const struct scmi_desc *desc = sinfo->desc; > > /* Pre-allocated messages, no more than what hdr.seq can support */ > - if (WARN_ON(desc->max_msg >= MSG_TOKEN_MAX)) { > - dev_err(dev, "Maximum message of %d exceeds supported %ld\n", > + if (WARN_ON(!desc->max_msg || desc->max_msg > MSG_TOKEN_MAX)) { > + dev_err(dev, > + "Invalid max_msg %d. Maximum messages supported %ld.\n", %ld -> %lu > desc->max_msg, MSG_TOKEN_MAX); > return -EINVAL; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25764C11F64 for ; Thu, 1 Jul 2021 09:02:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0E5E61476 for ; Thu, 1 Jul 2021 09:01:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0E5E61476 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=opensynergy.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date:Message-ID:Subject: References:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2+HGvD2vDvmDz/SY8jSkBXVwcipT0/LORnKgRVKA3pU=; b=wrydvwfLgO884Bm9wVHEEfECxg TrAZtHFXfSjslV4QnVdMPfwFN02EMP2K0RIKf4IJQLq7wgVJZOnNuzR5MhSxgOCCedE3QEz2QLqrX RmN0WjjJ4GVeJWDnDBMIa1yBcbq9HBRCkMbl4DBrgs+B7mhYmY4FKWcHUKmRvNts3GtGhSoGOjDVg 9bf2F0mjpDWJXnyJv3Rh3bI6b6U+gYt4SDWm+LG3LLOkmeWRfTT0zfJ3fY3iFFsd1HUzQb8JbJLvt uQvJhC1WgesDc5OZ37X9S5DV153eUx8A53pNj2IRFcO+IclMu05fOUZLtkdEMtloYHkJbhKCqO0o5 qwLLqh8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lysXr-00GbvK-TK; Thu, 01 Jul 2021 08:59:40 +0000 Received: from mail-eopbgr60127.outbound.protection.outlook.com ([40.107.6.127] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lysWx-00GbWt-4O for linux-arm-kernel@lists.infradead.org; Thu, 01 Jul 2021 08:58:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k1dJM18FVXPrV/AdOtdXxRzmF6pjJv5fjkulzPog0cnWpIwjSp9CGBQta88Hd3UssfKId8IKRBY9xRu1/lWg88wEaVmdKZUOsiuV7vQXJqgHyez+etPw3MFEP4DpAvBnAhQKXfonZGml7vG3MjKWx+HBmt5mwMRbqAI2Vio1ZG8QcGo9KUc2MpkmeFFjXba+DQabDhCvuESICGTnPVdHrBkFEYJLG2xVa3IOUcumiE8U67F2ZOiQIlML7ZONZ5JQs8H9PNiUKm4IRVA6d6mVpdV9DDeZZjfl3Gi7M9KmuMDPuBspVTCCF7H81Ag1SmNzGNBOIlSTEtlgFIEv9m667A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFkEaVDJP3tOyKg6pZTHwWeqOiJpx+1RQQKpLRg2IUY=; b=NDPpyEzjBnNlkBL5JZml05Rk8uEFoyBudNMzKQoajFX1TjMfKIIqtb2xQH0gta8X0RT4o0i6kMAQS2n8SyvBTEO1tcpAsnJqf1ySnvp1WyCU6llkiq/EoWHdJGBi+XeG/ra8My7OOggRMLzWnk0FRrQkXbY1AK2oHkZ+DPT2eB9h8Q3S7XAGq555FbB4cMD9UJRK0Dg3BwZFI5EiaQmEv8PvK6bnJICvR88D7ZX7iHWX7vSIOp1Ai3G26HpB3g7jE/dSoH576YNNOX2qIPNajIyGi5JwDrtU58ZIDZiHu0LYG/Cr4vrYYGN+6EANEiIszxZCJte5tfwMFvnMy8j1BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=opensynergy.com; dmarc=pass action=none header.from=opensynergy.com; dkim=pass header.d=opensynergy.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=opensynergy.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFkEaVDJP3tOyKg6pZTHwWeqOiJpx+1RQQKpLRg2IUY=; b=F5+JJ2PgNZVhOM4lEQNf38rKUzi4QLxE9xjUulyVAnhwgHlbLTYrjMU5LTTEjkAXOC4QFxpByJ4LkCQBZ17yukHeA1ANCtkH6oxFpDgE2uiRx08NHW4588XGvzH2rSmvI57ty/KEwk5xknZebVkyhYBIVJGhlJs53XXmBhpYUfI= Authentication-Results: opensynergy.com; dkim=none (message not signed) header.d=none;opensynergy.com; dmarc=none action=none header.from=opensynergy.com; From: Peter Hilber To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com References: <20210611165937.701-1-cristian.marussi@arm.com> <20210611165937.701-2-cristian.marussi@arm.com> Subject: Re: [PATCH v4 01/16] firmware: arm_scmi: Fix max pending messages boundary check Message-ID: Date: Thu, 1 Jul 2021 10:42:40 +0200 In-Reply-To: <20210611165937.701-2-cristian.marussi@arm.com> Content-Language: en-US X-ClientProxiedBy: AM6PR01CA0061.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::38) To AM9PR04MB8084.eurprd04.prod.outlook.com (2603:10a6:20b:3ec::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d6f2880-dabb-4a4a-83b4-08d93c6c3076 X-MS-TrafficTypeDiagnostic: AM0PR04MB5028: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f9/PEQemoLVLrVIOuDC7GN7XA7yuaovanxIkITkCuTNiKMWpA4qpL5aVBqeXZ5jdkB0QJsJA5pOxXkQoMljFHl11UhXwm7y589auqfw9W4E52lIeuFaj289fcCTy04WN2HNNYm/ZKI5TcqxsV+IQhdmfwL8q1h0D9iGNmCH1ksggl0upre9c4L+pNRxxUioWmEV9INSjF5M7Innpe56wBFNDBNgs7EhEnziTV5jOS1NJdm8am1lf7hGThYNaNwmUrjRw/DXElEQQRd41TDi9id8zToFPxYFGq4qOpOZybmZHKSUd+uDrxlWSwfuX8diL+vLqb9uJza16ocLdFDZGWPpdBg05G+DCvYbPbO2bJ/d4bBH3tIaI/fhUsOjhTU6BTfD43Wtfb5hrN309U+1+KjNISqKztXjB82Ku/H9ZWteWdCcG1uMoaomwIG5LbYm9FiPUOwQ0XZ9and2dXSxDr0eD0fN1+Omg1rm9JFb/Qs78UWL4GLe+6GzmBWmnDQwlmpkaFgDIqL6ctKdwGkpAr6dve0RSnUuYVfqBySy2BOtJcveTi7iGmvC1XblPfS2/nzaaJLFfP/zaIgoM/WcQJ1+NzSYOw32ZrBbmhXRSX7PC2Dmst0Wsf+Br517zV0lE7ogVFeFaTibHR5LRg28Ufg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM9PR04MB8084.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(39830400003)(396003)(366004)(346002)(376002)(136003)(36756003)(186003)(83380400001)(53546011)(66946007)(86362001)(31686004)(15650500001)(31696002)(42186006)(478600001)(2906002)(316002)(8936002)(8676002)(7416002)(66556008)(2616005)(66476007)(4326008)(107886003)(38100700002)(5660300002)(44832011); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3JvSjMrYXAwZmJ5alpVWHdBVUg0Q3I1ZUNOV21xbm9wZm9zUGg3TGRJdHUv?= =?utf-8?B?TFAwdjhEMzR3QjBnWnY0aXdKTVR5dnlPcE5NKzdtcHBSYjBETW1SbHVycS80?= =?utf-8?B?RkFrMlRXanBhaWdRUHRaenBpY0xRYkxlNWY1SVNiZ25xYTMxV0xRSk9EcnlQ?= =?utf-8?B?NjNqSnhwOEtGbnRWWTlZOEpqN3lEZENmS1o4dEkwRFhUcWlyNnZzWVBISy8w?= =?utf-8?B?WUNuZmd1cURrbFRDc0wzQjhTd2o0Z1hTTFJCUnBLOVJFQnVJOE5XdDJzTHI1?= =?utf-8?B?bzN0ZVVUUVVYVnRuTGFOaEdqaEV5Z2crQzYyVDRjWEFOS2JqWkQrS1VwbFFx?= =?utf-8?B?VFRaTWN4d1habTdLSDcwcVhZaFQvYURNVHdsMVEyODNmOTZ2S3lneXJDeUox?= =?utf-8?B?ZWR0QTJTSFJYSkIwMFdyY2wvb1ZGMlNqdlViWW0vcy92aitjaW1YMlpjcEsy?= =?utf-8?B?RGlQS0ZONVJTQTVRdG9ueHJQVloxdi9KZXBFc0pCaUtUZ0NtTVZSM1ozdGZ0?= =?utf-8?B?YytiVmFBd0V4WEI1ejlHSFF0S3lEdFl3dk10ZmZxWDdHT0FEVFJLSEorQlNJ?= =?utf-8?B?WmdxVkJISzAyaVlBb0JHQWxVaVBkcG9sdUczOExmVCthYWJZM21tVlBldFdW?= =?utf-8?B?V0VXd1hyYk9QLzh6RjlON1VCd05MTTd3aS9uZGs3NGxVMXpsdWt5QXpXMHRV?= =?utf-8?B?TTJRSFVqOW5MUEc3bkE3aE8rNnJEd3hBSFkyc2dsK290OW9VQldIQndTbktY?= =?utf-8?B?allXemJiaHhSenI1TjVBbSt5dGUwbmVLaGZab2YrNUpUV3M2MklvRzZxRVZM?= =?utf-8?B?ckZWb0pRNVQzL0tZc2kydHZDakhDMHBtQ3pJUHNBU2FlbDF4WS8xc3lYWHFk?= =?utf-8?B?R1dDc09hWk1HdmluWUwyY3pRZ3NWUWlaa3NzaXA0OThFbVZ4VElocHgyY3Zu?= =?utf-8?B?cE9RaURiTElWaDRPRlcxZkluQjVIVFFjc1BmQjJLbGtrSzFQcGlBZCtFQTdJ?= =?utf-8?B?K1hqZUd6UWowbFROc3BiZU5TRmVTV3JPaERpN3dwcFdnN3AybzJIZVN2d09N?= =?utf-8?B?Sk9oaC9lczE2cXFmVUl0anJCUHI5T3c0Mkw2OXVrZGNIRkNVUm5tRzRKRlVz?= =?utf-8?B?T3JNWVJxcGl6RkhBR1RGTnlyWEIvM1pmaWhYdGtsYUFNS1AyelN0Ujd3T0lW?= =?utf-8?B?enh6U3dxV1VIV0dhakxyS0Q4UzN2MUphUjRLTUwvMTUwOFV0Qm9RWkJrbEZn?= =?utf-8?B?RWFqYzJHUng2WDV5c2RCeVJ3V2VIRDB5WGhmSVNMdVoxL3VsNC9hNXQ0NUoy?= =?utf-8?B?QnhsNk9jNUlNUWhBZWkyVjNuck54UFV6eVBCUnlSRDNvMTJpSkV0TndZQUJ2?= =?utf-8?B?VXphQWZVQmJVZytBWEFOUDUzY3JpTW45endIMG9PRWhWY2xOTkkwbHFuR3Jz?= =?utf-8?B?cjRsNk9aeVZWVGk0YXVCTEhVSUs5ajRPNDFoTXJJUVNSd3ZDSDJscUc5NTJw?= =?utf-8?B?WXRqY2ZVcmRUL1Y3LzY3RHllSHdxYkFHZzBuRUVUa0JDdUdNWHFQdzVCcTlU?= =?utf-8?B?T0FGSkZPYU9SU0NDVnk3eUNXNUxRQ21raVBwVnNERFlnY1ZLV1RVUTFndldJ?= =?utf-8?B?M0RaMldnK3BIRXlMT2JaSXFrNTR5TVBnRU9tMm42cXNBVCtiNEdDRFRxZStw?= =?utf-8?B?QzFZdGJGcHRiUHo4VnRJSTAySWpUNWZadEpIL3gwdTRFODRxTzZvY3FyaldF?= =?utf-8?B?TGVxWmQwQVFiTlZqeHBPekdrMk90cWsyR0JTUmRwK0RkS1RxMGR5SnFzR1RP?= =?utf-8?B?MjJ4Mk05elowbXNWdlA0d0trbnRJc3ZrMWdKRVJDOXllc2xCQnE5akE3SnN6?= =?utf-8?Q?ahUnetoVNXJ/h?= X-OriginatorOrg: opensynergy.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6f2880-dabb-4a4a-83b4-08d93c6c3076 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8084.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 08:42:42.1543 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 800fae25-9b1b-4edc-993d-c939c4e84a64 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hgrtIDj8Q01VgOQrd4BGWN816NeFsx+9gt+3zfVf+MO86QbiXwl8dMqf/idLNqm+WWefYreMHnYughoy6/u9Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5028 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210701_015843_252247_88861C73 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Cristian, please find some remarks to the patch series in this email and the following. On 11.06.21 18:59, Cristian Marussi wrote: > SCMI message headers carry a sequence number and such field is sized to > allow for MSG_TOKEN_MAX distinct numbers; moreover zero is not really an > acceptable maximum number of pending in-flight messages. > > Fix accordignly the checks performed on the value exported by transports > in scmi_desc.max_msg. > > Reported-by: Vincent Guittot > Fixes: aa4f886f3893 ("firmware: arm_scmi: add basic driver infrastructure for SCMI") > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/driver.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 66e5e694be7d..6713b259f1e6 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -1025,8 +1025,9 @@ static int __scmi_xfer_info_init(struct scmi_info *sinfo, > const struct scmi_desc *desc = sinfo->desc; > > /* Pre-allocated messages, no more than what hdr.seq can support */ > - if (WARN_ON(desc->max_msg >= MSG_TOKEN_MAX)) { > - dev_err(dev, "Maximum message of %d exceeds supported %ld\n", > + if (WARN_ON(!desc->max_msg || desc->max_msg > MSG_TOKEN_MAX)) { > + dev_err(dev, > + "Invalid max_msg %d. Maximum messages supported %ld.\n", %ld -> %lu > desc->max_msg, MSG_TOKEN_MAX); > return -EINVAL; > } > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 303239862C0 for ; Thu, 1 Jul 2021 08:42:49 +0000 (UTC) From: Peter Hilber References: <20210611165937.701-1-cristian.marussi@arm.com> <20210611165937.701-2-cristian.marussi@arm.com> Message-ID: Date: Thu, 1 Jul 2021 10:42:40 +0200 In-Reply-To: <20210611165937.701-2-cristian.marussi@arm.com> MIME-Version: 1.0 Subject: [virtio-dev] Re: [PATCH v4 01/16] firmware: arm_scmi: Fix max pending messages boundary check Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com List-ID: Hi Cristian, please find some remarks to the patch series in this email and the=20 following. On 11.06.21 18:59, Cristian Marussi wrote: > SCMI message headers carry a sequence number and such field is sized to > allow for MSG_TOKEN_MAX distinct numbers; moreover zero is not really an > acceptable maximum number of pending in-flight messages. >=20 > Fix accordignly the checks performed on the value exported by transports > in scmi_desc.max_msg. >=20 > Reported-by: Vincent Guittot > Fixes: aa4f886f3893 ("firmware: arm_scmi: add basic driver infrastructure= for SCMI") > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/driver.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_sc= mi/driver.c > index 66e5e694be7d..6713b259f1e6 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -1025,8 +1025,9 @@ static int __scmi_xfer_info_init(struct scmi_info *= sinfo, > =09const struct scmi_desc *desc =3D sinfo->desc; > =20 > =09/* Pre-allocated messages, no more than what hdr.seq can support */ > -=09if (WARN_ON(desc->max_msg >=3D MSG_TOKEN_MAX)) { > -=09=09dev_err(dev, "Maximum message of %d exceeds supported %ld\n", > +=09if (WARN_ON(!desc->max_msg || desc->max_msg > MSG_TOKEN_MAX)) { > +=09=09dev_err(dev, > +=09=09=09"Invalid max_msg %d. Maximum messages supported %ld.\n", %ld -> %lu > =09=09=09desc->max_msg, MSG_TOKEN_MAX); > =09=09return -EINVAL; > =09} > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org