From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2845DC07E9C for ; Wed, 14 Jul 2021 17:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10E82613C9 for ; Wed, 14 Jul 2021 17:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239449AbhGNRR2 (ORCPT ); Wed, 14 Jul 2021 13:17:28 -0400 Received: from mga01.intel.com ([192.55.52.88]:35631 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbhGNRR0 (ORCPT ); Wed, 14 Jul 2021 13:17:26 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="232208048" X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="232208048" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 10:14:34 -0700 X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="413353781" Received: from alpinagh-mobl1.amr.corp.intel.com (HELO [10.212.71.223]) ([10.212.71.223]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 10:14:33 -0700 Subject: Re: [PATCH v2 10/16] ASoC: qcom: audioreach: add bedai support To: Srinivas Kandagatla , bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, lgirdwood@gmail.com, tiwai@suse.de, plai@codeaurora.org, linux-kernel@vger.kernel.org References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-11-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: Date: Wed, 14 Jul 2021 12:03:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714153039.28373-11-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int q6dma_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params, > + struct snd_soc_dai *dai) > +{ > + struct q6apm_bedai_data *dai_data = dev_get_drvdata(dai->dev); > + struct q6apm_cdc_dma_cfg *cfg = &dai_data->port_config[dai->id].dma_cfg; > + > + cfg->bit_width = params_width(params); > + cfg->sample_rate = params_rate(params); > + cfg->num_channels = params_channels(params); > + > + switch (params_format(params)) { > + case SNDRV_PCM_FORMAT_S16_LE: > + dai_data->bits_per_sample[dai->id] = 16; > + break; > + case SNDRV_PCM_FORMAT_S24_LE: > + dai_data->bits_per_sample[dai->id] = 24; > + break; default: return -EINVAL; ? > + } > + > + return 0; > +} > + > +static void q6apm_bedai_shutdown(struct snd_pcm_substream *substream, > + struct snd_soc_dai *dai) > +{ > + struct q6apm_bedai_data *dai_data = dev_get_drvdata(dai->dev); > + int rc; > + > + if (!dai_data->is_port_started[dai->id]) > + return; > + rc = q6apm_graph_stop(dai_data->graph[dai->id]); > + if (rc < 0) > + dev_err(dai->dev, "fail to close APM port (%d)\n", rc); > + > + q6apm_graph_close(dai_data->graph[dai->id]); > + dai_data->is_port_started[dai->id] = false; difficult to follow, this mixes '!start', 'stop', 'close' > + > +} > + > +static int q6apm_bedai_prepare(struct snd_pcm_substream *substream, > + struct snd_soc_dai *dai) > +{ > + struct q6apm_bedai_data *dai_data = dev_get_drvdata(dai->dev); > + struct q6apm_cdc_dma_cfg *cfg = &dai_data->port_config[dai->id].dma_cfg; > + int graph_id = dai->id; > + int rc; > + int ret; > + struct q6apm_graph *graph; > + > + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { > + graph = q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id); > + if (IS_ERR(graph)) { > + dev_err(dai->dev, "Failed to open graph (%d)\n", > + graph_id); > + ret = PTR_ERR(graph); > + return ret; > + } > + dai_data->graph[graph_id] = graph; > + } > + > + rc = q6apm_graph_media_format_pcm(dai_data->graph[dai->id], > + substream->stream, cfg->sample_rate, > + cfg->num_channels, NULL, cfg->bit_width); > + > + rc = q6apm_graph_prepare(dai_data->graph[dai->id]); any good static analyzer would tell you you didn't test rc before overriding it.. this looks rather questionable. > + rc = q6apm_graph_start(dai_data->graph[dai->id]); > + if (rc < 0) { > + dev_err(dai->dev, "fail to start APM port %x\n", dai->id); > + return rc; > + } > + dai_data->is_port_started[dai->id] = true; > + > + return 0; > +} From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B1B4C07E9A for ; Wed, 14 Jul 2021 17:18:03 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86F2160FF1 for ; Wed, 14 Jul 2021 17:18:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86F2160FF1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1F5D016A0; Wed, 14 Jul 2021 19:17:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1F5D016A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626283081; bh=10UFH51j+N3b3Ekh6KGYNBuWhJszBaUwZeVv6Rb1nYk=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HoqFrYoi62hUcbS3MvxPsFONsVcdg56L3HELqbygXIP+s2u6HAJKPkb10XNVHb5Mt xrIQY6oKr+b5q4TuMAK2qxIcFX1hYJpaSZ0nef1YF/AlZDOszcIgANcZshmVYjGudB WS6Bn59KokV7LIlPwWTsSaf8Vnq4sqZc5fU+Vgo8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B0CA4F804FC; Wed, 14 Jul 2021 19:14:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 96BF4F804E6; Wed, 14 Jul 2021 19:14:38 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E4E41F804DA for ; Wed, 14 Jul 2021 19:14:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E4E41F804DA X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="190769975" X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="190769975" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 10:14:34 -0700 X-IronPort-AV: E=Sophos;i="5.84,239,1620716400"; d="scan'208";a="413353781" Received: from alpinagh-mobl1.amr.corp.intel.com (HELO [10.212.71.223]) ([10.212.71.223]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 10:14:33 -0700 Subject: Re: [PATCH v2 10/16] ASoC: qcom: audioreach: add bedai support To: Srinivas Kandagatla , bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-11-srinivas.kandagatla@linaro.org> From: Pierre-Louis Bossart Message-ID: Date: Wed, 14 Jul 2021 12:03:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210714153039.28373-11-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, tiwai@suse.de, plai@codeaurora.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > +static int q6dma_hw_params(struct snd_pcm_substream *substream, > + struct snd_pcm_hw_params *params, > + struct snd_soc_dai *dai) > +{ > + struct q6apm_bedai_data *dai_data = dev_get_drvdata(dai->dev); > + struct q6apm_cdc_dma_cfg *cfg = &dai_data->port_config[dai->id].dma_cfg; > + > + cfg->bit_width = params_width(params); > + cfg->sample_rate = params_rate(params); > + cfg->num_channels = params_channels(params); > + > + switch (params_format(params)) { > + case SNDRV_PCM_FORMAT_S16_LE: > + dai_data->bits_per_sample[dai->id] = 16; > + break; > + case SNDRV_PCM_FORMAT_S24_LE: > + dai_data->bits_per_sample[dai->id] = 24; > + break; default: return -EINVAL; ? > + } > + > + return 0; > +} > + > +static void q6apm_bedai_shutdown(struct snd_pcm_substream *substream, > + struct snd_soc_dai *dai) > +{ > + struct q6apm_bedai_data *dai_data = dev_get_drvdata(dai->dev); > + int rc; > + > + if (!dai_data->is_port_started[dai->id]) > + return; > + rc = q6apm_graph_stop(dai_data->graph[dai->id]); > + if (rc < 0) > + dev_err(dai->dev, "fail to close APM port (%d)\n", rc); > + > + q6apm_graph_close(dai_data->graph[dai->id]); > + dai_data->is_port_started[dai->id] = false; difficult to follow, this mixes '!start', 'stop', 'close' > + > +} > + > +static int q6apm_bedai_prepare(struct snd_pcm_substream *substream, > + struct snd_soc_dai *dai) > +{ > + struct q6apm_bedai_data *dai_data = dev_get_drvdata(dai->dev); > + struct q6apm_cdc_dma_cfg *cfg = &dai_data->port_config[dai->id].dma_cfg; > + int graph_id = dai->id; > + int rc; > + int ret; > + struct q6apm_graph *graph; > + > + if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { > + graph = q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id); > + if (IS_ERR(graph)) { > + dev_err(dai->dev, "Failed to open graph (%d)\n", > + graph_id); > + ret = PTR_ERR(graph); > + return ret; > + } > + dai_data->graph[graph_id] = graph; > + } > + > + rc = q6apm_graph_media_format_pcm(dai_data->graph[dai->id], > + substream->stream, cfg->sample_rate, > + cfg->num_channels, NULL, cfg->bit_width); > + > + rc = q6apm_graph_prepare(dai_data->graph[dai->id]); any good static analyzer would tell you you didn't test rc before overriding it.. this looks rather questionable. > + rc = q6apm_graph_start(dai_data->graph[dai->id]); > + if (rc < 0) { > + dev_err(dai->dev, "fail to start APM port %x\n", dai->id); > + return rc; > + } > + dai_data->is_port_started[dai->id] = true; > + > + return 0; > +}