All of lore.kernel.org
 help / color / mirror / Atom feed
From: Victor Cora Colombo <victorcora98@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH] trace-cmd: Add dependencies to BUILDING section in README
Date: Thu, 12 Aug 2021 23:47:36 -0300	[thread overview]
Message-ID: <cb3277bd-ef1a-8172-6f9e-809395578441@gmail.com> (raw)
In-Reply-To: <20210812222334.4d486f21@oasis.local.home>

On 8/12/21 11:23 PM, Steven Rostedt wrote:
> On Thu, 12 Aug 2021 19:33:53 -0300
> victorcora98@gmail.com wrote:
> 
>> From: Victor Cora Colombo <victorcora98@gmail.com>
>>
>> KernelShark has instructions in its README on how to get necessary
>> dependencies to build it. trace-cmd could follow this example and
>> also add more information on how to build it.
>>
>> This patch adds instructions to README on how to get necessary libraries
>> and dependencies to build trace-cmd.
> 
> Thanks for sending this.
> 
>>
>> Signed-off-by: Victor Cora Colombo <victorcora98@gmail.com>
>> ---
>>   README | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/README b/README
>> index 1153152..16aedac 100644
>> --- a/README
>> +++ b/README
>> @@ -24,6 +24,20 @@ Lesser General Public License 2.1 (See COPYING.LIB).
>>   
>>   BUILDING:
>>   
>> +In order to install build dependencies on Ubuntu do the following:
>> +    sudo apt-get install build-essential git pkg-config bison flex -y
> 
> Note, once the libtracefs settles down, I plan on committing the files
> that are generated by bison and flex, so it shouldn't be a requirement
> once libtracefs 1.3 is officially released. That is, because the files
> generated by flex and bison will be included in the repository, you do
> not need to include bison or flex to build it. Unless you plan on
> modifying the bison and flex source files.
> 
> Also, can we have a Fedora version? If you don't know what that is, I
> could come up with the equivalents.
> 
> -- Steve
> 

Hello Steve, thanks for your kind reply.

I will come up with a Fedora version and send the updated patch tomorrow.
Also, given what you said, I think it is better then to remove bison and 
flex from this patch, and I will also do this when I send the updated patch.

Best regards,

-- Victor

> 
>> +
>> +To install required dependencies:
>> +    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/
>> +    cd libtraceevent
>> +    make
>> +    sudo make install
>> +
>> +    git clone https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/
>> +    cd libtracefs
>> +    make
>> +    sudo make install
>> +
>>   To make trace-cmd
>>       make
>>   
> 

      reply	other threads:[~2021-08-13  2:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 22:33 [PATCH] trace-cmd: Add dependencies to BUILDING section in README victorcora98
2021-08-13  2:23 ` Steven Rostedt
2021-08-13  2:47   ` Victor Cora Colombo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb3277bd-ef1a-8172-6f9e-809395578441@gmail.com \
    --to=victorcora98@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.