From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7119C07E96 for ; Thu, 15 Jul 2021 10:32:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDC9460BD3 for ; Thu, 15 Jul 2021 10:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241370AbhGOKfH (ORCPT ); Thu, 15 Jul 2021 06:35:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241364AbhGOKfG (ORCPT ); Thu, 15 Jul 2021 06:35:06 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46302C061764 for ; Thu, 15 Jul 2021 03:32:13 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id r11so7075866wro.9 for ; Thu, 15 Jul 2021 03:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gsV66XE0EGcG7u2wmOs4QFlA/ant67YwT3lAEx/PPF4=; b=wIkAKP4/H87UVy9+HYifgqffQYx1gkM/H7YB35NOf1+wZqfqPl2CQZaaA0WzIULntf 2b8QS9GaXQe1+ZRPYGAK667GQv3VOahDiFPceqU72tBooi5//iUK5GQH2GfOvinBM/Oc 4ZcKgePDycMWsVfjGYF8ql+vaQsxokOJtuQu5EO5D5p+RNjcfvdd0JhVKLlYA3qAB9NG nc8LM4g2EwRMpD+QSHKSeYoD8+Z0XKZ8pXpERuPc3VnDRsulTuu9lzepsCKAnkjogK0+ 4mXKMlkGpKSBy4qe1byqMF0C72mBXof5dTQTw50C7uA747tO6XvysXLtB+Tu9mSgroVZ 6fZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gsV66XE0EGcG7u2wmOs4QFlA/ant67YwT3lAEx/PPF4=; b=lg7QMkCqMfH6L7DdZkPbjRvFg5gDQvPG4SXadl2WZaLU2Va9J/Q621+LIRc/+0Rf2T q0n1o5rUspsRL/jCKSAQQf0MiH0tqj2FHBP4JaeOwqA+rBT3HaNdGIyq7IhVAyr/zgvo DlDKVCGscVUvyHsXmpD0jeLIRMK1I4T4XlGJbIpSV3RcTz2NJC/p4CQTzdap/Pz6HQuG vUqTFxHglZnmafRJ2XF7FphNpiUf6QUnAKhTYlIT7lk25GnZunvrsK4CPCKbazGX5QUj Z7mOUhMEhs7MjMBTAeb/NHRJPaRyxwBsHn1J42VxJ+gnraF7PBuV2OgvwKtks+Be9Q3e weLA== X-Gm-Message-State: AOAM532yHyTCn4iAifuqsRcQZiV8g7Ob4udM+XQMqSixJ4eI2Th8qgGg QD0how/6Tcnc2NkD8jnitX4gkYv5Dz06rw== X-Google-Smtp-Source: ABdhPJxD8Iw7gZcKuTN5IAoaPBQmG7KeAJdm6gsWH8Icp8kvCAmMon/G5b+fpC4BZY28Mlrn/Lx3pg== X-Received: by 2002:adf:a1c2:: with SMTP id v2mr4609978wrv.155.1626345131549; Thu, 15 Jul 2021 03:32:11 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id o3sm6086193wrm.5.2021.07.15.03.32.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 03:32:11 -0700 (PDT) Subject: Re: [PATCH v2 10/16] ASoC: qcom: audioreach: add bedai support To: Pierre-Louis Bossart , bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, lgirdwood@gmail.com, tiwai@suse.de, plai@codeaurora.org, linux-kernel@vger.kernel.org References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-11-srinivas.kandagatla@linaro.org> From: Srinivas Kandagatla Message-ID: Date: Thu, 15 Jul 2021 11:32:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/07/2021 18:03, Pierre-Louis Bossart wrote: >> + rc = q6apm_graph_media_format_pcm(dai_data->graph[dai->id], >> + substream->stream, cfg->sample_rate, >> + cfg->num_channels, NULL, cfg->bit_width); >> + >> + rc = q6apm_graph_prepare(dai_data->graph[dai->id]); > any good static analyzer would tell you you didn't test rc before overriding it.. yes you are correct, I did forgot to do cppcheck after make W=1 C=1 These are now fixed in new version. --srini From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 600A9C07E96 for ; Thu, 15 Jul 2021 10:34:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A98F61370 for ; Thu, 15 Jul 2021 10:34:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A98F61370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0926816A4; Thu, 15 Jul 2021 12:34:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0926816A4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626345295; bh=QJciId2qTXla+N7NeCfkM9rR9mGDEERC8jjDx5/29yc=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j38zCRIqHDdcqgm2HzjAQTtX/3ZtXE7knzonz7ejRhAQD0C2mFMPmzWz8oSwEFyRa AysRTjBMzxZboxf8TeA/Hn/xMgewV+CoT9MX5NapaA02alusyIVsKozgNjFqeGyVtZ 6UcvFMZ0N8hnOL8+SiGYe+K3HNGc80ZqlwRHEX34= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 65171F804F1; Thu, 15 Jul 2021 12:32:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C62BF804F2; Thu, 15 Jul 2021 12:32:19 +0200 (CEST) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E10B0F804E0 for ; Thu, 15 Jul 2021 12:32:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E10B0F804E0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wIkAKP4/" Received: by mail-wr1-x433.google.com with SMTP id i94so7102655wri.4 for ; Thu, 15 Jul 2021 03:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gsV66XE0EGcG7u2wmOs4QFlA/ant67YwT3lAEx/PPF4=; b=wIkAKP4/H87UVy9+HYifgqffQYx1gkM/H7YB35NOf1+wZqfqPl2CQZaaA0WzIULntf 2b8QS9GaXQe1+ZRPYGAK667GQv3VOahDiFPceqU72tBooi5//iUK5GQH2GfOvinBM/Oc 4ZcKgePDycMWsVfjGYF8ql+vaQsxokOJtuQu5EO5D5p+RNjcfvdd0JhVKLlYA3qAB9NG nc8LM4g2EwRMpD+QSHKSeYoD8+Z0XKZ8pXpERuPc3VnDRsulTuu9lzepsCKAnkjogK0+ 4mXKMlkGpKSBy4qe1byqMF0C72mBXof5dTQTw50C7uA747tO6XvysXLtB+Tu9mSgroVZ 6fZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gsV66XE0EGcG7u2wmOs4QFlA/ant67YwT3lAEx/PPF4=; b=K+4+IRW/7lFMPcQeYj/3v5L18NmFYBEjCx2iaI18PebpSyjUQLcNT236bqbWM0rbqV Q+zsz/rjdHYuXQhUQuOFRB1BSnJFivSmYcT/mCvgD3HYyfEYJ3qN7Q9svPQC/kxM7qoB wEq4um3a/709aHWSKO7jdzaDDLwBs0eLb2Wina5lYhGp8PsCoFeF4xJvAkhPpR9k+oTV xhZDhqfVBfBd1KBtxMhr4qG9dDsBegib0sv+jNDUbYF60blzS2kqVLkzsAzbY2o4vVme bHDihzXdpYEz4XnPV43X4xViC6v5alnhbrrRnHdT7FwAntEr53uo7p5eofZi08ABMhO2 4Hiw== X-Gm-Message-State: AOAM5330aW9MKVRfCzc7h8AHzfG1VGTueiakhYumzzSqfRbQvkFj1kwq Q5AffOLxYvuLSrJR+qFWqFQeiA== X-Google-Smtp-Source: ABdhPJxD8Iw7gZcKuTN5IAoaPBQmG7KeAJdm6gsWH8Icp8kvCAmMon/G5b+fpC4BZY28Mlrn/Lx3pg== X-Received: by 2002:adf:a1c2:: with SMTP id v2mr4609978wrv.155.1626345131549; Thu, 15 Jul 2021 03:32:11 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id o3sm6086193wrm.5.2021.07.15.03.32.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jul 2021 03:32:11 -0700 (PDT) Subject: Re: [PATCH v2 10/16] ASoC: qcom: audioreach: add bedai support To: Pierre-Louis Bossart , bjorn.andersson@linaro.org, broonie@kernel.org, robh@kernel.org References: <20210714153039.28373-1-srinivas.kandagatla@linaro.org> <20210714153039.28373-11-srinivas.kandagatla@linaro.org> From: Srinivas Kandagatla Message-ID: Date: Thu, 15 Jul 2021 11:32:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, tiwai@suse.de, plai@codeaurora.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 14/07/2021 18:03, Pierre-Louis Bossart wrote: >> + rc = q6apm_graph_media_format_pcm(dai_data->graph[dai->id], >> + substream->stream, cfg->sample_rate, >> + cfg->num_channels, NULL, cfg->bit_width); >> + >> + rc = q6apm_graph_prepare(dai_data->graph[dai->id]); > any good static analyzer would tell you you didn't test rc before overriding it.. yes you are correct, I did forgot to do cppcheck after make W=1 C=1 These are now fixed in new version. --srini