From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D386AECAAD8 for ; Fri, 23 Sep 2022 01:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231932AbiIWBzP (ORCPT ); Thu, 22 Sep 2022 21:55:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230042AbiIWBzM (ORCPT ); Thu, 22 Sep 2022 21:55:12 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A85056B85; Thu, 22 Sep 2022 18:55:10 -0700 (PDT) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MYZt11nZszHqFf; Fri, 23 Sep 2022 09:52:57 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 09:55:08 +0800 Subject: Re: [PATCH 6/7] scsi: pm8001: use dev_and_phy_addr_same() instead of open coded To: John Garry , , CC: , , , , , References: <20220917104311.1878250-1-yanaijie@huawei.com> <20220917104311.1878250-7-yanaijie@huawei.com> <0034eff3-70a5-becb-0821-f9c36371e6d9@huawei.com> From: Jason Yan Message-ID: Date: Fri, 23 Sep 2022 09:55:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <0034eff3-70a5-becb-0821-f9c36371e6d9@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/9/22 22:24, John Garry wrote: > On 17/09/2022 11:43, Jason Yan wrote: >> The sas address comparation of domain device and expander phy is open >> coded. Now we can replace it with dev_and_phy_addr_same(). >> >> Signed-off-by: Jason Yan >> --- >>   drivers/scsi/pm8001/pm8001_sas.c | 3 +-- >>   1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/pm8001/pm8001_sas.c >> b/drivers/scsi/pm8001/pm8001_sas.c >> index 8e3f2f9ddaac..bb1b1722f3ee 100644 >> --- a/drivers/scsi/pm8001/pm8001_sas.c >> +++ b/drivers/scsi/pm8001/pm8001_sas.c >> @@ -649,8 +649,7 @@ static int pm8001_dev_found_notify(struct >> domain_device *dev) >>           for (phy_id = 0; phy_id < parent_dev->ex_dev.num_phys; > > This code seems the same between many libsas LLDDs - could we factor it > out into libsas? Sure we can. I will try to factor it out in the next revision. Thanks, Jason If so, then maybe those new helpers could be put in > sas_internal.h > > Thanks, > John > >>           phy_id++) { >>               phy = &parent_dev->ex_dev.ex_phy[phy_id]; >> -            if (SAS_ADDR(phy->attached_sas_addr) >> -                == SAS_ADDR(dev->sas_addr)) { >> +            if (dev_and_phy_addr_same(dev, phy)) { >>                   pm8001_device->attached_phy = phy_id; >>                   break; >>               } > > .