From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78590C48BCD for ; Wed, 9 Jun 2021 07:39:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 600706135D for ; Wed, 9 Jun 2021 07:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234786AbhFIHlu (ORCPT ); Wed, 9 Jun 2021 03:41:50 -0400 Received: from mga01.intel.com ([192.55.52.88]:4080 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233673AbhFIHlt (ORCPT ); Wed, 9 Jun 2021 03:41:49 -0400 IronPort-SDR: lPjvnVmCPt9swgK553Hb395krJfGfCYgpf8jDLSYhHqoJwwZqK4l02/mogdh3IVKvDc1L95XMP fNeFuF+FE0Tg== X-IronPort-AV: E=McAfee;i="6200,9189,10009"; a="226388873" X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="226388873" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 00:39:54 -0700 IronPort-SDR: AYtn74xIwP8My0IIMbt5vdLIRcpsAeU0Wcq1r9Tv+oWPyUlWLIDCE17iGrDeZRwr9pshWLHezV EL0X2dzYoaFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="552588883" Received: from allen-box.sh.intel.com (HELO [10.239.159.105]) ([10.239.159.105]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2021 00:39:51 -0700 Cc: baolu.lu@linux.intel.com, lukas.bulwahn@gmail.com, rdunlap@infradead.org, dwmw2@infradead.org, joro@8bytes.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-doc@vger.kernel.org Subject: Re: [PATCH] iommu/vt-d: fix kernel-doc syntax in file header To: Aditya Srivastava , will@kernel.org References: <20210523143245.19040-1-yashsri421@gmail.com> From: Lu Baolu Message-ID: Date: Wed, 9 Jun 2021 15:38:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210523143245.19040-1-yashsri421@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/21 10:32 PM, Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > The header for drivers/iommu/intel/pasid.c follows this syntax, but > the content inside does not comply with kernel-doc. > > This line was probably not meant for kernel-doc parsing, but is parsed > due to the presence of kernel-doc like comment syntax(i.e, '/**'), which > causes unexpected warnings from kernel-doc: > warning: Function parameter or member 'fmt' not described in 'pr_fmt' > > Provide a simple fix by replacing this occurrence with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava Queued for v5.14. Thanks! Best regards, baolu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7004EC47095 for ; Wed, 9 Jun 2021 07:39:59 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 236B161364 for ; Wed, 9 Jun 2021 07:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 236B161364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E1739401AF; Wed, 9 Jun 2021 07:39:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iJpTqRs56bkx; Wed, 9 Jun 2021 07:39:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id E238F40168; Wed, 9 Jun 2021 07:39:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id CBC8BC000E; Wed, 9 Jun 2021 07:39:57 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1BFC6C000B for ; Wed, 9 Jun 2021 07:39:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 0987260672 for ; Wed, 9 Jun 2021 07:39:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nYvN4_vstjgl for ; Wed, 9 Jun 2021 07:39:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8104A60071 for ; Wed, 9 Jun 2021 07:39:55 +0000 (UTC) IronPort-SDR: 61KMGQTMVfbknsmsawbGLIHKpJc8KYj9KZPGtJVRQnUTiqWQzzhUTDBbTT3Guactvg2cAeegq5 lRaG39jh+RvQ== X-IronPort-AV: E=McAfee;i="6200,9189,10009"; a="266176713" X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="266176713" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 00:39:54 -0700 IronPort-SDR: AYtn74xIwP8My0IIMbt5vdLIRcpsAeU0Wcq1r9Tv+oWPyUlWLIDCE17iGrDeZRwr9pshWLHezV EL0X2dzYoaFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="552588883" Received: from allen-box.sh.intel.com (HELO [10.239.159.105]) ([10.239.159.105]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2021 00:39:51 -0700 Subject: Re: [PATCH] iommu/vt-d: fix kernel-doc syntax in file header To: Aditya Srivastava , will@kernel.org References: <20210523143245.19040-1-yashsri421@gmail.com> From: Lu Baolu Message-ID: Date: Wed, 9 Jun 2021 15:38:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210523143245.19040-1-yashsri421@gmail.com> Content-Language: en-US Cc: linux-doc@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, lukas.bulwahn@gmail.com, dwmw2@infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 5/23/21 10:32 PM, Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > The header for drivers/iommu/intel/pasid.c follows this syntax, but > the content inside does not comply with kernel-doc. > > This line was probably not meant for kernel-doc parsing, but is parsed > due to the presence of kernel-doc like comment syntax(i.e, '/**'), which > causes unexpected warnings from kernel-doc: > warning: Function parameter or member 'fmt' not described in 'pr_fmt' > > Provide a simple fix by replacing this occurrence with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava Queued for v5.14. Thanks! Best regards, baolu _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AECAAC48BCD for ; Wed, 9 Jun 2021 07:39:59 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55ABA6135D for ; Wed, 9 Jun 2021 07:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55ABA6135D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 21BEA608B9; Wed, 9 Jun 2021 07:39:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CgTgtzIey0fw; Wed, 9 Jun 2021 07:39:58 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5F31B608B1; Wed, 9 Jun 2021 07:39:58 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 062D7C0025; Wed, 9 Jun 2021 07:39:58 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id CC6E0C000B for ; Wed, 9 Jun 2021 07:39:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BBB75832C7 for ; Wed, 9 Jun 2021 07:39:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SARaaPUV8CLK for ; Wed, 9 Jun 2021 07:39:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by smtp1.osuosl.org (Postfix) with ESMTPS id CBF1C832C6 for ; Wed, 9 Jun 2021 07:39:55 +0000 (UTC) IronPort-SDR: du2EQf5NxFMrhSA4UwbGpS3gvILg96jpUFJF+gW4wMMF3XSxZ2qVJzoYGs0LRJc4Va6cK6RWRi gAkglVQ/B/bA== X-IronPort-AV: E=McAfee;i="6200,9189,10009"; a="205048973" X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="205048973" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 00:39:54 -0700 IronPort-SDR: AYtn74xIwP8My0IIMbt5vdLIRcpsAeU0Wcq1r9Tv+oWPyUlWLIDCE17iGrDeZRwr9pshWLHezV EL0X2dzYoaFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,260,1616482800"; d="scan'208";a="552588883" Received: from allen-box.sh.intel.com (HELO [10.239.159.105]) ([10.239.159.105]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2021 00:39:51 -0700 Subject: Re: [PATCH] iommu/vt-d: fix kernel-doc syntax in file header To: Aditya Srivastava , will@kernel.org References: <20210523143245.19040-1-yashsri421@gmail.com> From: Lu Baolu Message-ID: Date: Wed, 9 Jun 2021 15:38:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210523143245.19040-1-yashsri421@gmail.com> Content-Language: en-US Cc: linux-doc@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, joro@8bytes.org, rdunlap@infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, dwmw2@infradead.org, baolu.lu@linux.intel.com X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" On 5/23/21 10:32 PM, Aditya Srivastava wrote: > The opening comment mark '/**' is used for highlighting the beginning of > kernel-doc comments. > The header for drivers/iommu/intel/pasid.c follows this syntax, but > the content inside does not comply with kernel-doc. > > This line was probably not meant for kernel-doc parsing, but is parsed > due to the presence of kernel-doc like comment syntax(i.e, '/**'), which > causes unexpected warnings from kernel-doc: > warning: Function parameter or member 'fmt' not described in 'pr_fmt' > > Provide a simple fix by replacing this occurrence with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava Queued for v5.14. Thanks! Best regards, baolu _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees