All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Juergen Gross <jgross@suse.com>,
	David Hildenbrand <david@redhat.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Matthew Wilcox <willy@infradead.org>
Cc: k.khlebnikov@samsung.com,
	Stefano Stabellini <sstabellini@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"VMware, Inc." <pv-drivers@vmware.com>,
	osstest service owner <osstest-admin@xenproject.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org, Julien Freche <jfreche@vmware.com>,
	Nadav Amit <namit@vmware.com>,
	xen-devel@lists.xenproject.org
Subject: Re: xen: Can't insert balloon page into VM userspace (WAS Re: [linux-linus bisection] complete test-arm64-arm64-xl-xsm)
Date: Thu, 14 Mar 2019 14:12:43 +0000	[thread overview]
Message-ID: <cb525882-b52f-c142-8a6a-e5cb491e05d0__23365.6958722108$1552572822$gmane$org@arm.com> (raw)
In-Reply-To: <ec71c03e-987d-2b73-9fe6-2604a3c32017@suse.com>

Hi,

On 3/14/19 8:37 AM, Juergen Gross wrote:
> On 12/03/2019 20:46, David Hildenbrand wrote:
>> On 12.03.19 19:23, David Hildenbrand wrote:
>>
>> I guess something like this could do the trick if I understood it correctly:
>>
>> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
>> index 39b229f9e256..d37dd5bb7a8f 100644
>> --- a/drivers/xen/balloon.c
>> +++ b/drivers/xen/balloon.c
>> @@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct
>> page **pages)
>>          while (pgno < nr_pages) {
>>                  page = balloon_retrieve(true);
>>                  if (page) {
>> +                       __ClearPageOffline(page);
>>                          pages[pgno++] = page;
>>   #ifdef CONFIG_XEN_HAVE_PVMMU
>>                          /*
>> @@ -645,8 +646,10 @@ void free_xenballooned_pages(int nr_pages, struct
>> page **pages)
>>          mutex_lock(&balloon_mutex);
>>
>>          for (i = 0; i < nr_pages; i++) {
>> -               if (pages[i])
>> +               if (pages[i]) {
>> +                       __SetPageOffline(pages[i]);
>>                          balloon_append(pages[i]);
>> +               }
>>          }
>>
>>          balloon_stats.target_unpopulated -= nr_pages;
>>
>>
>> At least this way, the pages allocated (and thus eventually mapped to
>> user space) would not be marked, but the other ones would remain marked
>> and could be excluded by makedumptool.
>>
> 
> I think this patch should do the trick. Julien, could you give it a
> try? On x86 I can't reproduce your problem easily as dom0 is PV with
> plenty of unpopulated pages for grant memory not suffering from
> missing "offline" bit.

Sure. I managed to get the console working with the patch suggested by 
David. Feel free to add my tested-by if when you resend it as is.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-03-14 14:12 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11 23:52 [linux-linus bisection] complete test-arm64-arm64-xl-xsm osstest service owner
2019-03-12 15:59 ` Julien Grall
2019-03-12 17:05   ` xen: Can't insert balloon page into VM userspace (WAS Re: [linux-linus bisection] complete test-arm64-arm64-xl-xsm) Julien Grall
2019-03-12 17:05   ` xen: Can't insert balloon page into VM userspace (WAS Re: [Xen-devel] " Julien Grall
2019-03-12 17:14     ` Matthew Wilcox
2019-03-12 17:14       ` xen: Can't insert balloon page into VM userspace (WAS " Matthew Wilcox
2019-03-12 17:18       ` xen: Can't insert balloon page into VM userspace (WAS Re: [Xen-devel] " David Hildenbrand
2019-03-12 17:18         ` xen: Can't insert balloon page into VM userspace (WAS " David Hildenbrand
2019-03-12 17:24         ` Andrew Cooper
2019-03-12 17:24         ` [Xen-devel] " Andrew Cooper
2019-03-12 18:02           ` Boris Ostrovsky
2019-03-12 18:02           ` [Xen-devel] " Boris Ostrovsky
2019-03-12 18:11             ` Andrew Cooper
2019-03-12 18:11             ` [Xen-devel] " Andrew Cooper
2019-03-12 18:23             ` David Hildenbrand
2019-03-12 18:23             ` [Xen-devel] " David Hildenbrand
2019-03-12 19:46               ` David Hildenbrand
2019-03-14  8:37                 ` Juergen Gross
2019-03-14 14:12                   ` Julien Grall [this message]
2019-03-14 14:12                   ` Julien Grall
2019-03-14 14:14                     ` David Hildenbrand
2019-03-14 14:14                     ` [Xen-devel] " David Hildenbrand
2019-03-14 14:15                     ` Juergen Gross
2019-03-14 14:16                       ` David Hildenbrand
2019-03-14 14:16                       ` [Xen-devel] " David Hildenbrand
2019-03-14 14:15                     ` Juergen Gross
2019-03-14  8:37                 ` Juergen Gross
2019-03-12 19:46               ` David Hildenbrand
2019-03-12 17:39         ` Julien Grall
2019-03-12 17:39         ` xen: Can't insert balloon page into VM userspace (WAS Re: [Xen-devel] " Julien Grall
2019-03-12 17:49           ` xen: Can't insert balloon page into VM userspace (WAS " David Hildenbrand
2019-03-12 17:49           ` xen: Can't insert balloon page into VM userspace (WAS Re: [Xen-devel] " David Hildenbrand
2019-03-12 17:23       ` xen: Can't insert balloon page into VM userspace (WAS " David Hildenbrand
2019-03-12 17:23       ` xen: Can't insert balloon page into VM userspace (WAS Re: [Xen-devel] " David Hildenbrand
2019-03-12 17:25         ` xen: Can't insert balloon page into VM userspace (WAS " Nadav Amit
2019-03-12 17:25         ` xen: Can't insert balloon page into VM userspace (WAS Re: [Xen-devel] " Nadav Amit
2019-03-12 17:27   ` [linux-linus bisection] complete test-arm64-arm64-xl-xsm Roger Pau Monné
2019-03-12 18:00     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='cb525882-b52f-c142-8a6a-e5cb491e05d0__23365.6958722108$1552572822$gmane$org@arm.com' \
    --to=julien.grall@arm.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david@redhat.com \
    --cc=jfreche@vmware.com \
    --cc=jgross@suse.com \
    --cc=k.khlebnikov@samsung.com \
    --cc=keescook@chromium.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=namit@vmware.com \
    --cc=osstest-admin@xenproject.org \
    --cc=pv-drivers@vmware.com \
    --cc=sstabellini@kernel.org \
    --cc=willy@infradead.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.