From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver Date: Wed, 15 Nov 2017 21:15:29 +0100 Message-ID: References: <20171115194203.13572-1-dmurphy@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20171115194203.13572-1-dmurphy-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dan Murphy Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org, pavel-+ZI9xUNit7I@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lee Jones , Daniel Thompson , Jingoo Han List-Id: linux-leds@vger.kernel.org Hi Dan, Thanks for the patch. On 11/15/2017 08:42 PM, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v3 - No changes > v2 - No changes - https://patchwork.kernel.org/patch/10056677/ > > .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > new file mode 100644 > index 000000000000..cfef67bd4100 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > @@ -0,0 +1,28 @@ > +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver > + > +The LM36922 is an ultra-compact, highly efficient, > +two string white-LED driver designed for LCD display > +backlighting. Shouldn't the driver be targeted for backlight subsystem then? Adding backlight maintainers. Best regards, Jacek Anaszewski > +Required properties: > + - compatible: > + "ti,lm3692x" > + - reg - I2C slave address > + > +Optional properties: > + - label - Used for naming LEDs > + - enable-gpio - gpio pin to enable/disable the device. > + - supply - "vled" - LED supply > + > +Example: > + > +leds: leds@6 { > + compatible = "ti,lm3692x"; > + reg = <0x36>; > + label = "backlight_cluster"; > + enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; > + vled-supply = <&vbatt>; > +} > + > +For more product information please see the link below: > +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933346AbdKOUQi (ORCPT ); Wed, 15 Nov 2017 15:16:38 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:41462 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756555AbdKOUQ3 (ORCPT ); Wed, 15 Nov 2017 15:16:29 -0500 X-Google-Smtp-Source: AGs4zMbsgHUOSj5TFmP/7Pova+s7Tne2QlebDYaRXfZ/0tTUEn3NwnJGKQqxXOZiTFir178uT+iVDQ== Subject: Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver To: Dan Murphy References: <20171115194203.13572-1-dmurphy@ti.com> Cc: robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Lee Jones , Daniel Thompson , Jingoo Han From: Jacek Anaszewski X-Enigmail-Draft-Status: N1110 Message-ID: Date: Wed, 15 Nov 2017 21:15:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20171115194203.13572-1-dmurphy@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, Thanks for the patch. On 11/15/2017 08:42 PM, Dan Murphy wrote: > This adds the devicetree bindings for the LM3692x > I2C LED string driver. > > Acked-by: Pavel Machek > Signed-off-by: Dan Murphy > --- > > v3 - No changes > v2 - No changes - https://patchwork.kernel.org/patch/10056677/ > > .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > new file mode 100644 > index 000000000000..cfef67bd4100 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt > @@ -0,0 +1,28 @@ > +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver > + > +The LM36922 is an ultra-compact, highly efficient, > +two string white-LED driver designed for LCD display > +backlighting. Shouldn't the driver be targeted for backlight subsystem then? Adding backlight maintainers. Best regards, Jacek Anaszewski > +Required properties: > + - compatible: > + "ti,lm3692x" > + - reg - I2C slave address > + > +Optional properties: > + - label - Used for naming LEDs > + - enable-gpio - gpio pin to enable/disable the device. > + - supply - "vled" - LED supply > + > +Example: > + > +leds: leds@6 { > + compatible = "ti,lm3692x"; > + reg = <0x36>; > + label = "backlight_cluster"; > + enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>; > + vled-supply = <&vbatt>; > +} > + > +For more product information please see the link below: > +http://www.ti.com/lit/ds/snvsa29/snvsa29.pdf >