Re: [Qemu-devel] [PATCH 0/1] major / minor macros are to be included from <sys/sysmacros.h>

From: Eric Blake <eblake@redhat.com>
To: Andreas Grapentin <andreas@grapentin.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/1] major / minor macros are to be included from <sys/sysmacros.h>
Date: Tue, 14 Mar 2017 08:37:31 -0500	[thread overview]
Message-ID: <cb635189-1c52-8b30-d33d-e593febc2a2e@redhat.com> (raw)
In-Reply-To: <20170314101925.16792-1-andreas@grapentin.org>

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

On 03/14/2017 05:19 AM, Andreas Grapentin wrote:
> Building qemu fails with glibc-2.25 and gcc-6.3.1:
> 
>> qemu/qga/commands-posix.c:656:13: error: In the GNU C Library, "major" is defined
>>  by <sys/sysmacros.h>. For historical compatibility, it is
>>  currently defined by <sys/types.h> as well, but we plan to
>>  remove this soon. To use "major", include <sys/sysmacros.h>
>>  directly. If you did not intend to use a system-defined macro
>>  "major", you should undefine it after including <sys/types.h>. [-Werror]
>>          *devmajor = major(st.st_rdev);
>>              ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> A trivial fix is to #include <sys/sysmacros.h> in the respective files.
> 
> 
> Andreas Grapentin (1):
>   major / minor macros are to be included from <sys/sysmacros.h>

NACK. <sys/sysmacros.h> is not a universal file, so you can't blindly
include it without first checking that it exists. We already fixed the
problem correctly in commit 4d04351, which just landed today.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]