From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C396C433DB for ; Fri, 15 Jan 2021 01:52:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49FC223A5A for ; Fri, 15 Jan 2021 01:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731750AbhAOBwi (ORCPT ); Thu, 14 Jan 2021 20:52:38 -0500 Received: from foss.arm.com ([217.140.110.172]:58922 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727152AbhAOBwh (ORCPT ); Thu, 14 Jan 2021 20:52:37 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADFF6D6E; Thu, 14 Jan 2021 17:51:51 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9521E3F66E; Thu, 14 Jan 2021 17:51:49 -0800 (PST) Subject: Re: [PATCH V2 07/11] arm64: Add TRBE definitions To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Cc: mathieu.poirier@linaro.org, mike.leach@linaro.org, Linu Cherian , linux-kernel@vger.kernel.org References: <1610511498-4058-1-git-send-email-anshuman.khandual@arm.com> <1610511498-4058-8-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: Date: Fri, 15 Jan 2021 07:22:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/13/21 2:51 PM, Suzuki K Poulose wrote: > On 1/13/21 4:18 AM, Anshuman Khandual wrote: >> This adds TRBE related registers and corresponding feature macros. >> >> Cc: Mathieu Poirier >> Cc: Mike Leach >> Cc: Suzuki K Poulose >> Signed-off-by: Anshuman Khandual >> --- >>   arch/arm64/include/asm/sysreg.h | 49 +++++++++++++++++++++++++++++++++++++++++ >>   1 file changed, 49 insertions(+) >> >> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h >> index 4acff97..d60750e7 100644 >> --- a/arch/arm64/include/asm/sysreg.h >> +++ b/arch/arm64/include/asm/sysreg.h >> @@ -329,6 +329,55 @@ >>     /*** End of Statistical Profiling Extension ***/ >>   +/* >> + * TRBE Registers >> + */ >> +#define SYS_TRBLIMITR_EL1        sys_reg(3, 0, 9, 11, 0) >> +#define SYS_TRBPTR_EL1            sys_reg(3, 0, 9, 11, 1) >> +#define SYS_TRBBASER_EL1        sys_reg(3, 0, 9, 11, 2) >> +#define SYS_TRBSR_EL1            sys_reg(3, 0, 9, 11, 3) >> +#define SYS_TRBMAR_EL1            sys_reg(3, 0, 9, 11, 4) >> +#define SYS_TRBTRG_EL1            sys_reg(3, 0, 9, 11, 6) >> +#define SYS_TRBIDR_EL1            sys_reg(3, 0, 9, 11, 7) >> + >> +#define TRBLIMITR_LIMIT_MASK        GENMASK_ULL(51, 0) >> +#define TRBLIMITR_LIMIT_SHIFT        12 >> +#define TRBLIMITR_NVM            BIT(5) >> +#define TRBLIMITR_TRIG_MODE_MASK    GENMASK(1, 0) >> +#define TRBLIMITR_TRIG_MODE_SHIFT    2 > > This must be 3. Changed. > > Rest looks fine to me > > Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33290C433E0 for ; Fri, 15 Jan 2021 01:53:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E477F23A5A for ; Fri, 15 Jan 2021 01:53:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E477F23A5A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YEpMB3YOI/avRFndPVIUUlM2FaBhe1fO/I70ixZPywc=; b=wmWpofcXOLZ21DwHUHy7bEVZK WUe/5UPTHBVp9nIDotIxoz61HM+yO+tjE3aJoNU8H1djA8eYAcfjY3HtmmSCQwN3MuI9fv7dBkaRv NOhQyUvEayt2JASk/jNRTD3YK/oUMlD009CmuQos7Gg+zhdyGPcGWiEvXouBO3TjOl9oODaYNClNL LhejmHFL0A1FMTgYp0dM4SvX8Mh6eK/QuZRODzcpQBP4iUNMpAtn0DJIaIM9+JP6u5fWjdEJA+0BK L9iVgfrxjXOxhYlXvlM1dcKO+WEfFmEW2435BqaJUOkGChKvXMVUc9qXC4mbc5wvrFl0mcr5XECjj tOO/rFUmA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0EHN-0005tq-5L; Fri, 15 Jan 2021 01:51:57 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l0EHL-0005tF-PV for linux-arm-kernel@lists.infradead.org; Fri, 15 Jan 2021 01:51:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ADFF6D6E; Thu, 14 Jan 2021 17:51:51 -0800 (PST) Received: from [192.168.0.130] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9521E3F66E; Thu, 14 Jan 2021 17:51:49 -0800 (PST) Subject: Re: [PATCH V2 07/11] arm64: Add TRBE definitions To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org References: <1610511498-4058-1-git-send-email-anshuman.khandual@arm.com> <1610511498-4058-8-git-send-email-anshuman.khandual@arm.com> From: Anshuman Khandual Message-ID: Date: Fri, 15 Jan 2021 07:22:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210114_205155_881548_ACE6DDA7 X-CRM114-Status: GOOD ( 13.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Linu Cherian , mathieu.poirier@linaro.org, mike.leach@linaro.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxLzEzLzIxIDI6NTEgUE0sIFN1enVraSBLIFBvdWxvc2Ugd3JvdGU6Cj4gT24gMS8xMy8y MSA0OjE4IEFNLCBBbnNodW1hbiBLaGFuZHVhbCB3cm90ZToKPj4gVGhpcyBhZGRzIFRSQkUgcmVs YXRlZCByZWdpc3RlcnMgYW5kIGNvcnJlc3BvbmRpbmcgZmVhdHVyZSBtYWNyb3MuCj4+Cj4+IENj OiBNYXRoaWV1IFBvaXJpZXIgPG1hdGhpZXUucG9pcmllckBsaW5hcm8ub3JnPgo+PiBDYzogTWlr ZSBMZWFjaCA8bWlrZS5sZWFjaEBsaW5hcm8ub3JnPgo+PiBDYzogU3V6dWtpIEsgUG91bG9zZSA8 c3V6dWtpLnBvdWxvc2VAYXJtLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogQW5zaHVtYW4gS2hhbmR1 YWwgPGFuc2h1bWFuLmtoYW5kdWFsQGFybS5jb20+Cj4+IC0tLQo+PiDCoCBhcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL3N5c3JlZy5oIHwgNDkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysKPj4gwqAgMSBmaWxlIGNoYW5nZWQsIDQ5IGluc2VydGlvbnMoKykKPj4KPj4gZGlm ZiAtLWdpdCBhL2FyY2gvYXJtNjQvaW5jbHVkZS9hc20vc3lzcmVnLmggYi9hcmNoL2FybTY0L2lu Y2x1ZGUvYXNtL3N5c3JlZy5oCj4+IGluZGV4IDRhY2ZmOTcuLmQ2MDc1MGU3IDEwMDY0NAo+PiAt LS0gYS9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL3N5c3JlZy5oCj4+ICsrKyBiL2FyY2gvYXJtNjQv aW5jbHVkZS9hc20vc3lzcmVnLmgKPj4gQEAgLTMyOSw2ICszMjksNTUgQEAKPj4gwqAgwqAgLyoq KiBFbmQgb2YgU3RhdGlzdGljYWwgUHJvZmlsaW5nIEV4dGVuc2lvbiAqKiovCj4+IMKgICsvKgo+ PiArICogVFJCRSBSZWdpc3RlcnMKPj4gKyAqLwo+PiArI2RlZmluZSBTWVNfVFJCTElNSVRSX0VM McKgwqDCoMKgwqDCoMKgIHN5c19yZWcoMywgMCwgOSwgMTEsIDApCj4+ICsjZGVmaW5lIFNZU19U UkJQVFJfRUwxwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzeXNfcmVnKDMsIDAsIDksIDExLCAxKQo+ PiArI2RlZmluZSBTWVNfVFJCQkFTRVJfRUwxwqDCoMKgwqDCoMKgwqAgc3lzX3JlZygzLCAwLCA5 LCAxMSwgMikKPj4gKyNkZWZpbmUgU1lTX1RSQlNSX0VMMcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg c3lzX3JlZygzLCAwLCA5LCAxMSwgMykKPj4gKyNkZWZpbmUgU1lTX1RSQk1BUl9FTDHCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHN5c19yZWcoMywgMCwgOSwgMTEsIDQpCj4+ICsjZGVmaW5lIFNZU19U UkJUUkdfRUwxwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBzeXNfcmVnKDMsIDAsIDksIDExLCA2KQo+ PiArI2RlZmluZSBTWVNfVFJCSURSX0VMMcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3lzX3JlZygz LCAwLCA5LCAxMSwgNykKPj4gKwo+PiArI2RlZmluZSBUUkJMSU1JVFJfTElNSVRfTUFTS8KgwqDC oMKgwqDCoMKgIEdFTk1BU0tfVUxMKDUxLCAwKQo+PiArI2RlZmluZSBUUkJMSU1JVFJfTElNSVRf U0hJRlTCoMKgwqDCoMKgwqDCoCAxMgo+PiArI2RlZmluZSBUUkJMSU1JVFJfTlZNwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBCSVQoNSkKPj4gKyNkZWZpbmUgVFJCTElNSVRSX1RSSUdfTU9ERV9NQVNL wqDCoMKgIEdFTk1BU0soMSwgMCkKPj4gKyNkZWZpbmUgVFJCTElNSVRSX1RSSUdfTU9ERV9TSElG VMKgwqDCoCAyCj4gCj4gVGhpcyBtdXN0IGJlIDMuCgpDaGFuZ2VkLgoKPiAKPiBSZXN0IGxvb2tz IGZpbmUgdG8gbWUKPiAKPiBTdXp1a2kKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK