From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19128C3A5A9 for ; Mon, 4 May 2020 10:19:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E93A1206E6 for ; Mon, 4 May 2020 10:19:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E93A1206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jVYBZ-0003BP-4c; Mon, 04 May 2020 10:18:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jVYBY-0003BK-BB for xen-devel@lists.xenproject.org; Mon, 04 May 2020 10:18:52 +0000 X-Inumbo-ID: a658ed62-8df0-11ea-b9cf-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a658ed62-8df0-11ea-b9cf-bc764e2007e4; Mon, 04 May 2020 10:18:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 05460AC53; Mon, 4 May 2020 10:18:51 +0000 (UTC) Subject: Re: [PATCH RESEND 2/2] xen: Allow EXPERT mode to be selected from the menuconfig directly To: Julien Grall References: <20200430142548.23751-1-julien@xen.org> <20200430142548.23751-3-julien@xen.org> <3a4ec020-f626-031e-73a6-b2eee97ab9e8@suse.com> <548a9fc5-c251-5d8b-d297-4788d60b801d@xen.org> <36944bda-14a8-0134-cd1d-1f08becb28b0@suse.com> <898479ac-fd5c-48f4-28cb-8bbb2dc60d83@xen.org> <443018dd-d30e-037d-b7b1-d531d81bed15@suse.com> <3c581eac-9b2f-493c-f86e-2377450a6a2a@xen.org> From: Jan Beulich Message-ID: Date: Mon, 4 May 2020 12:18:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <3c581eac-9b2f-493c-f86e-2377450a6a2a@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Andrew Cooper , Julien Grall , Ian Jackson , George Dunlap , xen-devel@lists.xenproject.org Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 04.05.2020 11:54, Julien Grall wrote: > Hi Jan, > > On 04/05/2020 10:37, Jan Beulich wrote: >> On 04.05.2020 11:30, Julien Grall wrote: >>> Hi Jan, >>> >>> On 04/05/2020 10:18, Jan Beulich wrote: >>>> On 30.04.2020 17:35, Julien Grall wrote: >>>>> On 30/04/2020 15:50, Jan Beulich wrote: >>>>>> On 30.04.2020 16:25, Julien Grall wrote: >>>>>>> EXPERT mode is currently used to gate any options that are in technical >>>>>>> preview or not security supported At the moment, the only way to select >>>>>>> it is to use XEN_CONFIG_EXPERT=y on the make command line. >>>>>>> >>>>>>> However, if the user forget to add the option of one of the make >>>>>>> command (even a clean), then .config will get rewritten. This may lead >>>>>>> to a rather frustrating experience as it is difficult to diagnostic the >>>>>>> issue. >>>>>> >>>>>> Is / will this still be true after Anthony's rework of the build >>>>>> system? Right now we already have >>>>>> >>>>>> clean-targets := %clean >>>>>> no-dot-config-targets := $(clean-targets) \ >>>>>>                             ... >>>>> >>>>> I haven't tried Anthony's rework yet. But I guess the problem would >>>>> be the same if you forget to add XEN_CONFIG_EXPERT=y on make. >>>> >>>> Why? xen/.config would get re-written only if kconfig got run in >>>> the first place. It is my understanding that no-dot-config-targets >>>> exist to avoid including .config, and as a result make won't find >>>> a need anymore to cause it to re-made if out of date. >>> >>> kconfig may be executed because you change one of the */Kconfig file. >>> So if you happen to forget XEN_CONFIG_EXPERT=y on your build command >>> line, then you will have your .config rewritten without expert options. >> >> That's still a build system issue then (if this is really what happens): >> Dependencies of xen/.config shouldn't be evaluated as long as it doesn't >> get used. > > I am not sure to understand what you mean by "doesn't get used here". When you build Xen, xen/.config is a dependency for the auto-generated header. So 'make' will actually check whether there are any modification in */Kconfig. But you were talking about "make clean", weren't you? Jan