From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x227/g4UYibGC5ATHLwEvjGG/ebHoM5t4RfC0RnuUEtSBX0DIGTmmSx1dzdGmpCRwbsEoQXPW ARC-Seal: i=1; a=rsa-sha256; t=1517318590; cv=none; d=google.com; s=arc-20160816; b=XQpu3IMv1NNPOhk1370S0wu1yligs5PE1H8KZq68zjzUw3bNJxzwOx+4QNOcTx7dbh XNunhomLBuiAqiTtVC0CCCvG6tVeRFVchfGqmwzNy76RkN0mUfMMPj4oHzfDcjmAd3ry FVj3iCD2HPCdmdmYLXV4xXt5JlMYwzFS3/KJ388hjf+1Xcwm7+LahylnsC398EfLPEQ6 OXqcTez4z96cRPGzMgTL/PeYbeehAtvakBkZyilK/9amXdsfmEJG9S/4foB7mfj1no9s soR82YSN0t4EW82Nj786zaB7fO5t/iq2NqPCsXr9zOpJnaqHRDnpZW7wnwJnbwd8cGul ugnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=6ZqBjv2nWj5NARiadOqzeEtjPjLyzRwM50cnYQWqH7M=; b=TZ6fTWbUgX+Gj0gZmXB7JxomG4oQwlTeAnGZsUNEgFiTW1oSNoAAFdlgUQsUqM7IUg 1X84D0vb5Sx2/o3jgY87/NGFWT4IM96Hh+qH7Dp0JH9TxIXUC9uMBo12bM3Ni57P1uh9 g7Tredu6fppUEncUTkpaS6lKzGlsrdp2bAsNIx6MKdHGtrOmUkismNjOA8gqxSr+lcjt pf/h/wUSCtHsVCCJB2UbaVfzVBdrOKKjUgXJVbHi/BcL7po2bncQyoBhaCELEVhIqi0q B7cB8GUtvwB+Wmwr091WKq0Ryn8QgBSBRBi16DTZj35qGgAUvR1MZZAZSyjtdyAGy7zq dqcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of florian@florian-wolters.de designates 176.9.1.167 as permitted sender) smtp.mailfrom=florian@florian-wolters.de Authentication-Results: mx.google.com; spf=pass (google.com: domain of florian@florian-wolters.de designates 176.9.1.167 as permitted sender) smtp.mailfrom=florian@florian-wolters.de Subject: Re: [PATCH 4.4 63/74] net: igmp: fix source address check for IGMPv3 reports To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Sebastian Gottschall , Felix Fietkau , "David S. Miller" References: <20180129123847.507563674@linuxfoundation.org> <20180129123850.383712554@linuxfoundation.org> From: Florian Wolters Message-ID: Date: Tue, 30 Jan 2018 14:22:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180129123850.383712554@linuxfoundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590958493573915596?= X-GMAIL-MSGID: =?utf-8?q?1591023858745627835?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Tested-by: Florian Wolters I have tested this patch applied to 4.4.113 with positive result within the fli4l project. On 01/29/2018 01:57 PM, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Felix Fietkau > > > [ Upstream commit ad23b750933ea7bf962678972a286c78a8fa36aa ] > > Commit "net: igmp: Use correct source address on IGMPv3 reports" > introduced a check to validate the source address of locally generated > IGMPv3 packets. > Instead of checking the local interface address directly, it uses > inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the > local subnet (or equal to the point-to-point address if used). > > This breaks for point-to-point interfaces, so check against > ifa->ifa_local directly. > > Cc: Kevin Cernekee > Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports") > Reported-by: Sebastian Gottschall > Signed-off-by: Felix Fietkau > Signed-off-by: David S. Miller > Signed-off-by: Greg Kroah-Hartman > --- > net/ipv4/igmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/net/ipv4/igmp.c > +++ b/net/ipv4/igmp.c > @@ -338,7 +338,7 @@ static __be32 igmpv3_get_srcaddr(struct > return htonl(INADDR_ANY); > > for_ifa(in_dev) { > - if (inet_ifa_match(fl4->saddr, ifa)) > + if (fl4->saddr == ifa->ifa_local) > return fl4->saddr; > } endfor_ifa(in_dev); > >