From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v2 3/4] eal: set name when creating a control
	thread
Date: Tue, 10 Apr 2018 17:34:36 +0100
Message-ID: <cb8a9072-455a-8b34-7413-532451eb782c@intel.com>
References: <20180403130439.11151-1-olivier.matz@6wind.com>
 <20180403130439.11151-4-olivier.matz@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 8A4C71BAE4
 for <dev@dpdk.org>; Tue, 10 Apr 2018 18:34:38 +0200 (CEST)
In-Reply-To: <20180403130439.11151-4-olivier.matz@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03-Apr-18 2:04 PM, Olivier Matz wrote:
> To avoid code duplication, add a parameter to rte_ctrl_thread_create()
> to specify the name of the thread.
> 
> This requires to add a wrapper for the thread start routine in
> rte_thread_init(), which will first wait that the thread is configured.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---

<...>

> +
> +	pthread_barrier_wait(&params.configured);
> +
> +	return 0;
> +
> +fail:
> +	pthread_kill(*thread, SIGTERM);

This may be wrong, but perhaps instead of killing the thread outright, a 
better approach would be pthread_cancel? I'm always uneasy about mixing 
signals and pthreads...

> +	pthread_join(*thread, NULL);
> +	return ret;
>   }

-- 
Thanks,
Anatoly