From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0481C43381 for ; Mon, 18 Mar 2019 07:28:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8275D20854 for ; Mon, 18 Mar 2019 07:28:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727197AbfCRH2b (ORCPT ); Mon, 18 Mar 2019 03:28:31 -0400 Received: from mout02.posteo.de ([185.67.36.142]:57669 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726335AbfCRH2b (ORCPT ); Mon, 18 Mar 2019 03:28:31 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id C39B82400FC for ; Mon, 18 Mar 2019 08:28:28 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 44N7884Lwgz9rxH; Mon, 18 Mar 2019 08:28:24 +0100 (CET) Subject: Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference To: Kangjie Lu Cc: pakki001@umn.edu, Greg Kroah-Hartman , Jiri Slaby , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20190315171606.6282-1-kjlu@umn.edu> From: Richard Genoud Message-ID: Date: Mon, 18 Mar 2019 08:28:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190315171606.6282-1-kjlu@umn.edu> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 15/03/2019 à 18:16, Kangjie Lu a écrit : > In case dmaengine_prep_dma_cyclic fails, the fix returns a proper > error code to avoid NULL pointer dereference. > > Signed-off-by: Kangjie Lu > Fixes: 34df42f59a60 ("serial: at91: add rx dma support") Acked-by: Richard Genoud > > --- > V2: simplified the patch as suggested by > Richard Genoud > --- > drivers/tty/serial/atmel_serial.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 05147fe24343..41b728d223d1 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -1288,6 +1288,10 @@ static int atmel_prepare_rx_dma(struct uart_port *port) > sg_dma_len(&atmel_port->sg_rx)/2, > DMA_DEV_TO_MEM, > DMA_PREP_INTERRUPT); > + if (!desc) { > + dev_err(port->dev, "Preparing DMA cyclic failed\n"); > + goto chan_err; > + } > desc->callback = atmel_complete_rx_dma; > desc->callback_param = port; > atmel_port->desc_rx = desc; > Thanks ! Richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4996FC10F00 for ; Mon, 18 Mar 2019 07:28:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15A2D20854 for ; Mon, 18 Mar 2019 07:28:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FFjla42x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15A2D20854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bz6PxNYjnrLe1kysW9vFPgedaywblRFnQKSCKsS7uh4=; b=FFjla42xDV1XZG eNnE+prAj1+eat0s0MVaIwwm7bQflx1zInJiBIv2x6H8OH0WxEgHPeHsg43UJu5fMPCnq/F27O/gf /+f5uSqg+V0JIBqRJqVXfFfM0OL1VW/6ULJCPIb/1/VmsogYCdO8fHuk1N/vvIu5N7cmiZlFFHgom juSFlcbNCANCa8KDvTc6YMJn7siau8cVo4hFlBZq0B0dyEZI0v6Rr0yU50nbgX4e9VgO/FmFhKTqe 61G90IJqCpmruZIGG/hGSWpZgXTBwz+rlLLmcVd5w0QjTOoO2UrcY8IIsc03z+lqQcO+GXExWgQLG UxG5taMQpl+rlhNPgGgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5mhI-0000MN-BM; Mon, 18 Mar 2019 07:28:36 +0000 Received: from mout02.posteo.de ([185.67.36.142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5mhF-0000Lg-Cx for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 07:28:34 +0000 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8ECAF2400E6 for ; Mon, 18 Mar 2019 08:28:28 +0100 (CET) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 44N7884Lwgz9rxH; Mon, 18 Mar 2019 08:28:24 +0100 (CET) Subject: Re: [PATCH] tty: atmel_serial: fix a NULL pointer dereference To: Kangjie Lu References: <20190315171606.6282-1-kjlu@umn.edu> From: Richard Genoud Message-ID: Date: Mon, 18 Mar 2019 08:28:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190315171606.6282-1-kjlu@umn.edu> Content-Language: fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_002833_592442_21034504 X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Greg Kroah-Hartman , pakki001@umn.edu, linux-kernel@vger.kernel.org, Ludovic Desroches , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgMTUvMDMvMjAxOSDDoCAxODoxNiwgS2FuZ2ppZSBMdSBhIMOpY3JpdMKgOgo+IEluIGNhc2Ug ZG1hZW5naW5lX3ByZXBfZG1hX2N5Y2xpYyBmYWlscywgdGhlIGZpeCByZXR1cm5zIGEgcHJvcGVy Cj4gZXJyb3IgY29kZSB0byBhdm9pZCBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UuCj4gCj4gU2ln bmVkLW9mZi1ieTogS2FuZ2ppZSBMdSA8a2psdUB1bW4uZWR1Pgo+IEZpeGVzOiAzNGRmNDJmNTlh NjAgKCJzZXJpYWw6IGF0OTE6IGFkZCByeCBkbWEgc3VwcG9ydCIpCkFja2VkLWJ5OiBSaWNoYXJk IEdlbm91ZCA8cmljaGFyZC5nZW5vdWRAZ21haWwuY29tPgoKPiAKPiAtLS0KPiBWMjogc2ltcGxp ZmllZCB0aGUgcGF0Y2ggYXMgc3VnZ2VzdGVkIGJ5Cj4gUmljaGFyZCBHZW5vdWQgPHJpY2hhcmQu Z2Vub3VkQGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy90dHkvc2VyaWFsL2F0bWVsX3Nlcmlh bC5jIHwgNCArKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy90dHkvc2VyaWFsL2F0bWVsX3NlcmlhbC5jIGIvZHJpdmVycy90dHkv c2VyaWFsL2F0bWVsX3NlcmlhbC5jCj4gaW5kZXggMDUxNDdmZTI0MzQzLi40MWI3MjhkMjIzZDEg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy90dHkvc2VyaWFsL2F0bWVsX3NlcmlhbC5jCj4gKysrIGIv ZHJpdmVycy90dHkvc2VyaWFsL2F0bWVsX3NlcmlhbC5jCj4gQEAgLTEyODgsNiArMTI4OCwxMCBA QCBzdGF0aWMgaW50IGF0bWVsX3ByZXBhcmVfcnhfZG1hKHN0cnVjdCB1YXJ0X3BvcnQgKnBvcnQp Cj4gIAkJCQkJIHNnX2RtYV9sZW4oJmF0bWVsX3BvcnQtPnNnX3J4KS8yLAo+ICAJCQkJCSBETUFf REVWX1RPX01FTSwKPiAgCQkJCQkgRE1BX1BSRVBfSU5URVJSVVBUKTsKPiArCWlmICghZGVzYykg ewo+ICsJCWRldl9lcnIocG9ydC0+ZGV2LCAiUHJlcGFyaW5nIERNQSBjeWNsaWMgZmFpbGVkXG4i KTsKPiArCQlnb3RvIGNoYW5fZXJyOwo+ICsJfQo+ICAJZGVzYy0+Y2FsbGJhY2sgPSBhdG1lbF9j b21wbGV0ZV9yeF9kbWE7Cj4gIAlkZXNjLT5jYWxsYmFja19wYXJhbSA9IHBvcnQ7Cj4gIAlhdG1l bF9wb3J0LT5kZXNjX3J4ID0gZGVzYzsKPiAKClRoYW5rcyAhCgpSaWNoYXJkCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1h aWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==