All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxg@mellanox.com (Max Gurtovoy)
Subject: [PATCH 2/2 v3] nvme-rdma: Fix command completion race at error recovery
Date: Sun, 15 Apr 2018 16:50:58 +0300	[thread overview]
Message-ID: <cba7bf85-464d-adfe-55d1-75bede49e36c@mellanox.com> (raw)
In-Reply-To: <20180412133730.GB5791@lst.de>



On 4/12/2018 4:37 PM, Christoph Hellwig wrote:
> We really need to keep this code in sync with the various transports,
> chances are any race you see in RDMA will happen elsewhere as well.
> 

I saw that the pci driver calls nvme_pci_disable so it will not get any 
interrupts/completion from the drive. so the nvme_cancel_request loop is 
safe.
Regarding FC we need James here.

If you're talking about pushing it to common code in the core layer, 
then I guess it's a good idea with/without this patchset.

      reply	other threads:[~2018-04-15 13:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 16:07 [PATCH 0/2 v3] Fix nvme-rdma timeout flow Israel Rukshin
2018-04-11 16:07 ` [PATCH 1/2 v3] nvme-rdma: Fix race between queue timeout and error recovery Israel Rukshin
2018-04-12 13:36   ` Christoph Hellwig
2018-04-11 16:07 ` [PATCH 2/2 v3] nvme-rdma: Fix command completion race at " Israel Rukshin
2018-04-12 13:37   ` Christoph Hellwig
2018-04-15 13:50     ` Max Gurtovoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cba7bf85-464d-adfe-55d1-75bede49e36c@mellanox.com \
    --to=maxg@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.