From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E67C433ED for ; Fri, 7 May 2021 21:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7700361458 for ; Fri, 7 May 2021 21:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbhEGV3M (ORCPT ); Fri, 7 May 2021 17:29:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44078 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbhEGV3K (ORCPT ); Fri, 7 May 2021 17:29:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620422890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pVNjq4cwxRpZVEM9G+ZCz6caWZiQ6FKaXq/9liRlvVI=; b=hXBuxzLQgTQbJFjx4bBmYLDzBZEb1mzg7YWNVI4nMDHEcoa3cQ0tqImCAcXxoZAtqEGNtp uWYDY2s20iOX/Zop418X0pdr/iHYw2Rii0SiOYRmoEdgK02h2TFhOzJ9YIVoQOiszdLz6t lGANg3i3uOGBictOQeRoyh/WG8GbCyU= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-284-SZHAzaX6MNKcxCosRygqOQ-1; Fri, 07 May 2021 17:28:06 -0400 X-MC-Unique: SZHAzaX6MNKcxCosRygqOQ-1 Received: by mail-qv1-f71.google.com with SMTP id l5-20020a0ce0850000b02901c37c281207so7575935qvk.11 for ; Fri, 07 May 2021 14:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=pVNjq4cwxRpZVEM9G+ZCz6caWZiQ6FKaXq/9liRlvVI=; b=D5/u9p4X3lKO190VpqsG8I1WrKJ5dLKJITys9P+JPursSug8F/v0/SvKPP75hjL1Z+ 5J9dVAWPyC7/OU0tbHiMVo5iweBSlmijkYQvCEaV62HUziqPh0rVXBez5t4hpqSObHh+ N+Q/PHW2rXza7Zn4Gxvi0FS5lgyWsM4PTMMeENeVT+LCsVViMghTIc4EQhZTIe4TZfBJ LHmN0MNDrIaJ1bZa2t9qcZnkj2vDJ9+2jw08bXWsWE+EtiH9gnnXaQ9Hisnx5SC3agF+ Kcdm8yTkTkU4vFZ/h1jbaV3AQCDZ21VZ8fhyPhetuAC/q3zYLyEOoG1wdApeIB+UCJ5Y sqLw== X-Gm-Message-State: AOAM5314Y53o03qMwt+X6WDWG7acxiv8GA5rVt0LIBdo/kzZwiVxbPNI MGInCt+2aZuB6OS3ivgJl4KwEOs4RGDVEJLVFLh4pwEYbbbhajHvFfeU2/giR/iQ/jme87/RGk0 1WT2PetqzVz8b6PvuNTAKWRcO X-Received: by 2002:ac8:109a:: with SMTP id a26mr11012770qtj.156.1620422885845; Fri, 07 May 2021 14:28:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4umG7ULJ2428gNNMYBy++wm63s5NWc12Pht4FLFgn8RWxeg/DGz3zuQqldKEj2lf9x+1nFA== X-Received: by 2002:ac8:109a:: with SMTP id a26mr11012759qtj.156.1620422885691; Fri, 07 May 2021 14:28:05 -0700 (PDT) Received: from Ruby.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id v18sm1635624qkv.34.2021.05.07.14.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 14:28:05 -0700 (PDT) Message-ID: Subject: Re: [Intel-gfx] [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() in drm_dp_read_downstream_info() From: Lyude Paul To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , David Airlie , open list , Maxime Ripard Date: Fri, 07 May 2021 17:28:03 -0400 In-Reply-To: References: <20210430223428.10514-1-lyude@redhat.com> <20210430223428.10514-2-lyude@redhat.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-05-03 at 06:06 +0300, Ville Syrjälä wrote: > On Fri, Apr 30, 2021 at 06:34:28PM -0400, Lyude Paul wrote: > > Noticed this while fixing another issue in drm_dp_read_downstream_info(), > > the open coded DP_DOWNSTREAMPORT_PRESENT check here just duplicates what > > we > > already do in drm_dp_is_branch(), so just get rid of it. > > > > Signed-off-by: Lyude Paul > > --- > >  drivers/gpu/drm/drm_dp_helper.c | 4 +--- > >  1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > > b/drivers/gpu/drm/drm_dp_helper.c > > index 27c8c5bdf7d9..0f84df8798ab 100644 > > --- a/drivers/gpu/drm/drm_dp_helper.c > > +++ b/drivers/gpu/drm/drm_dp_helper.c > > @@ -677,9 +677,7 @@ int drm_dp_read_downstream_info(struct drm_dp_aux > > *aux, > >         memset(downstream_ports, 0, DP_MAX_DOWNSTREAM_PORTS); > >   > >         /* No downstream info to read */ > > -       if (!drm_dp_is_branch(dpcd) || > > -           dpcd[DP_DPCD_REV] < DP_DPCD_REV_10 || > > -           !(dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT)) > > +       if (!drm_dp_is_branch(dpcd) || dpcd[DP_DPCD_REV] < DP_DPCD_REV_10) > > BTW that DPCD_REV check looks rather wrong. > > Reviewed-by: Ville Syrjälä I'll send out a separate fix for this in just a moment, thanks for pointing it out! > > >                 return 0; > >   > >         /* Some branches advertise having 0 downstream ports, despite also > > advertising they have a > > -- > > 2.30.2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9551AC433B4 for ; Fri, 7 May 2021 21:28:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E82861415 for ; Fri, 7 May 2021 21:28:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E82861415 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C9326EE7D; Fri, 7 May 2021 21:28:29 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6B296EE7D for ; Fri, 7 May 2021 21:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620422907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pVNjq4cwxRpZVEM9G+ZCz6caWZiQ6FKaXq/9liRlvVI=; b=T+hZyPJ/jdS/MLCWk0T807dQPoYlWXpGZAoJgCdUTX5CECr2YcyelcllQ8H9jpr5g8uXdF z+qVaDhRNgUb6esdQNnxMXFtQAcy+oZJsCHhK3xPcnhqLpHYiF8jbhnGm29/olKHj2LDxD Jd4Ux2nCG8gShFL60sPggBt8hEoz914= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-448-ew5IepA7NdKUZLA6Ur00bQ-1; Fri, 07 May 2021 17:28:19 -0400 X-MC-Unique: ew5IepA7NdKUZLA6Ur00bQ-1 Received: by mail-qk1-f197.google.com with SMTP id i62-20020a3786410000b02902e4f9ff4af8so7204997qkd.8 for ; Fri, 07 May 2021 14:28:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=pVNjq4cwxRpZVEM9G+ZCz6caWZiQ6FKaXq/9liRlvVI=; b=SIZhWlMV5hin77vKGHs3b8IcTWZhQvY/xBUrOqRtUahhRawsfFCyoB2RaAjqA5CXx6 iEuYqEYu4D5rcCZ4qj91tOo7iKGoTDOpD9BGl17jtSdcks6Llx3pnNhPAtViQzUYYljs 76Bd5m6UMKX+ez09svUdDbSlp1Uf8fbGK0u2/QHcon5Ic3/SlnDaP7lOH71XkijD1+J2 3BPLc8QpFtUS1eBOI3zr/GRXMTgerbLqNcPuUqyVf9P2S70t3Uy6cu/fcsYl2a1GpxQ9 5EKIky7L2TxcMLKewuGmdny1gOaLkvi4YYykMbR20jI1nWgj+U4HazXK/HObNRHsc8VF 1ozg== X-Gm-Message-State: AOAM530nvSJ3AsJVl1BGaYI6PZwfxTq72NfJMN4gBZBSGBkhMfYOy2dG rkTqtc0B3CQ+vLTtmJyydbvKbQXXfpFPng8FtYPF+vyxuUbXwmzkrDtA4hQ4Hcte/mrNSPWE+ya 00xJQpFHbzlxEUWSiifE74VIbRO8P X-Received: by 2002:ac8:109a:: with SMTP id a26mr11012785qtj.156.1620422885894; Fri, 07 May 2021 14:28:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4umG7ULJ2428gNNMYBy++wm63s5NWc12Pht4FLFgn8RWxeg/DGz3zuQqldKEj2lf9x+1nFA== X-Received: by 2002:ac8:109a:: with SMTP id a26mr11012759qtj.156.1620422885691; Fri, 07 May 2021 14:28:05 -0700 (PDT) Received: from Ruby.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id v18sm1635624qkv.34.2021.05.07.14.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 14:28:05 -0700 (PDT) Message-ID: Subject: Re: [Intel-gfx] [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() in drm_dp_read_downstream_info() From: Lyude Paul To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Date: Fri, 07 May 2021 17:28:03 -0400 In-Reply-To: References: <20210430223428.10514-1-lyude@redhat.com> <20210430223428.10514-2-lyude@redhat.com> Organization: Red Hat User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, open list , dri-devel@lists.freedesktop.org, Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 2021-05-03 at 06:06 +0300, Ville Syrjälä wrote: > On Fri, Apr 30, 2021 at 06:34:28PM -0400, Lyude Paul wrote: > > Noticed this while fixing another issue in drm_dp_read_downstream_info(), > > the open coded DP_DOWNSTREAMPORT_PRESENT check here just duplicates what > > we > > already do in drm_dp_is_branch(), so just get rid of it. > > > > Signed-off-by: Lyude Paul > > --- > >  drivers/gpu/drm/drm_dp_helper.c | 4 +--- > >  1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > > b/drivers/gpu/drm/drm_dp_helper.c > > index 27c8c5bdf7d9..0f84df8798ab 100644 > > --- a/drivers/gpu/drm/drm_dp_helper.c > > +++ b/drivers/gpu/drm/drm_dp_helper.c > > @@ -677,9 +677,7 @@ int drm_dp_read_downstream_info(struct drm_dp_aux > > *aux, > >         memset(downstream_ports, 0, DP_MAX_DOWNSTREAM_PORTS); > >   > >         /* No downstream info to read */ > > -       if (!drm_dp_is_branch(dpcd) || > > -           dpcd[DP_DPCD_REV] < DP_DPCD_REV_10 || > > -           !(dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT)) > > +       if (!drm_dp_is_branch(dpcd) || dpcd[DP_DPCD_REV] < DP_DPCD_REV_10) > > BTW that DPCD_REV check looks rather wrong. > > Reviewed-by: Ville Syrjälä I'll send out a separate fix for this in just a moment, thanks for pointing it out! > > >                 return 0; > >   > >         /* Some branches advertise having 0 downstream ports, despite also > > advertising they have a > > -- > > 2.30.2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5BCC433B4 for ; Fri, 7 May 2021 21:28:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47A8060FDC for ; Fri, 7 May 2021 21:28:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47A8060FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C5C8C88EAA; Fri, 7 May 2021 21:28:11 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53A016EE7D for ; Fri, 7 May 2021 21:28:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620422889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pVNjq4cwxRpZVEM9G+ZCz6caWZiQ6FKaXq/9liRlvVI=; b=CB4eAEN+0/XWMhVEhiFZnsako52IYSDJfMjnmqIOhL9e90i0+tbqbOVFUkGQO22MZACY54 Jry2hKiaXS8oD7/eqdC47hfe7WN2IU0hugfCMbbSl5NRRYe/NTgBtVfJao2TOtyoSzn3jU tiIjALcFtd9Fv4cMhL4GzEnnuf2c7nA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-415-d3EUyrcxMjGtCyRG5GbAEg-1; Fri, 07 May 2021 17:28:06 -0400 X-MC-Unique: d3EUyrcxMjGtCyRG5GbAEg-1 Received: by mail-qv1-f69.google.com with SMTP id x6-20020a0cda060000b02901c4b3f7d3d9so7634489qvj.0 for ; Fri, 07 May 2021 14:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=pVNjq4cwxRpZVEM9G+ZCz6caWZiQ6FKaXq/9liRlvVI=; b=fJTodGf34NIgHo+Rq3MBSGO21dxLTCu4GZijz9kIkgzh0pGmKTdynTpFdcAb0agtBT fEtWaNusLo8AQOwJInW2ogKA8ll3iVtjAtaIhug724FOVlO0FcieVXR9Eek04HOJM3Q4 YjHif6Z/vlsXKXU1PqksmoEvhc7aVN2EZQrvFi6U7YzK9aPoXo1Ofeelpf+4UEMVS7WE PrKPkuQrlLZjSvZB/ATcd5Q/z62ZsNVvviC356V+OFOW8ZZENx5WcxYKO03nXwS60FRL OdTfsnYtceYs1Ejb6Mv7nFOpNbxg/6bFC6oUEvcpvINrIeqIyUnh9tWiC2dxWnDwPd4n uFgA== X-Gm-Message-State: AOAM530FEDoiXAAhKCw54rmYpB/K5/XVBiqiU2VfsQP/1+Gsd5hVcjts 2pIzelWL5PCvkNcSkKmKqa51L6EViqKbgZAYvRuW1RiiNh/TpHOh3/2d7jOsLGp/tuBHmvd0j1k Ar0LEsGB2UnqLiEEMzxv1u2+n3ffe X-Received: by 2002:ac8:109a:: with SMTP id a26mr11012789qtj.156.1620422885957; Fri, 07 May 2021 14:28:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4umG7ULJ2428gNNMYBy++wm63s5NWc12Pht4FLFgn8RWxeg/DGz3zuQqldKEj2lf9x+1nFA== X-Received: by 2002:ac8:109a:: with SMTP id a26mr11012759qtj.156.1620422885691; Fri, 07 May 2021 14:28:05 -0700 (PDT) Received: from Ruby.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id v18sm1635624qkv.34.2021.05.07.14.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 May 2021 14:28:05 -0700 (PDT) Message-ID: From: Lyude Paul To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Date: Fri, 07 May 2021 17:28:03 -0400 In-Reply-To: References: <20210430223428.10514-1-lyude@redhat.com> <20210430223428.10514-2-lyude@redhat.com> Organization: Red Hat User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: Re: [Intel-gfx] [PATCH 2/2] drm/dp: Drop open-coded drm_dp_is_branch() in drm_dp_read_downstream_info() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , intel-gfx@lists.freedesktop.org, open list , Maxime Ripard , dri-devel@lists.freedesktop.org, Thomas Zimmermann Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gTW9uLCAyMDIxLTA1LTAzIGF0IDA2OjA2ICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gRnJpLCBBcHIgMzAsIDIwMjEgYXQgMDY6MzQ6MjhQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3 cm90ZToKPiA+IE5vdGljZWQgdGhpcyB3aGlsZSBmaXhpbmcgYW5vdGhlciBpc3N1ZSBpbiBkcm1f ZHBfcmVhZF9kb3duc3RyZWFtX2luZm8oKSwKPiA+IHRoZSBvcGVuIGNvZGVkIERQX0RPV05TVFJF QU1QT1JUX1BSRVNFTlQgY2hlY2sgaGVyZSBqdXN0IGR1cGxpY2F0ZXMgd2hhdAo+ID4gd2UKPiA+ IGFscmVhZHkgZG8gaW4gZHJtX2RwX2lzX2JyYW5jaCgpLCBzbyBqdXN0IGdldCByaWQgb2YgaXQu Cj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4g PiAtLS0KPiA+IMKgZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYyB8IDQgKy0tLQo+ID4g wqAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pCj4gPiAKPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX2hlbHBlci5jCj4gPiBiL2RyaXZl cnMvZ3B1L2RybS9kcm1fZHBfaGVscGVyLmMKPiA+IGluZGV4IDI3YzhjNWJkZjdkOS4uMGY4NGRm ODc5OGFiIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYwo+ID4gQEAgLTY3Nyw5ICs2 NzcsNyBAQCBpbnQgZHJtX2RwX3JlYWRfZG93bnN0cmVhbV9pbmZvKHN0cnVjdCBkcm1fZHBfYXV4 Cj4gPiAqYXV4LAo+ID4gwqDCoMKgwqDCoMKgwqDCoG1lbXNldChkb3duc3RyZWFtX3BvcnRzLCAw LCBEUF9NQVhfRE9XTlNUUkVBTV9QT1JUUyk7Cj4gPiDCoAo+ID4gwqDCoMKgwqDCoMKgwqDCoC8q IE5vIGRvd25zdHJlYW0gaW5mbyB0byByZWFkICovCj4gPiAtwqDCoMKgwqDCoMKgwqBpZiAoIWRy bV9kcF9pc19icmFuY2goZHBjZCkgfHwKPiA+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoCBkcGNkW0RQ X0RQQ0RfUkVWXSA8IERQX0RQQ0RfUkVWXzEwIHx8Cj4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqAg IShkcGNkW0RQX0RPV05TVFJFQU1QT1JUX1BSRVNFTlRdICYgRFBfRFdOX1NUUk1fUE9SVF9QUkVT RU5UKSkKPiA+ICvCoMKgwqDCoMKgwqDCoGlmICghZHJtX2RwX2lzX2JyYW5jaChkcGNkKSB8fCBk cGNkW0RQX0RQQ0RfUkVWXSA8IERQX0RQQ0RfUkVWXzEwKQo+IAo+IEJUVyB0aGF0IERQQ0RfUkVW IGNoZWNrIGxvb2tzIHJhdGhlciB3cm9uZy4KPiAKPiBSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOk bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCkknbGwgc2VuZCBvdXQgYSBzZXBh cmF0ZSBmaXggZm9yIHRoaXMgaW4ganVzdCBhIG1vbWVudCwgdGhhbmtzIGZvciBwb2ludGluZyBp dApvdXQhCgo+IAo+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZXR1cm4gMDsK PiA+IMKgCj4gPiDCoMKgwqDCoMKgwqDCoMKgLyogU29tZSBicmFuY2hlcyBhZHZlcnRpc2UgaGF2 aW5nIDAgZG93bnN0cmVhbSBwb3J0cywgZGVzcGl0ZSBhbHNvCj4gPiBhZHZlcnRpc2luZyB0aGV5 IGhhdmUgYQo+ID4gLS0gCj4gPiAyLjMwLjIKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCgotLSAKQ2hlZXJzLAogTHl1 ZGUgUGF1bCAoc2hlL2hlcikKIFNvZnR3YXJlIEVuZ2luZWVyIGF0IFJlZCBIYXQKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=