From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20DEC0502A for ; Tue, 30 Aug 2022 03:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229751AbiH3Dqz (ORCPT ); Mon, 29 Aug 2022 23:46:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiH3Dqx (ORCPT ); Mon, 29 Aug 2022 23:46:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8248C910A5; Mon, 29 Aug 2022 20:46:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3C5A1B81629; Tue, 30 Aug 2022 03:46:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4193C433C1; Tue, 30 Aug 2022 03:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661831210; bh=mUnVB81vCce6m7OfZt7TrDrPDZqYmD/JX2n989MKdws=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ODGV04xUfpKrwFYHazoWe+IjxbqgDMXmiHf4Gq39mVt81mPQypSVnH0I4QBqoWyu4 dYvUKBFmaPTkKAg+6ui6+Tu1J0j00+Ls31ZJYnRaBaaZA/Sv2X7e5kb2gbxvMUMDHq AwmlAIAtqqqVospIZCYjvhshBgiH51i0KHaFZmi3vXTaF+gpTb8m12qbjpgezORSh0 sx2y1NX1PZbzGEeHKuFko9a9WZApDbzzTupF2Nz43+O1zRlVFOtlceXbpIXv28boTY UT3P1f1hQ75dGShUQ15AXotQv9dsT7YnGRNYDDAwDin0ToC5ilNoUt2MBgGdsuuzk/ ErovymCilNn+A== Message-ID: Date: Tue, 30 Aug 2022 11:46:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [f2fs-dev] [PATCH] f2fs: fix missing mapping caused by the mount/umount race Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: syzbot+775a3440817f74fddb8c@syzkaller.appspotmail.com, stable@vger.kernel.org References: <20220829215206.3082124-1-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20220829215206.3082124-1-jaegeuk@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/30 5:52, Jaegeuk Kim wrote: > Sometimes we can get a cached meta_inode which has no aops yet. Let's set it > all the time to fix the below panic. > > Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > Mem abort info: > ESR = 0x0000000086000004 > EC = 0x21: IABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x04: level 0 translation fault > user pgtable: 4k pages, 48-bit VAs, pgdp=0000000109ee4000 > [0000000000000000] pgd=0000000000000000, p4d=0000000000000000 > Internal error: Oops: 86000004 [#1] PREEMPT SMP > Modules linked in: > CPU: 1 PID: 3045 Comm: syz-executor330 Not tainted 6.0.0-rc2-syzkaller-16455-ga41a877bc12d #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022 > pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : 0x0 > lr : folio_mark_dirty+0xbc/0x208 mm/page-writeback.c:2748 > sp : ffff800012783970 > x29: ffff800012783970 x28: 0000000000000000 x27: ffff800012783b08 > x26: 0000000000000001 x25: 0000000000000400 x24: 0000000000000001 > x23: ffff0000c736e000 x22: 0000000000000045 x21: 05ffc00000000015 > x20: ffff0000ca7403b8 x19: fffffc00032ec600 x18: 0000000000000181 > x17: ffff80000c04d6bc x16: ffff80000dbb8658 x15: 0000000000000000 > x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > x11: ff808000083e9814 x10: 0000000000000000 x9 : ffff8000083e9814 > x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 > x5 : ffff0000cbb19000 x4 : ffff0000cb3d2000 x3 : ffff0000cbb18f80 > x2 : fffffffffffffff0 x1 : fffffc00032ec600 x0 : ffff0000ca7403b8 > Call trace: > 0x0 > set_page_dirty+0x38/0xbc mm/folio-compat.c:62 > f2fs_update_meta_page+0x80/0xa8 fs/f2fs/segment.c:2369 > do_checkpoint+0x794/0xea8 fs/f2fs/checkpoint.c:1522 > f2fs_write_checkpoint+0x3b8/0x568 fs/f2fs/checkpoint.c:1679 > > Cc: stable@vger.kernel.org > Reported-by: syzbot+775a3440817f74fddb8c@syzkaller.appspotmail.com > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/inode.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 6d11c365d7b4..1feb0a8a699e 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -490,10 +490,7 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > if (!inode) > return ERR_PTR(-ENOMEM); > > - if (!(inode->i_state & I_NEW)) { > - trace_f2fs_iget(inode); > - return inode; > - } > + /* We can see an old cached inode. Let's set the aops all the time. */ Why an old cached inode (has no I_NEW flag) has NULL a_ops pointer? If it is a bad inode, it should be unhashed before unlock_new_inode(). Thanks, > if (ino == F2FS_NODE_INO(sbi) || ino == F2FS_META_INO(sbi)) > goto make_now; > > @@ -502,6 +499,11 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > goto make_now; > #endif > > + if (!(inode->i_state & I_NEW)) { > + trace_f2fs_iget(inode); > + return inode; > + } > + > ret = do_read_inode(inode); > if (ret) > goto bad_inode; > @@ -557,7 +559,8 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > file_dont_truncate(inode); > } > > - unlock_new_inode(inode); > + if (inode->i_state & I_NEW) > + unlock_new_inode(inode); > trace_f2fs_iget(inode); > return inode; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6E83ECAAD5 for ; Tue, 30 Aug 2022 03:47:17 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oSsDb-0001Ji-8E; Tue, 30 Aug 2022 03:47:15 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oSsDO-0001JS-Kc for linux-f2fs-devel@lists.sourceforge.net; Tue, 30 Aug 2022 03:47:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nsfAYM+HmtjLMt47bmOLGBKBDg2/G/9B9xwrlHSoq7I=; b=A10qzW18TsLpKxfVTa3wXHFKaT jsa9ONC347r/kcytv69ireLa+csHeFVTK4Vfw4PFk+wWS18wrq3neRxhHfs2fUJLK12WHgtIxsZYC DNpdNDHUHDKQXQ/T4iZrLrv/38bGbrkD3D1YU56go+pZjXxLRm+vHTVjJ4tEWuBLJXs0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nsfAYM+HmtjLMt47bmOLGBKBDg2/G/9B9xwrlHSoq7I=; b=h+0mZFx6eM/bSzpA+r0Q7eW5hI LhPdHgPE75erZKrMMjgPxn21Oay6znPHzjAsofNw+f6fdlobpbQqRislVigbbPd/6LQGTZ5j4Ih2P ar7D5OIdME5TjyloBEfKAKQtYW/vX86tUVLcYCgw0a/XWkVacXOC3qmHbd5iH1PgsXTM=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oSsDN-0074CG-Mv for linux-f2fs-devel@lists.sourceforge.net; Tue, 30 Aug 2022 03:47:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6335EB81632; Tue, 30 Aug 2022 03:46:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4193C433C1; Tue, 30 Aug 2022 03:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661831210; bh=mUnVB81vCce6m7OfZt7TrDrPDZqYmD/JX2n989MKdws=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ODGV04xUfpKrwFYHazoWe+IjxbqgDMXmiHf4Gq39mVt81mPQypSVnH0I4QBqoWyu4 dYvUKBFmaPTkKAg+6ui6+Tu1J0j00+Ls31ZJYnRaBaaZA/Sv2X7e5kb2gbxvMUMDHq AwmlAIAtqqqVospIZCYjvhshBgiH51i0KHaFZmi3vXTaF+gpTb8m12qbjpgezORSh0 sx2y1NX1PZbzGEeHKuFko9a9WZApDbzzTupF2Nz43+O1zRlVFOtlceXbpIXv28boTY UT3P1f1hQ75dGShUQ15AXotQv9dsT7YnGRNYDDAwDin0ToC5ilNoUt2MBgGdsuuzk/ ErovymCilNn+A== Message-ID: Date: Tue, 30 Aug 2022 11:46:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20220829215206.3082124-1-jaegeuk@kernel.org> From: Chao Yu In-Reply-To: <20220829215206.3082124-1-jaegeuk@kernel.org> X-Headers-End: 1oSsDN-0074CG-Mv Subject: Re: [f2fs-dev] [PATCH] f2fs: fix missing mapping caused by the mount/umount race X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syzbot+775a3440817f74fddb8c@syzkaller.appspotmail.com, stable@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2022/8/30 5:52, Jaegeuk Kim wrote: > Sometimes we can get a cached meta_inode which has no aops yet. Let's set it > all the time to fix the below panic. > > Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > Mem abort info: > ESR = 0x0000000086000004 > EC = 0x21: IABT (current EL), IL = 32 bits > SET = 0, FnV = 0 > EA = 0, S1PTW = 0 > FSC = 0x04: level 0 translation fault > user pgtable: 4k pages, 48-bit VAs, pgdp=0000000109ee4000 > [0000000000000000] pgd=0000000000000000, p4d=0000000000000000 > Internal error: Oops: 86000004 [#1] PREEMPT SMP > Modules linked in: > CPU: 1 PID: 3045 Comm: syz-executor330 Not tainted 6.0.0-rc2-syzkaller-16455-ga41a877bc12d #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/22/2022 > pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : 0x0 > lr : folio_mark_dirty+0xbc/0x208 mm/page-writeback.c:2748 > sp : ffff800012783970 > x29: ffff800012783970 x28: 0000000000000000 x27: ffff800012783b08 > x26: 0000000000000001 x25: 0000000000000400 x24: 0000000000000001 > x23: ffff0000c736e000 x22: 0000000000000045 x21: 05ffc00000000015 > x20: ffff0000ca7403b8 x19: fffffc00032ec600 x18: 0000000000000181 > x17: ffff80000c04d6bc x16: ffff80000dbb8658 x15: 0000000000000000 > x14: 0000000000000000 x13: 0000000000000000 x12: 0000000000000000 > x11: ff808000083e9814 x10: 0000000000000000 x9 : ffff8000083e9814 > x8 : 0000000000000000 x7 : 0000000000000000 x6 : 0000000000000000 > x5 : ffff0000cbb19000 x4 : ffff0000cb3d2000 x3 : ffff0000cbb18f80 > x2 : fffffffffffffff0 x1 : fffffc00032ec600 x0 : ffff0000ca7403b8 > Call trace: > 0x0 > set_page_dirty+0x38/0xbc mm/folio-compat.c:62 > f2fs_update_meta_page+0x80/0xa8 fs/f2fs/segment.c:2369 > do_checkpoint+0x794/0xea8 fs/f2fs/checkpoint.c:1522 > f2fs_write_checkpoint+0x3b8/0x568 fs/f2fs/checkpoint.c:1679 > > Cc: stable@vger.kernel.org > Reported-by: syzbot+775a3440817f74fddb8c@syzkaller.appspotmail.com > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/inode.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 6d11c365d7b4..1feb0a8a699e 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -490,10 +490,7 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > if (!inode) > return ERR_PTR(-ENOMEM); > > - if (!(inode->i_state & I_NEW)) { > - trace_f2fs_iget(inode); > - return inode; > - } > + /* We can see an old cached inode. Let's set the aops all the time. */ Why an old cached inode (has no I_NEW flag) has NULL a_ops pointer? If it is a bad inode, it should be unhashed before unlock_new_inode(). Thanks, > if (ino == F2FS_NODE_INO(sbi) || ino == F2FS_META_INO(sbi)) > goto make_now; > > @@ -502,6 +499,11 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > goto make_now; > #endif > > + if (!(inode->i_state & I_NEW)) { > + trace_f2fs_iget(inode); > + return inode; > + } > + > ret = do_read_inode(inode); > if (ret) > goto bad_inode; > @@ -557,7 +559,8 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > file_dont_truncate(inode); > } > > - unlock_new_inode(inode); > + if (inode->i_state & I_NEW) > + unlock_new_inode(inode); > trace_f2fs_iget(inode); > return inode; > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel